[PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left
@ 2019-08-16  6:10 Zhang, Shenglei
  2019-08-16  6:19 ` Gao, Zhichao
  0 siblings, 1 reply; 4+ messages in thread
From: Zhang, Shenglei @ 2019-08-16  6:10 UTC (permalink / raw)
  To: devel; +Cc: Jaben Carsey, Ray Ni, Zhichao Gao

Replace the operation to shift logical left with the function
LShiftU64, which has the same functionality.
The original code causes ShellPkg build failure with build
target"-b NOOPT".

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
v2: There is no return target from LShiftU64 in v1 patch.
    So update code to "Val = LShiftU64(Val,32)".

 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
index 94bafa22ef4c..a569c3c55406 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
@@ -294,7 +294,7 @@ DumpUint64 (
 
   Val = *(UINT32*)(Ptr + sizeof (UINT32));
 
-  Val <<= 32;
+  Val = LShiftU64(Val,32);
   Val |= (UINT64)*(UINT32*)Ptr;
 
   Print (Format, Val);
-- 
2.18.0.windows.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left
  2019-08-16  6:10 [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left Zhang, Shenglei
@ 2019-08-16  6:19 ` Gao, Zhichao
  2019-08-16  7:51   ` Zhang, Shenglei
  0 siblings, 1 reply; 4+ messages in thread
From: Gao, Zhichao @ 2019-08-16  6:19 UTC (permalink / raw)
  To: Zhang, Shenglei, devel@edk2.groups.io; +Cc: Carsey, Jaben, Ni, Ray

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Friday, August 16, 2019 2:11 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Gao, Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace
> shift logical left
> 
> Replace the operation to shift logical left with the function LShiftU64, which
> has the same functionality.
> The original code causes ShellPkg build failure with build target"-b NOOPT".
> 
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> v2: There is no return target from LShiftU64 in v1 patch.
>     So update code to "Val = LShiftU64(Val,32)".
> 
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> index 94bafa22ef4c..a569c3c55406 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> @@ -294,7 +294,7 @@ DumpUint64 (
> 
>    Val = *(UINT32*)(Ptr + sizeof (UINT32));
> 
> -  Val <<= 32;
> +  Val = LShiftU64(Val,32);
>    Val |= (UINT64)*(UINT32*)Ptr;
> 
>    Print (Format, Val);
> --
> 2.18.0.windows.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left
  2019-08-16  6:19 ` Gao, Zhichao
@ 2019-08-16  7:51   ` Zhang, Shenglei
  2019-08-19  0:48     ` [edk2-devel] " Liming Gao
  0 siblings, 1 reply; 4+ messages in thread
From: Zhang, Shenglei @ 2019-08-16  7:51 UTC (permalink / raw)
  To: Gao, Zhichao, devel@edk2.groups.io; +Cc: Carsey, Jaben, Ni, Ray

Hi All,

This is patch to fix build failure. I'd like the patch to be checked in before this stable tag.

Thanks,
Shenglei

> -----Original Message-----
> From: Gao, Zhichao
> Sent: Friday, August 16, 2019 2:19 PM
> To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: RE: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib:
> Replace shift logical left
> 
> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
> 
> Thanks,
> Zhichao
> 
> > -----Original Message-----
> > From: Zhang, Shenglei
> > Sent: Friday, August 16, 2019 2:11 PM
> > To: devel@edk2.groups.io
> > Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > Gao, Zhichao <zhichao.gao@intel.com>
> > Subject: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace
> > shift logical left
> >
> > Replace the operation to shift logical left with the function LShiftU64, which
> > has the same functionality.
> > The original code causes ShellPkg build failure with build target"-b NOOPT".
> >
> > Cc: Jaben Carsey <jaben.carsey@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> > v2: There is no return target from LShiftU64 in v1 patch.
> >     So update code to "Val = LShiftU64(Val,32)".
> >
> >  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> > index 94bafa22ef4c..a569c3c55406 100644
> > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> > @@ -294,7 +294,7 @@ DumpUint64 (
> >
> >    Val = *(UINT32*)(Ptr + sizeof (UINT32));
> >
> > -  Val <<= 32;
> > +  Val = LShiftU64(Val,32);
> >    Val |= (UINT64)*(UINT32*)Ptr;
> >
> >    Print (Format, Val);
> > --
> > 2.18.0.windows.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left
  2019-08-16  7:51   ` Zhang, Shenglei
@ 2019-08-19  0:48     ` Liming Gao
  0 siblings, 0 replies; 4+ messages in thread
From: Liming Gao @ 2019-08-19  0:48 UTC (permalink / raw)
  To: devel@edk2.groups.io, Zhang, Shenglei, Gao, Zhichao
  Cc: Carsey, Jaben, Ni, Ray

Push @5726bdd9a2dfd188a96129e8c00721f34cf3906e

>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Zhang, Shenglei
>Sent: Friday, August 16, 2019 3:51 PM
>To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
>Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>
>Subject: Re: [edk2-devel] [PATCH v2 1/1]
>ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left
>
>Hi All,
>
>This is patch to fix build failure. I'd like the patch to be checked in before this
>stable tag.
>
>Thanks,
>Shenglei
>
>> -----Original Message-----
>> From: Gao, Zhichao
>> Sent: Friday, August 16, 2019 2:19 PM
>> To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io
>> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>
>> Subject: RE: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib:
>> Replace shift logical left
>>
>> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
>>
>> Thanks,
>> Zhichao
>>
>> > -----Original Message-----
>> > From: Zhang, Shenglei
>> > Sent: Friday, August 16, 2019 2:11 PM
>> > To: devel@edk2.groups.io
>> > Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
>> > Gao, Zhichao <zhichao.gao@intel.com>
>> > Subject: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace
>> > shift logical left
>> >
>> > Replace the operation to shift logical left with the function LShiftU64,
>which
>> > has the same functionality.
>> > The original code causes ShellPkg build failure with build target"-b NOOPT".
>> >
>> > Cc: Jaben Carsey <jaben.carsey@intel.com>
>> > Cc: Ray Ni <ray.ni@intel.com>
>> > Cc: Zhichao Gao <zhichao.gao@intel.com>
>> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>> > ---
>> > v2: There is no return target from LShiftU64 in v1 patch.
>> >     So update code to "Val = LShiftU64(Val,32)".
>> >
>> >  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
>> > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
>> > index 94bafa22ef4c..a569c3c55406 100644
>> > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
>> > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
>> > @@ -294,7 +294,7 @@ DumpUint64 (
>> >
>> >    Val = *(UINT32*)(Ptr + sizeof (UINT32));
>> >
>> > -  Val <<= 32;
>> > +  Val = LShiftU64(Val,32);
>> >    Val |= (UINT64)*(UINT32*)Ptr;
>> >
>> >    Print (Format, Val);
>> > --
>> > 2.18.0.windows.1
>
>
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-08-19  0:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-16  6:10 [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left Zhang, Shenglei
2019-08-16  6:19 ` Gao, Zhichao
2019-08-16  7:51   ` Zhang, Shenglei
2019-08-19  0:48     ` [edk2-devel] " Liming Gao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox