public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "afish@apple.com" <afish@apple.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [edk2-devel] BaseTools/BinWrappers question?
Date: Tue, 20 Aug 2019 04:47:41 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D4102@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <2F680F43-0A8D-45D9-9F6E-BDEEFE123FA3@apple.com>

Andrew:

>-----Original Message-----
>From: afish@apple.com [mailto:afish@apple.com]
>Sent: Tuesday, August 20, 2019 2:17 AM
>To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>
>Subject: Re: [edk2-devel] BaseTools/BinWrappers question?
>
>
>
>> On Aug 19, 2019, at 6:09 AM, Liming Gao <liming.gao@intel.com> wrote:
>>
>> Andrew:
>>  This is the history reason. Before, Edk2 BaseTools included the binary
>Windows tools in BaseTools\Bin\Win32. There is no
>BaseTools/BinWrappers/WindowsLike directory.
>>
>>  When migrate BaseTools Windows tools from binary to source build, Edk2
>BaseTools C source is still compiled to BaseTools\Bin\Win32 directory. Because
>BaseTools\Bin\Win32 is set into system PATH env, there is no requirement to
>add their wrapper scripts in BaseTools/BinWrappers/WindowsLike directory.
>>
>
>Liming,
>
>Thanks for the answer, I was guessing it was related to the history difference
>with the tools.
>
>I ran some experiments years ago and calling the C function through the bash
>script seemed to take up 5% of the build time. Would it make sense to use a
>path for Unix builds too vs. the wrappers?
>
Thanks for your comments. I will try this way. If it could improve the build performance, 
it is valuable to make this change. 

>Thanks,
>
>Andrew Fish
>
>> Thanks
>> Liming
>>> -----Original Message-----
>>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Andrew Fish via Groups.Io
>>> Sent: Saturday, August 17, 2019 1:01 AM
>>> To: devel@edk2.groups.io
>>> Subject: [edk2-devel] BaseTools/BinWrappers question?
>>>
>>> Why does BaseTools/BinWrappers/WindowsLike only have wrappers for
>Python commands, while  BaseTools/BinWrappers/PosixLike has
>>> wrappers for C based tools too?
>>>
>>> Thanks,
>>>
>>> Andrew Fish
>>>
>>
>>
>> 
>>


      reply	other threads:[~2019-08-20  4:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-16 17:01 BaseTools/BinWrappers question? Andrew Fish
2019-08-19 13:09 ` [edk2-devel] " Liming Gao
2019-08-19 18:16   ` Andrew Fish
2019-08-20  4:47     ` Liming Gao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4D4102@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox