From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: liming.gao@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Mon, 19 Aug 2019 21:47:44 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Aug 2019 21:47:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,407,1559545200"; d="scan'208";a="207232804" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 19 Aug 2019 21:47:44 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 19 Aug 2019 21:47:43 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 19 Aug 2019 21:47:43 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.15]) with mapi id 14.03.0439.000; Tue, 20 Aug 2019 12:47:41 +0800 From: "Liming Gao" To: "afish@apple.com" , "devel@edk2.groups.io" CC: "Feng, Bob C" Subject: Re: [edk2-devel] BaseTools/BinWrappers question? Thread-Topic: [edk2-devel] BaseTools/BinWrappers question? Thread-Index: AQHVVFRIaStMcxJIwkWzRFRloBplIacCcq3A///THwCAATXDsA== Date: Tue, 20 Aug 2019 04:47:41 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D4102@SHSMSX104.ccr.corp.intel.com> References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D37D8@SHSMSX104.ccr.corp.intel.com> <2F680F43-0A8D-45D9-9F6E-BDEEFE123FA3@apple.com> In-Reply-To: <2F680F43-0A8D-45D9-9F6E-BDEEFE123FA3@apple.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Andrew: >-----Original Message----- >From: afish@apple.com [mailto:afish@apple.com] >Sent: Tuesday, August 20, 2019 2:17 AM >To: devel@edk2.groups.io; Gao, Liming >Subject: Re: [edk2-devel] BaseTools/BinWrappers question? > > > >> On Aug 19, 2019, at 6:09 AM, Liming Gao wrote: >> >> Andrew: >> This is the history reason. Before, Edk2 BaseTools included the binary >Windows tools in BaseTools\Bin\Win32. There is no >BaseTools/BinWrappers/WindowsLike directory. >> >> When migrate BaseTools Windows tools from binary to source build, Edk2 >BaseTools C source is still compiled to BaseTools\Bin\Win32 directory. Be= cause >BaseTools\Bin\Win32 is set into system PATH env, there is no requirement = to >add their wrapper scripts in BaseTools/BinWrappers/WindowsLike directory. >> > >Liming, > >Thanks for the answer, I was guessing it was related to the history diffe= rence >with the tools. > >I ran some experiments years ago and calling the C function through the b= ash >script seemed to take up 5% of the build time. Would it make sense to use= a >path for Unix builds too vs. the wrappers? > Thanks for your comments. I will try this way. If it could improve the bui= ld performance,=20 it is valuable to make this change.=20 >Thanks, > >Andrew Fish > >> Thanks >> Liming >>> -----Original Message----- >>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Andrew Fish via Groups.Io >>> Sent: Saturday, August 17, 2019 1:01 AM >>> To: devel@edk2.groups.io >>> Subject: [edk2-devel] BaseTools/BinWrappers question? >>> >>> Why does BaseTools/BinWrappers/WindowsLike only have wrappers for >Python commands, while BaseTools/BinWrappers/PosixLike has >>> wrappers for C based tools too? >>> >>> Thanks, >>> >>> Andrew Fish >>> >> >> >>=20 >>