From: "Liming Gao" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
"Fan, ZhijuX" <zhijux.fan@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile'
Date: Tue, 20 Aug 2019 06:24:05 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D6C1C@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <08650203BA1BD64D8AD9B6D5D74A85D161525DD1@SHSMSX104.ccr.corp.intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Feng, Bob C
>Sent: Tuesday, August 20, 2019 10:05 AM
>To: Fan, ZhijuX <zhijux.fan@intel.com>; devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: RE: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect
>variable name 'DataPile'
>
>Reviewed-by: Bob Feng <bob.c.feng@intel.com>
>
>-----Original Message-----
>From: Fan, ZhijuX
>Sent: Tuesday, August 20, 2019 8:49 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
>Subject: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable
>name 'DataPile'
>
>BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2093
>
>The PlatformAutoGen object has a DataPipe property but no DataPile
>property So change the variable name 'DataPile' to 'DataPipe' in
>BuildReport.py
>
>This patch is going to fix that issue.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Bob Feng <bob.c.feng@intel.com>
>Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
>---
> BaseTools/Source/Python/build/BuildReport.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/Python/build/BuildReport.py
>b/BaseTools/Source/Python/build/BuildReport.py
>index 9c12c01d2a..6b26f1c3b0 100644
>--- a/BaseTools/Source/Python/build/BuildReport.py
>+++ b/BaseTools/Source/Python/build/BuildReport.py
>@@ -2142,7 +2142,7 @@ class PlatformReport(object):
> INFList = GlobalData.gFdfParser.Profile.InfDict[Pa.Arch]
> for InfName in INFList:
> InfClass = PathClass(NormPath(InfName), Wa.WorkspaceDir,
>Pa.Arch)
>- Ma = ModuleAutoGen(Wa, InfClass, Pa.BuildTarget,
>Pa.ToolChain, Pa.Arch, Wa.MetaFile,Pa.DataPile)
>+ Ma = ModuleAutoGen(Wa, InfClass,
>+ Pa.BuildTarget, Pa.ToolChain, Pa.Arch, Wa.MetaFile, Pa.DataPipe)
> if Ma is None:
> continue
> if Ma not in ModuleAutoGenList:
>--
>2.14.1.windows.1
next prev parent reply other threads:[~2019-08-20 6:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 0:48 [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile' Fan, ZhijuX
2019-08-20 2:04 ` Bob Feng
2019-08-20 6:24 ` Liming Gao [this message]
2019-08-20 6:27 ` Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4D6C1C@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox