* [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile'
@ 2019-08-20 0:48 Fan, ZhijuX
2019-08-20 2:04 ` Bob Feng
0 siblings, 1 reply; 4+ messages in thread
From: Fan, ZhijuX @ 2019-08-20 0:48 UTC (permalink / raw)
To: devel@edk2.groups.io; +Cc: Gao, Liming, Feng, Bob C
[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2093
The PlatformAutoGen object has a DataPipe property but no DataPile property
So change the variable name 'DataPile' to 'DataPipe' in BuildReport.py
This patch is going to fix that issue.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
---
BaseTools/Source/Python/build/BuildReport.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py
index 9c12c01d2a..6b26f1c3b0 100644
--- a/BaseTools/Source/Python/build/BuildReport.py
+++ b/BaseTools/Source/Python/build/BuildReport.py
@@ -2142,7 +2142,7 @@ class PlatformReport(object):
INFList = GlobalData.gFdfParser.Profile.InfDict[Pa.Arch]
for InfName in INFList:
InfClass = PathClass(NormPath(InfName), Wa.WorkspaceDir, Pa.Arch)
- Ma = ModuleAutoGen(Wa, InfClass, Pa.BuildTarget, Pa.ToolChain, Pa.Arch, Wa.MetaFile,Pa.DataPile)
+ Ma = ModuleAutoGen(Wa, InfClass, Pa.BuildTarget, Pa.ToolChain, Pa.Arch, Wa.MetaFile, Pa.DataPipe)
if Ma is None:
continue
if Ma not in ModuleAutoGenList:
--
2.14.1.windows.1
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 3952 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile'
2019-08-20 0:48 [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile' Fan, ZhijuX
@ 2019-08-20 2:04 ` Bob Feng
2019-08-20 6:24 ` Liming Gao
0 siblings, 1 reply; 4+ messages in thread
From: Bob Feng @ 2019-08-20 2:04 UTC (permalink / raw)
To: Fan, ZhijuX, devel@edk2.groups.io; +Cc: Gao, Liming
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: Fan, ZhijuX
Sent: Tuesday, August 20, 2019 8:49 AM
To: devel@edk2.groups.io
Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
Subject: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile'
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2093
The PlatformAutoGen object has a DataPipe property but no DataPile property So change the variable name 'DataPile' to 'DataPipe' in BuildReport.py
This patch is going to fix that issue.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
---
BaseTools/Source/Python/build/BuildReport.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py
index 9c12c01d2a..6b26f1c3b0 100644
--- a/BaseTools/Source/Python/build/BuildReport.py
+++ b/BaseTools/Source/Python/build/BuildReport.py
@@ -2142,7 +2142,7 @@ class PlatformReport(object):
INFList = GlobalData.gFdfParser.Profile.InfDict[Pa.Arch]
for InfName in INFList:
InfClass = PathClass(NormPath(InfName), Wa.WorkspaceDir, Pa.Arch)
- Ma = ModuleAutoGen(Wa, InfClass, Pa.BuildTarget, Pa.ToolChain, Pa.Arch, Wa.MetaFile,Pa.DataPile)
+ Ma = ModuleAutoGen(Wa, InfClass,
+ Pa.BuildTarget, Pa.ToolChain, Pa.Arch, Wa.MetaFile, Pa.DataPipe)
if Ma is None:
continue
if Ma not in ModuleAutoGenList:
--
2.14.1.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile'
2019-08-20 2:04 ` Bob Feng
@ 2019-08-20 6:24 ` Liming Gao
2019-08-20 6:27 ` Bob Feng
0 siblings, 1 reply; 4+ messages in thread
From: Liming Gao @ 2019-08-20 6:24 UTC (permalink / raw)
To: Feng, Bob C, Fan, ZhijuX, devel@edk2.groups.io
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Feng, Bob C
>Sent: Tuesday, August 20, 2019 10:05 AM
>To: Fan, ZhijuX <zhijux.fan@intel.com>; devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: RE: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect
>variable name 'DataPile'
>
>Reviewed-by: Bob Feng <bob.c.feng@intel.com>
>
>-----Original Message-----
>From: Fan, ZhijuX
>Sent: Tuesday, August 20, 2019 8:49 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
>Subject: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable
>name 'DataPile'
>
>BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2093
>
>The PlatformAutoGen object has a DataPipe property but no DataPile
>property So change the variable name 'DataPile' to 'DataPipe' in
>BuildReport.py
>
>This patch is going to fix that issue.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Bob Feng <bob.c.feng@intel.com>
>Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
>---
> BaseTools/Source/Python/build/BuildReport.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/Python/build/BuildReport.py
>b/BaseTools/Source/Python/build/BuildReport.py
>index 9c12c01d2a..6b26f1c3b0 100644
>--- a/BaseTools/Source/Python/build/BuildReport.py
>+++ b/BaseTools/Source/Python/build/BuildReport.py
>@@ -2142,7 +2142,7 @@ class PlatformReport(object):
> INFList = GlobalData.gFdfParser.Profile.InfDict[Pa.Arch]
> for InfName in INFList:
> InfClass = PathClass(NormPath(InfName), Wa.WorkspaceDir,
>Pa.Arch)
>- Ma = ModuleAutoGen(Wa, InfClass, Pa.BuildTarget,
>Pa.ToolChain, Pa.Arch, Wa.MetaFile,Pa.DataPile)
>+ Ma = ModuleAutoGen(Wa, InfClass,
>+ Pa.BuildTarget, Pa.ToolChain, Pa.Arch, Wa.MetaFile, Pa.DataPipe)
> if Ma is None:
> continue
> if Ma not in ModuleAutoGenList:
>--
>2.14.1.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile'
2019-08-20 6:24 ` Liming Gao
@ 2019-08-20 6:27 ` Bob Feng
0 siblings, 0 replies; 4+ messages in thread
From: Bob Feng @ 2019-08-20 6:27 UTC (permalink / raw)
To: Gao, Liming, Fan, ZhijuX, devel@edk2.groups.io
Pushed at 0970a80583a9a0595eb357f380e604b57136fa26
Thanks,
Bob
-----Original Message-----
From: Gao, Liming
Sent: Tuesday, August 20, 2019 2:24 PM
To: Feng, Bob C <bob.c.feng@intel.com>; Fan, ZhijuX <zhijux.fan@intel.com>; devel@edk2.groups.io
Subject: RE: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile'
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Feng, Bob C
>Sent: Tuesday, August 20, 2019 10:05 AM
>To: Fan, ZhijuX <zhijux.fan@intel.com>; devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: RE: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect
>variable name 'DataPile'
>
>Reviewed-by: Bob Feng <bob.c.feng@intel.com>
>
>-----Original Message-----
>From: Fan, ZhijuX
>Sent: Tuesday, August 20, 2019 8:49 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C
><bob.c.feng@intel.com>
>Subject: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect
>variable name 'DataPile'
>
>BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2093
>
>The PlatformAutoGen object has a DataPipe property but no DataPile
>property So change the variable name 'DataPile' to 'DataPipe' in
>BuildReport.py
>
>This patch is going to fix that issue.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Bob Feng <bob.c.feng@intel.com>
>Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
>---
> BaseTools/Source/Python/build/BuildReport.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/Python/build/BuildReport.py
>b/BaseTools/Source/Python/build/BuildReport.py
>index 9c12c01d2a..6b26f1c3b0 100644
>--- a/BaseTools/Source/Python/build/BuildReport.py
>+++ b/BaseTools/Source/Python/build/BuildReport.py
>@@ -2142,7 +2142,7 @@ class PlatformReport(object):
> INFList = GlobalData.gFdfParser.Profile.InfDict[Pa.Arch]
> for InfName in INFList:
> InfClass = PathClass(NormPath(InfName),
>Wa.WorkspaceDir,
>Pa.Arch)
>- Ma = ModuleAutoGen(Wa, InfClass, Pa.BuildTarget,
>Pa.ToolChain, Pa.Arch, Wa.MetaFile,Pa.DataPile)
>+ Ma = ModuleAutoGen(Wa, InfClass,
>+ Pa.BuildTarget, Pa.ToolChain, Pa.Arch, Wa.MetaFile, Pa.DataPipe)
> if Ma is None:
> continue
> if Ma not in ModuleAutoGenList:
>--
>2.14.1.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-20 6:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-20 0:48 [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile' Fan, ZhijuX
2019-08-20 2:04 ` Bob Feng
2019-08-20 6:24 ` Liming Gao
2019-08-20 6:27 ` Bob Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox