From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: liming.gao@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Mon, 26 Aug 2019 18:56:37 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Aug 2019 18:56:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,435,1559545200"; d="scan'208,217";a="379858654" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 26 Aug 2019 18:56:37 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 26 Aug 2019 18:56:37 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 26 Aug 2019 18:56:36 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.215]) with mapi id 14.03.0439.000; Tue, 27 Aug 2019 09:56:36 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Jayanth.Raghuram@dell.com" CC: "Wei.G.Liu@dell.com" Subject: Re: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. Thread-Topic: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. Thread-Index: AdVcR+OPrxJmOcouRhWzA1r7t1m4TQAMoO6A Date: Tue, 27 Aug 2019 01:56:35 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DCA9B@SHSMSX104.ccr.corp.intel.com> References: <31e5cee5c49d4381bfb26a0968c11749@ausx13mps324.AMER.DELL.COM> In-Reply-To: <31e5cee5c49d4381bfb26a0968c11749@ausx13mps324.AMER.DELL.COM> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_4A89E2EF3DFEDB4C8BFDE51014F606A14E4DCA9BSHSMSX104ccrcor_" --_000_4A89E2EF3DFEDB4C8BFDE51014F606A14E4DCA9BSHSMSX104ccrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Can you follow this process to send this patch again? https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-P= rocess And, the commit message format is https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Forma= t Thanks Liming From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Jaya= nth.Raghuram@dell.com Sent: Tuesday, August 27, 2019 3:55 AM To: devel@edk2.groups.io Cc: Wei.G.Liu@dell.com Subject: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve e= rror handling. Subject: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling= . Added checks for return parameters of LocateHandleBuffer & GetSupportedTyp= es function calls in InternalHstiFindAip to improve error handling. An issue = was observed on Dell Poweredge R740, where the Dell PERC H740P controller UEFI driver returned InfoTypesBuffer =3D NULL, InfoTypesBufferCount =3D 0 and c= aused an FreePool assert. Signed-off-by: Jayanth Raghuram > Cc: Wei G Liu > Attached: 0001-MdePkg-DxeHstiLib-Added-checks-to-improve-error-hand.patch Regards Jayanth Raghuram DellEMC | Server Platform BIOS office + 1 512 723 1470 --_000_4A89E2EF3DFEDB4C8BFDE51014F606A14E4DCA9BSHSMSX104ccrcor_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Can you follow this p= rocess to send this patch again?

https://github.com/ti= anocore/tianocore.github.io/wiki/EDK-II-Development-Process

And, the commit messa= ge format is

https://= github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format

Thanks

Liming

From: devel@edk2.groups.io [mailto:devel@edk= 2.groups.io] On Behalf Of Jayanth.Raghuram@dell.com
Sent: Tuesday, August 27, 2019 3:55 AM
To: devel@edk2.groups.io
Cc: Wei.G.Liu@dell.com
Subject: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to im= prove error handling.

Subject: [PATCH] MdePkg/DxeHstiLib: Added checks to= improve error handling.

Added checks for return parameters of LocateHandleB= uffer & GetSupportedTypes

function calls in InternalHstiFindAip to improve er= ror handling. An issue was

observed on Dell Poweredge R740, where the Dell PER= C H740P controller UEFI

driver returned InfoTypesBuffer =3D NULL, InfoTypes= BufferCount =3D 0 and caused

an FreePool assert.

Signed-off-by: Jayanth Raghuram <Jayanth.Raghuram@Dell.com><= /p>

Cc: Wei G Liu <Wei_G_Liu@Dell.com>

Attached: 0001-MdePkg-DxeHstiLib-Added-checks-to-im= prove-error-hand.patch

Regards

Jayanth Raghuram=

DellEMC | Server Platform BIOS

office + 1 512 723 1470

--_000_4A89E2EF3DFEDB4C8BFDE51014F606A14E4DCA9BSHSMSX104ccrcor_--