From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: liming.gao@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Wed, 28 Aug 2019 09:11:04 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2019 09:11:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,441,1559545200"; d="scan'208";a="264693669" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 28 Aug 2019 09:11:02 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 28 Aug 2019 09:11:01 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 28 Aug 2019 09:11:01 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.215]) with mapi id 14.03.0439.000; Thu, 29 Aug 2019 00:10:59 +0800 From: "Liming Gao" To: "Kinney, Michael D" , "Feng, Bob C" , "devel@edk2.groups.io" CC: "Shi, Steven" , "afish@apple.com" , "Laszlo Ersek (lersek@redhat.com)" , "leif.lindholm@linaro.org" Subject: Re: [Patch][edk2-stable201908] BaseTools: fix an incremental build issue. Thread-Topic: [Patch][edk2-stable201908] BaseTools: fix an incremental build issue. Thread-Index: AQHVXX37hYIB3vbmik+IrfWDksSXv6cQrdng//+DXYCAAInecA== Date: Wed, 28 Aug 2019 16:10:59 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DDBDD@SHSMSX104.ccr.corp.intel.com> References: <20190828085209.25316-1-bob.c.feng@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DDB59@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDE5MmZhNjktMWI5Zi00NzIyLWJjOTMtNWRjYjVjNjA5MzQyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQ1hrTktUQkdidlNLdmZ4azlBQ1JMTTBEaVpqVTZpMXYyaGpJdTdUUjNrXC9tNSt6RUI2SFwvbjlGOEZPOURpM0dMIn0= dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Mike: I add notes in BZ. Current problem is that the change in INF file will no= t trig rebuild. For example: 1st build: build -p MdeModulePkg\MdeModulePkg.dsc -a IA32 -m MdeModulePkg\Application\= HelloWorld\HelloWorld.inf 2st build with below change=20 update MdeModulePkg\Application\HelloWorld\HelloWorld.inf and remove MdeModulePkg/MdeModulePkg.dec from [Packages] section 2st build should update Makefile and trig build. But now, there is no build= trig.=20 So, this is the critical incremental build issue. Thanks Liming > -----Original Message----- > From: Kinney, Michael D > Sent: Wednesday, August 28, 2019 11:56 PM > To: Gao, Liming ; Feng, Bob C ; devel@edk2.groups.io; Kinney, Michael D > > Cc: Shi, Steven ; afish@apple.com; Laszlo Ersek (le= rsek@redhat.com) ; > leif.lindholm@linaro.org > Subject: RE: [Patch][edk2-stable201908] BaseTools: fix an incremental bui= ld issue. >=20 > Bob and Liming, >=20 > What is an example test case that fails? Please add to BZ. >=20 > We need this information to test that this fix resolves the > issue. >=20 > Mike >=20 > > -----Original Message----- > > From: Gao, Liming > > Sent: Wednesday, August 28, 2019 8:26 AM > > To: Feng, Bob C ; > > devel@edk2.groups.io > > Cc: Shi, Steven ; Kinney, Michael D > > ; afish@apple.com; Laszlo > > Ersek (lersek@redhat.com) ; > > leif.lindholm@linaro.org > > Subject: RE: [Patch][edk2-stable201908] BaseTools: fix an > > incremental build issue. > > > > Bob: > > This is the critical regression issue for the > > incremental build. I request to catch it in this stable > > tag 201908. > > > > This patch corrects the behavior. Reviewed-by: Liming > > Gao > > > > Thanks > > Liming > > > -----Original Message----- > > > From: Feng, Bob C > > > Sent: Wednesday, August 28, 2019 4:52 PM > > > To: devel@edk2.groups.io > > > Cc: Feng, Bob C ; Gao, Liming > > > ; Shi, Steven > > > > > Subject: [Patch][edk2-stable201908] BaseTools: fix an > > incremental build issue. > > > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2137 > > > > > > This patch is going to fix a regression issue of > > incremental build > > > which was introduced by the commit 94459080c. > > > The changing on INF file will not trigger module > > rebuild. > > > > > > Signed-off-by: Bob Feng > > > Cc: Liming Gao > > > Cc: Steven Shi > > > --- > > > BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 8 > > ++------ > > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > > > diff --git > > a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py > > > b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py > > > index 2cd0d3859e..f610365f6d 100755 > > > --- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py > > > +++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py > > > @@ -1764,16 +1764,12 @@ class ModuleAutoGen(AutoGen): > > > for f in self.AutoGenDepSet: > > > FileSet.add (f.Path) > > > > > > if os.path.exists (self.TimeStampPath): > > > os.remove (self.TimeStampPath) > > > - with tempfile.NamedTemporaryFile('w+', > > dir=3Dos.path.dirname(self.TimeStampPath), delete=3DFalse) as > > tf: > > > - for f in FileSet: > > > - tf.write(f) > > > - tf.write("\n") > > > - tempname =3D tf.name > > > - SaveFileOnChange(self.TimeStampPath, > > tempname, False) > > > + > > > + SaveFileOnChange(self.TimeStampPath, > > "\n".join(FileSet), > > > + False) > > > > > > # Ignore generating makefile when it is a > > binary module > > > if self.IsBinaryModule: > > > return > > > > > > -- > > > 2.20.1.windows.1