Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.

["Liming Gao" <liming.gao@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 6124 bytes --]

Jayanth:
  Thanks for your update commit message. But, edk2 project doesn't use pull request.
You can send https://github.com/JayRaghuram/edk2 and say your patch is in this tree.
  Leif gives the option. You need copy the patch content into the mail, then send this mail to devel@edk2.groups.io<mailto:devel@edk2.groups.io> for code review.

  And, for this patch, I have some comments.

1.      I have not given my reviewed-by. Please don't add it.

2.      LocateHandleBuffer() service. UEFI spec defines that if there are no handles in the handle database

that match the search criteria, then EFI_NOT_FOUND is returned. So, when EFI_SUCCESS return,

don't need to check Handles and NoHandles. This change is not required.

3.      GetSupportedTypes() service. UEFI spec doesn't define EFI_NOT_FOUND. So, when EFI_SUCCESS return,

InfoTypesBuffer may be NULL or InfoTypesBufferCount may be zero. I agree to add this checker.

Thanks
Liming
From: Jayanth.Raghuram@dell.com [mailto:Jayanth.Raghuram@dell.com]
Sent: Thursday, August 29, 2019 9:20 AM
To: Ni, Ray <ray.ni@intel.com>; Gao, Liming <liming.gao@intel.com>; Cetola, Stephano <stephano.cetola@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; leif.lindholm@linaro.org; afish@apple.com; lersek@redhat.com
Cc: Wei.G.Liu@dell.com; devel@edk2.groups.io
Subject: RE: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.

Hi Liming,

Per your request, I have created an pull request as below:
https://github.com/tianocore/edk2/pull/147

MdePkg/DxeHstiLib: Added checks to improve error handling. #147
 Open
JayRaghuram<https://github.com/JayRaghuram> wants to merge 1 commit into tianocore:master<https://github.com/tianocore/edk2> from JayRaghuram:master<https://github.com/JayRaghuram/edk2>

Regards
Jayanth Raghuram
DellEMC | Server Platform BIOS
office + 1 512 723 1470

From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Sent: Wednesday, August 28, 2019 12:33 PM
To: Gao, Liming; Cetola, Stephano; Kinney, Michael D; leif.lindholm@linaro.org<mailto:leif.lindholm@linaro.org>; Raghuram, Jayanth; 'Andrew Fish (afish@apple.com<mailto:afish@apple.com>)'; Laszlo Ersek
Cc: Liu, Wei G; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: RE: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.


[EXTERNAL EMAIL]
Liming, Stephano and all stewards,
My understanding is the requirement of embedding patch into the mail body is due to a limitation in old system (01.org). That system couldn't support mail attachments.

With the existence of mail attachments capability in new groups.io system, can we accept such kind of patch submission? Or any side effect you see if allowing mail attachments?

Thanks,
Ray

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Liming Gao
Sent: Wednesday, August 28, 2019 12:59 AM
To: Jayanth.Raghuram@dell.com<mailto:Jayanth.Raghuram@dell.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Wei.G.Liu@dell.com<mailto:Wei.G.Liu@dell.com>
Subject: Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.

OK. So, you can't use git send-email to send this patch. Another way is to fork edk2 and create the branch to include this change.
Then, send the mail to let people review this patch in your branch.

And, for this patch, can you submit BZ https://bugzilla.tianocore.org/ first?
Then, update its commit message format based on this wiki.
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format

Thanks
Liming
From: Jayanth.Raghuram@dell.com<mailto:Jayanth.Raghuram@dell.com> [mailto:Jayanth.Raghuram@dell.com]
Sent: Wednesday, August 28, 2019 2:30 AM
To: Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Wei.G.Liu@dell.com<mailto:Wei.G.Liu@dell.com>
Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.

Hi Liming,

I sent the review request based on the description in the links that you mentioned below.
I sent it in an Dell Email since I cannot use GIT SMTP to send email out from our servers.
Please let me know what is wrong and I can help rectify that.

Regards
Jayanth Raghuram
DellEMC | Server Platform BIOS
office + 1 512 723 1470

From: Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>
Sent: Monday, August 26, 2019 8:57 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Raghuram, Jayanth
Cc: Liu, Wei G
Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.


[EXTERNAL EMAIL]
Can you follow this process to send this patch again?
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

And, the commit message format is
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format

Thanks
Liming
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> [mailto:devel@edk2.groups.io] On Behalf Of Jayanth.Raghuram@dell.com<mailto:Jayanth.Raghuram@dell.com>
Sent: Tuesday, August 27, 2019 3:55 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Wei.G.Liu@dell.com<mailto:Wei.G.Liu@dell.com>
Subject: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.

Subject: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.
Added checks for return parameters of LocateHandleBuffer & GetSupportedTypes
function calls in InternalHstiFindAip to improve error handling. An issue was
observed on Dell Poweredge R740, where the Dell PERC H740P controller UEFI
driver returned InfoTypesBuffer = NULL, InfoTypesBufferCount = 0 and caused
an FreePool assert.

Signed-off-by: Jayanth Raghuram <Jayanth.Raghuram@Dell.com<mailto:Jayanth.Raghuram@Dell.com>>
Cc: Wei G Liu <Wei_G_Liu@Dell.com<mailto:Wei_G_Liu@Dell.com>>

Attached: 0001-MdePkg-DxeHstiLib-Added-checks-to-improve-error-hand.patch

Regards
Jayanth Raghuram
DellEMC | Server Platform BIOS
office + 1 512 723 1470



[-- Attachment #2: Type: text/html, Size: 28173 bytes --]