From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: liming.gao@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Thu, 29 Aug 2019 07:28:32 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2019 07:28:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,443,1559545200"; d="scan'208,217";a="188558981" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 29 Aug 2019 07:28:27 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 29 Aug 2019 07:28:11 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 29 Aug 2019 07:28:11 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.65]) with mapi id 14.03.0439.000; Thu, 29 Aug 2019 22:28:09 +0800 From: "Liming Gao" To: "Jayanth.Raghuram@dell.com" , "Ni, Ray" , "Cetola, Stephano" , "Kinney, Michael D" , "leif.lindholm@linaro.org" , "afish@apple.com" , "lersek@redhat.com" CC: "Wei.G.Liu@dell.com" , "devel@edk2.groups.io" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. Thread-Topic: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. Thread-Index: AdVcR+OPrxJmOcouRhWzA1r7t1m4TQAMoO6AACKbwDAAHEv/sAAT9+pwABBi6MAAGzdIEA== Date: Thu, 29 Aug 2019 14:28:08 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DE421@SHSMSX104.ccr.corp.intel.com> References: <31e5cee5c49d4381bfb26a0968c11749@ausx13mps324.AMER.DELL.COM> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DCA9B@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DD7DA@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C2A1B73@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmI4MjNjNDAtOTI5OC00YmNlLWIxOGYtNDIyNDU3M2I1NzQyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC9reUJBOFJoeEg5NzZVbXR0Qk9haHQ1VkY4SVYrNTNJV0IrcmdDMUVvcXAyQkIrU2lcL0gzM2FXTWY2eVRDSHVDIn0= dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_4A89E2EF3DFEDB4C8BFDE51014F606A14E4DE421SHSMSX104ccrcor_" --_000_4A89E2EF3DFEDB4C8BFDE51014F606A14E4DE421SHSMSX104ccrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jayanth: Thanks for your update commit message. But, edk2 project doesn't use pul= l request. You can send https://github.com/JayRaghuram/edk2 and say your patch is in = this tree. Leif gives the option. You need copy the patch content into the mail, th= en send this mail to devel@edk2.groups.io for = code review. And, for this patch, I have some comments. 1. I have not given my reviewed-by. Please don't add it. 2. LocateHandleBuffer() service. UEFI spec defines that if there are = no handles in the handle database that match the search criteria, then EFI_NOT_FOUND is returned. So, when E= FI_SUCCESS return, don't need to check Handles and NoHandles. This change is not required. 3. GetSupportedTypes() service. UEFI spec doesn't define EFI_NOT_FOUN= D. So, when EFI_SUCCESS return, InfoTypesBuffer may be NULL or InfoTypesBufferCount may be zero. I agree t= o add this checker. Thanks Liming From: Jayanth.Raghuram@dell.com [mailto:Jayanth.Raghuram@dell.com] Sent: Thursday, August 29, 2019 9:20 AM To: Ni, Ray ; Gao, Liming ; Cetola= , Stephano ; Kinney, Michael D ; leif.lindholm@linaro.org; afish@apple.com; lersek@redhat.com Cc: Wei.G.Liu@dell.com; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to impro= ve error handling. Hi Liming, Per your request, I have created an pull request as below: https://github.com/tianocore/edk2/pull/147 MdePkg/DxeHstiLib: Added checks to improve error handling. #147 Open JayRaghuram wants to merge 1 commit into t= ianocore:master from JayRaghuram:master<= https://github.com/JayRaghuram/edk2> Regards Jayanth Raghuram DellEMC | Server Platform BIOS office + 1 512 723 1470 From: Ni, Ray > Sent: Wednesday, August 28, 2019 12:33 PM To: Gao, Liming; Cetola, Stephano; Kinney, Michael D; leif.lindholm@linaro= .org; Raghuram, Jayanth; 'Andrew Fish (afi= sh@apple.com)'; Laszlo Ersek Cc: Liu, Wei G; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to impro= ve error handling. [EXTERNAL EMAIL] Liming, Stephano and all stewards, My understanding is the requirement of embedding patch into the mail body = is due to a limitation in old system (01.org). That system couldn't support= mail attachments. With the existence of mail attachments capability in new groups.io system,= can we accept such kind of patch submission? Or any side effect you see if= allowing mail attachments? Thanks, Ray From: devel@edk2.groups.io > On Behalf Of Liming Gao Sent: Wednesday, August 28, 2019 12:59 AM To: Jayanth.Raghuram@dell.com; devel@edk= 2.groups.io Cc: Wei.G.Liu@dell.com Subject: Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to impro= ve error handling. OK. So, you can't use git send-email to send this patch. Another way is to= fork edk2 and create the branch to include this change. Then, send the mail to let people review this patch in your branch. And, for this patch, can you submit BZ https://bugzilla.tianocore.org/ fir= st? Then, update its commit message format based on this wiki. https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Forma= t Thanks Liming From: Jayanth.Raghuram@dell.com [mailto:= Jayanth.Raghuram@dell.com] Sent: Wednesday, August 28, 2019 2:30 AM To: Gao, Liming >; devel= @edk2.groups.io Cc: Wei.G.Liu@dell.com Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error hand= ling. Hi Liming, I sent the review request based on the description in the links that you m= entioned below. I sent it in an Dell Email since I cannot use GIT SMTP to send email out f= rom our servers. Please let me know what is wrong and I can help rectify that. Regards Jayanth Raghuram DellEMC | Server Platform BIOS office + 1 512 723 1470 From: Gao, Liming > Sent: Monday, August 26, 2019 8:57 PM To: devel@edk2.groups.io; Raghuram, Jayanth Cc: Liu, Wei G Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error hand= ling. [EXTERNAL EMAIL] Can you follow this process to send this patch again? https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-P= rocess And, the commit message format is https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Forma= t Thanks Liming From: devel@edk2.groups.io [mailto:devel@edk2= .groups.io] On Behalf Of Jayanth.Raghuram@dell.com Sent: Tuesday, August 27, 2019 3:55 AM To: devel@edk2.groups.io Cc: Wei.G.Liu@dell.com Subject: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve e= rror handling. Subject: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling= . Added checks for return parameters of LocateHandleBuffer & GetSupportedTyp= es function calls in InternalHstiFindAip to improve error handling. An issue = was observed on Dell Poweredge R740, where the Dell PERC H740P controller UEFI driver returned InfoTypesBuffer =3D NULL, InfoTypesBufferCount =3D 0 and c= aused an FreePool assert. Signed-off-by: Jayanth Raghuram > Cc: Wei G Liu > Attached: 0001-MdePkg-DxeHstiLib-Added-checks-to-improve-error-hand.patch Regards Jayanth Raghuram DellEMC | Server Platform BIOS office + 1 512 723 1470 --_000_4A89E2EF3DFEDB4C8BFDE51014F606A14E4DE421SHSMSX104ccrcor_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Jayanth:

  Thanks for your update commit message. But, edk2 project = doesn’t use pull request.

You can send https://github.com/JayRaghuram/edk2 and s= ay your patch is in this tree.

  Leif gives the option. You need copy the patch conte= nt into the mail, then send this mail to devel@edk2.groups.io for code = review.

 

  And, for this patch, I have some comments.

1.      I have not given my reviewed-by. Please don’t add = it.

2.      LocateHandleBuffer() service. UEFI spec defines that if = there are no handles in the handle database

that match t= he search criteria, then EFI_NOT_FOUND is returned. So, when EFI_SUCCESS return, =

don’t = need to check Handles and NoHandles. This change is not required.

3.      GetSupportedTypes() service. UEFI spec doesn’t def= ine EFI_NOT_FOUND. So, when EFI_SUCCESS return,

InfoTypesBuf= fer may be NULL or InfoTypesBufferCount may be zero. I agree to add this ch= ecker.

 

Thanks

Liming

From: Jayanth.Raghuram@dell.com= [mailto:Jayanth.Raghuram@dell.com]
Sent: Thursday, August 29, 2019 9:20 AM
To: Ni, Ray <ray.ni@intel.com>; Gao, Liming <liming.gao@in= tel.com>; Cetola, Stephano <stephano.cetola@intel.com>; Kinney, Mi= chael D <michael.d.kinney@intel.com>; leif.lindholm@linaro.org; afish= @apple.com; lersek@redhat.com
Cc: Wei.G.Liu@dell.com; devel@edk2.groups.io
Subject: RE: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks t= o improve error handling.

 

Hi Liming,

 

Per your request, I have creat= ed an pull request as below:

https://github.com/tianocore/edk2/pull/147

 

MdePkg/Dxe= HstiLib: Added checks to improve error handling. #147

 Open=

JayRaghuram wants to merge 1 commit into tianocore:master from JayRaghuram:master

 

Regard= s

Jayant= h Raghuram

DellEMC | Server Platform BIOS

office<= /b> + 1 512 723 1470

 

From: Ni, Ray <ray.ni@intel.c= om>
Sent: Wednesday, August 28, 2019 12:33 PM
To: Gao, Liming; Cetola, Stephano; Kinney, Michael D; leif.lindholm@linaro.org; Raghuram, Jayanth; 'Andrew Fish (afish@apple.com)'; Laszlo Ersek
Cc: Liu, Wei G; devel@edk2.= groups.io
Subject: RE: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks t= o improve error handling.

 

[EXTERNAL EMAIL]

Liming, Stephano and all stewa= rds,

My understanding is the requir= ement of embedding patch into the mail body is due to a limitation in old s= ystem (01.org). That system couldn’t support mail attachments.

 

With the existence of mail att= achments capability in new groups.io system, can we accept such kind of pat= ch submission? Or any side effect you see if allowing mail attachments?

 

Thanks,

Ray

 

From: devel@edk2.groups.io <devel= @edk2.groups.io> On Behalf Of Liming Gao
Sent: Wednesday, August 28, 2019 12:59 AM
To: Jayanth.Raghuram@d= ell.com; devel@edk2.groups.io
Cc: Wei.G.Liu@dell.com Subject: Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks t= o improve error handling.

 

OK. So= , you can’t use git send-email to send this patch. Another way is to = fork edk2 and create the branch to include this change.

Then, = send the mail to let people review this patch in your branch.

&= nbsp;

And, f= or this patch, can you submit BZ ht= tps://bugzilla.tianocore.org/ first?=

Then, = update its commit message format based on this wiki.

https://github.co= m/tianocore/tianocore.github.io/wiki/Commit-Message-Format

&= nbsp;

Thanks=

Liming=

From: Jayanth.Raghuram@dell.com [mailto:Jayanth.Raghuram@dell.com]
Sent: Wednesday, August 28, 2019 2:30 AM
To: Gao, Liming <liming.= gao@intel.com>; devel@edk2.groups.io
Cc: Wei.G.Liu@dell.com Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve err= or handling.

 

Hi Liming,

 

I sent the review request base= d on the description in the links that you mentioned below.

I sent it in an Dell Email sin= ce I cannot use GIT SMTP to send email out from our servers.

Please let me know what is wro= ng and I can help rectify that.

 

Regard= s

Jayant= h Raghuram

DellEMC | Server Platform BIOS

office<= /b> + 1 512 723 1470

 

 

[EXTERNAL EMAIL]

Can yo= u follow this process to send this patch again?

https://gith= ub.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

&= nbsp;

And, t= he commit message format is

https://github.co= m/tianocore/tianocore.github.io/wiki/Commit-Message-Format

&= nbsp;

Thanks=

Liming=

From: devel@edk2.groups.io [mailto:d= evel@edk2.groups.io] On Behalf Of Jayanth.R= aghuram@dell.com
Sent: Tuesday, August 27, 2019 3:55 AM
To: devel@edk2.groups.io
Cc: Wei.G.Liu@dell.com Subject: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to im= prove error handling.

 

Subject: [PATCH] MdePkg/DxeHst= iLib: Added checks to improve error handling.

Added checks for return parame= ters of LocateHandleBuffer & GetSupportedTypes

function calls in InternalHsti= FindAip to improve error handling. An issue was

observed on Dell Poweredge R74= 0, where the Dell PERC H740P controller UEFI

driver returned InfoTypesBuffe= r =3D NULL, InfoTypesBufferCount =3D 0 and caused

an FreePool assert.=

 

Signed-off-by: Jayanth Raghura= m <Jayanth.Raghuram@Dell.co= m>

Cc: Wei G Liu <Wei_G_Liu@Dell.com>

 

Attached: 0001-MdePkg-DxeHstiL= ib-Added-checks-to-improve-error-hand.patch

 

Regard= s

Jayant= h Raghuram

DellEMC | Server Platform BIOS

office<= /b> + 1 512 723 1470

 

--_000_4A89E2EF3DFEDB4C8BFDE51014F606A14E4DE421SHSMSX104ccrcor_--