From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: liming.gao@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Fri, 30 Aug 2019 01:44:00 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Aug 2019 01:43:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,446,1559545200"; d="scan'208";a="175547909" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga008.jf.intel.com with ESMTP; 30 Aug 2019 01:43:58 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 30 Aug 2019 01:43:58 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 30 Aug 2019 01:43:58 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.163]) with mapi id 14.03.0439.000; Fri, 30 Aug 2019 16:43:56 +0800 From: "Liming Gao" To: "rfc@edk2.groups.io" , "Kinney, Michael D" , "devel@edk2.groups.io" Subject: Re: [RFC] EDK II Continuous Integration Phase 1 Thread-Topic: [RFC] EDK II Continuous Integration Phase 1 Thread-Index: AdVeooLjZu0dT/k9SsO41W96IKrh5AAV2rdg Date: Fri, 30 Aug 2019 08:43:55 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4E1317@SHSMSX104.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mike: I add my comments.=20 >-----Original Message----- >From: rfc@edk2.groups.io [mailto:rfc@edk2.groups.io] On Behalf Of Michael >D Kinney >Sent: Friday, August 30, 2019 4:23 AM >To: devel@edk2.groups.io; rfc@edk2.groups.io >Subject: [edk2-rfc] [RFC] EDK II Continuous Integration Phase 1 > >Hello, > >This is a proposal for a first step towards continuous >integration for all TianoCore repositories to help >improve to quality of commits and automate testing and >release processes for all EDK II packages and platforms. > >This is based on work from a number of EDK II community >members that have provide valuable input and evaluations. > >* Rebecca Cran Jenkins evaluation >* Laszlo Ersek GitLab evaluation >* Philippe Mathieu-Daud=E9 GitLab evaluation >* Sean Brogan Azure Pipelines and HBFA >* Bret Barkelew Azure Pipelines and HBFA >* Jiewen Yao HBFA > >The following link is a link to an EDK II WIKI page that >contains a summary of the work to date. Please provide >feedback in the EDK II mailing lists. The WIKI pages will >be updated with input from the entire EDK II community. > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Continuo= us- >Integration > >Proposal >=3D=3D=3D=3D=3D=3D=3D=3D >Phase 1 of adding continuous integration is limited to the >edk2 repository. Additional repositories will be added later. > >The following changes are proposed: >* Remove EDK II Maintainers write access to edk2 repository. > Only EDK II Administrators will continue to have write > access, and that should only be used to handle extraordinary > events. >* EDK II Maintainers use a GitHub Pull Request instead of push > to commit a patch series to the edk2 repository. There are > no other changes to the development and review process. The > patch series is prepared in an EDK II maintainer branch with > all commit message requirements met on each patch in the series. Will the maintainer manually provide pull request after the patch passes t= he review? Can the script scan the mail list and auto trig pull request once the patc= h gets=20 Reviewed-by or Acked-by from Package maintainers? >* The edk2 repository only accepts Pull Requests from members > of the EDK II Maintainers team. Pull Requests from anyone else > are rejected. >* Run pre-commit checks using Azure Pipelines The maintainer manually trig pre-commit check or auto trig pre-commit? By default, pre-commit should be auto trigged based on pull request.=20 >* If all pre-commit checks pass, then the patch series is auto > committed. The result of this commit must match the contents > and commit history that would have occurred using the previous > push operation. >* If any pre-commit checks fail, then notify the submitter. Will Pre-commit check fail send the mail to the patch submitter? The patch submitter need update the patch and go through review process ag= ain.=20 > A typical reason for a failure would be a merge conflict with > another pull request that was just processed. >* Limit pre-commit checks execution time to 10 minutes. >* Provide on-demand builds to EDK II Maintainers that to allow > EDK II Maintainers to submit a branch through for the same > set of pre-commit checks without submitting a pull request. > >## Pre-Commit Checks in Phase 1 >* Run and pass PatchCheck.py with no errors > >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >The following are some additional pre-commit check ideas >that could be quickly added once the initial version using >PatchCheck.py is fully functional. Please provide feedback >on the ones you like and additional ones you think may >improve the quality of the commits to the edk2 repository. > >## Proposed Pre-Commit Checks in Phase 2 >* Verify Reviewed-by and Acked-by tags are present with > correct maintainer email addresses >* Verify no non-ASCII characters in modified files >* Verify no binary files in set of modified files Now, Edk2 has few binary files, like logo.bmp.=20 I see one BZ to request logo bmp update.=20 (BZ https://bugzilla.tianocore.org/show_bug.cgi?id=3D2050) So, we need the exception way for it.=20 >* Verify package dependency rules in modified files > >## Proposed Pre-Commit Checks in Phase 3 >* Run ECC on modified files >* Verify modified modules/libs build >* Run available host based tests (HBFA) against modified > modules/libs > I request boot test on Emulator and Ovmf in the daily and weekly scope.=20 Daily can cover boot to Shell. Weekly can cover more boot functionality.=20 Thanks Liming >Best regards, > >Mike > > > > > > >