From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: liming.gao@intel.com)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by groups.io with SMTP; Tue, 03 Sep 2019 00:14:34 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
  by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Sep 2019 00:14:34 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,462,1559545200"; 
   d="scan'208";a="189728113"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
  by FMSMGA003.fm.intel.com with ESMTP; 03 Sep 2019 00:14:34 -0700
Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Tue, 3 Sep 2019 00:14:34 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by
 SHSMSX108.ccr.corp.intel.com ([169.254.8.146]) with mapi id 14.03.0439.000;
 Tue, 3 Sep 2019 15:14:31 +0800
From: "Liming Gao" <liming.gao@intel.com>
To: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>, "xypron.glpk@gmx.de"
	<xypron.glpk@gmx.de>, "Carsey, Jaben" <jaben.carsey@intel.com>, "Gao,
 Zhichao" <zhichao.gao@intel.com>
CC: "Ni, Ray" <ray.ni@intel.com>, Leif Lindholm <leif.lindholm@linaro.org>,
	Stephano Cetola <stephano.cetola@linux.intel.com>, "Gao, Liming"
	<liming.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/CommandLib: avoid NULL derefence and memory leak
Thread-Topic: [edk2-devel] [PATCH v3 1/1] ShellPkg/CommandLib: avoid NULL
 derefence and memory leak
Thread-Index: AQHVYXdDl1BwK1XNtEaOFGFxCyn14KcY39KAgACrceA=
Date: Tue, 3 Sep 2019 07:14:30 +0000
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4F1C63@SHSMSX104.ccr.corp.intel.com>
References: <20190510032419.14540-1-xypron.glpk@gmx.de>
 <CB6E33457884FA40993F35157061515CBCC2D910@FMSMSX103.amr.corp.intel.com>
 <d0a8c975-7b58-186d-4bf4-bc481f7aa452@gmx.de>
 <02A34F284D1DA44BB705E61F7180EF0AAEE88D63@ORSMSX114.amr.corp.intel.com>
In-Reply-To: <02A34F284D1DA44BB705E61F7180EF0AAEE88D63@ORSMSX114.amr.corp.intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: liming.gao@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64

VGhpcyBwYXRjaCBoYXMgcGFzc2VkIHRoZSBwYWNrYWdlIG1haW50YWluZXIgcmV2aWV3LiBTbywg
SSBwdXNoIHRoaXMgY2hhbmdlIEA4YjhlOTE1ODQ1NTViNjE5M2YyMDk5YTM2NTAyNzYzYjQ3NTAx
NTMzLg0KDQpUaGFua3MNCkxpbWluZw0KPi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+RnJv
bTogRGVzaW1vbmUsIE5hdGhhbmllbCBMDQo+U2VudDogVHVlc2RheSwgU2VwdGVtYmVyIDAzLCAy
MDE5IDE6MDAgUE0NCj5UbzogZGV2ZWxAZWRrMi5ncm91cHMuaW87IHh5cHJvbi5nbHBrQGdteC5k
ZTsgQ2Fyc2V5LCBKYWJlbg0KPjxqYWJlbi5jYXJzZXlAaW50ZWwuY29tPjsgR2FvLCBaaGljaGFv
IDx6aGljaGFvLmdhb0BpbnRlbC5jb20+DQo+Q2M6IE5pLCBSYXkgPHJheS5uaUBpbnRlbC5jb20+
OyBMZWlmIExpbmRob2xtIDxsZWlmLmxpbmRob2xtQGxpbmFyby5vcmc+OyBHYW8sDQo+TGltaW5n
IDxsaW1pbmcuZ2FvQGludGVsLmNvbT47IFN0ZXBoYW5vIENldG9sYQ0KPjxzdGVwaGFuby5jZXRv
bGFAbGludXguaW50ZWwuY29tPg0KPlN1YmplY3Q6IFJFOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYz
IDEvMV0gU2hlbGxQa2cvQ29tbWFuZExpYjogYXZvaWQgTlVMTA0KPmRlcmVmZW5jZSBhbmQgbWVt
b3J5IGxlYWsNCj4NCj5Gcm9tIGh0dHBzOi8vZ2l0aHViLmNvbS90aWFub2NvcmUvZWRrMi9ibG9i
L21hc3Rlci9NYWludGFpbmVycy50eHQ6DQo+DQo+TTogSmFiZW4gQ2Fyc2V5IDxqYWJlbi5jYXJz
ZXlAaW50ZWwuY29tPg0KPk06IFJheSBOaSA8cmF5Lm5pQGludGVsLmNvbT4NCj4NCj4tLS0tLU9y
aWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPkZyb206IGRldmVsQGVkazIuZ3JvdXBzLmlvIDxkZXZlbEBl
ZGsyLmdyb3Vwcy5pbz4gT24gQmVoYWxmIE9mIEhlaW5yaWNoDQo+U2NodWNoYXJkdA0KPlNlbnQ6
IE1vbmRheSwgU2VwdGVtYmVyIDIsIDIwMTkgMzoxNSBBTQ0KPlRvOiBDYXJzZXksIEphYmVuIDxq
YWJlbi5jYXJzZXlAaW50ZWwuY29tPjsgZGV2ZWxAZWRrMi5ncm91cHMuaW87IEdhbywNCj5aaGlj
aGFvIDx6aGljaGFvLmdhb0BpbnRlbC5jb20+DQo+Q2M6IE5pLCBSYXkgPHJheS5uaUBpbnRlbC5j
b20+OyBMZWlmIExpbmRob2xtIDxsZWlmLmxpbmRob2xtQGxpbmFyby5vcmc+OyBHYW8sDQo+TGlt
aW5nIDxsaW1pbmcuZ2FvQGludGVsLmNvbT47IFN0ZXBoYW5vIENldG9sYQ0KPjxzdGVwaGFuby5j
ZXRvbGFAbGludXguaW50ZWwuY29tPg0KPlN1YmplY3Q6IFJlOiBbZWRrMi1kZXZlbF0gW1BBVENI
IHYzIDEvMV0gU2hlbGxQa2cvQ29tbWFuZExpYjogYXZvaWQgTlVMTA0KPmRlcmVmZW5jZSBhbmQg
bWVtb3J5IGxlYWsNCj4NCj5PbiA1LzEwLzE5IDQ6MzIgUE0sIENhcnNleSwgSmFiZW4gd3JvdGU6
DQo+PiBSZXZpZXdlZC1ieTogSmFiZW4gQ2Fyc2V5IDxqYWJlbi5jYXJzZXlAaW50ZWwuY29tPg0K
Pj4NCj4+IENvZGUgY2hhbmdlIGxvb2tzIGdvb2QgdmlzdWFsbHkuDQo+DQo+U29tZWhvdyB0aGlz
IHBhdGNoDQo+DQo+aHR0cHM6Ly9lZGsyLmdyb3Vwcy5pby9nL2RldmVsL21lc3NhZ2UvNDAzOTUN
Cj4NCj53YXMgbmV2ZXIgbWVyZ2VkLg0KPg0KPldobyBpcyB0aGUgbWFpbnRhaW5lciBmb3IgdGhl
IFNoZWxsUGtnPw0KPg0KPkJlc3QgcmVnYXJkcw0KPg0KPkhlaW5yaWNoDQo+DQo+DQoNCg==