From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: liming.gao@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Wed, 04 Sep 2019 00:59:03 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2019 00:59:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,465,1559545200"; d="scan'208";a="173495883" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga007.jf.intel.com with ESMTP; 04 Sep 2019 00:59:01 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 4 Sep 2019 00:58:53 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 4 Sep 2019 00:58:53 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.146]) with mapi id 14.03.0439.000; Wed, 4 Sep 2019 15:58:51 +0800 From: "Liming Gao" To: "Ni, Ray" , "Gao, Zhichao" , "devel@edk2.groups.io" CC: Oleksiy Subject: Re: [PATCH v3 1/1] ShellPkg/Pci.c: Update supported link speed to PCI5.0 Thread-Topic: [PATCH v3 1/1] ShellPkg/Pci.c: Update supported link speed to PCI5.0 Thread-Index: AQHVYNgFNrU4YjyqAk2e76dmrxoRn6caZW2AgADF/bA= Date: Wed, 4 Sep 2019 07:58:50 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4F2642@SHSMSX104.ccr.corp.intel.com> References: <20190901151443.11568-1-zhichao.gao@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C2BFDC0@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C2BFDC0@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable push@adb59b633c12eae334540295092da94736bffa33 >-----Original Message----- >From: Ni, Ray >Sent: Wednesday, September 04, 2019 12:10 PM >To: Gao, Zhichao ; devel@edk2.groups.io >Cc: Oleksiy ; Gao, Liming >Subject: RE: [PATCH v3 1/1] ShellPkg/Pci.c: Update supported link speed to >PCI5.0 > >Reviewed-by: Ray Ni > >> -----Original Message----- >> From: Gao, Zhichao >> Sent: Sunday, September 1, 2019 8:15 AM >> To: devel@edk2.groups.io >> Cc: Gao, Zhichao ; Ni, Ray ; >Oleksiy ; Gao, Liming >> >> Subject: [PATCH v3 1/1] ShellPkg/Pci.c: Update supported link speed to >PCI5.0 >> >> From: "Gao, Zhichao" >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1955 >> >> Refer to PCI express base specification Reversion 5.0, Version >> 1.0, Table 7-33, Supported Link Speeds Vector bit 3 indicate >> the speed 16 GT/s and bit 4 indicate the speed 32 GT/s. >> Add the support to shell command 'pci ...'. >> >> Change the MaxLinkSpeed other values' result from 'Unknown' >> to 'Reserved' to make the result align. >> >> Cc: Ray Ni >> Cc: Oleksiy >> Cc: Liming Gao >> Signed-off-by: Zhichao Gao >> --- >> V2: >> Update the copyright. >> >> V3: >> Update the link speed to support PCI 5.0. >> >> Update the support >> .../Library/UefiShellDebug1CommandsLib/Pci.c | 16 ++++++++++++++-- >> 1 file changed, 14 insertions(+), 2 deletions(-) >> >> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c >b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c >> index ba9caa774398..3e138188cec3 100644 >> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c >> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c >> @@ -1,7 +1,7 @@ >> /** @file >> Main file for Pci shell Debug1 function. >> >> - Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved. >> + Copyright (c) 2005 - 2019, Intel Corporation. All rights reserved. >> (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
>> (C) Copyright 2016 Hewlett Packard Enterprise Development LP
>> SPDX-License-Identifier: BSD-2-Clause-Patent >> @@ -4515,8 +4515,14 @@ ExplainPcieLinkCap ( >> case 3: >> MaxLinkSpeed =3D L"8.0 GT/s"; >> break; >> + case 4: >> + MaxLinkSpeed =3D L"16.0 GT/s"; >> + break; >> + case 5: >> + MaxLinkSpeed =3D L"32.0 GT/s"; >> + break; >> default: >> - MaxLinkSpeed =3D L"Unknown"; >> + MaxLinkSpeed =3D L"Reserved"; >> break; >> } >> ShellPrintEx (-1, -1, >> @@ -4672,6 +4678,12 @@ ExplainPcieLinkStatus ( >> case 3: >> CurLinkSpeed =3D L"8.0 GT/s"; >> break; >> + case 4: >> + CurLinkSpeed =3D L"16.0 GT/s"; >> + break; >> + case 5: >> + CurLinkSpeed =3D L"32.0 GT/s"; >> + break; >> default: >> CurLinkSpeed =3D L"Reserved"; >> break; >> -- >> 2.21.0.windows.1