From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Chen, Marc W" <marc.w.chen@intel.com>
Cc: "Kubacki, Michael A" <michael.a.kubacki@intel.com>,
"Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH] AdvancedFeaturePkg/S3Advanced Add S3 Advanced PEIM driver
Date: Thu, 5 Sep 2019 13:08:15 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4F3325@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190905085141.2672-1-marc.w.chen@intel.com>
Marc:
Please remove Change-Id: Ie5841047be350f411650ad30f16d210b98197dc4 in the commit message for the updated one.
Thanks
Liming
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Marc W Chen
> Sent: Thursday, September 5, 2019 4:52 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Chen, Marc W <marc.w.chen@intel.com>
> Subject: [edk2-devel] [edk2-platforms][PATCH] AdvancedFeaturePkg/S3Advanced Add S3 Advanced PEIM driver
>
> Implement a S3 Advanced PEIM driver for supporting S3 feature.
> So far this driver only install EFI_PEI_MM_ACCESS_PPI for S3 resume case.
>
> Change-Id: Ie5841047be350f411650ad30f16d210b98197dc4
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Marc Chen <marc.w.chen@intel.com>
> ---
> .../S3Advanced/S3AdvancedPei/S3AdvancedPei.c | 36 ++++++++++++++++++++++
> .../S3Advanced/S3AdvancedPei/S3AdvancedPei.inf | 31 +++++++++++++++++++
> 2 files changed, 67 insertions(+)
> create mode 100644 Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3AdvancedPei.c
> create mode 100644 Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3AdvancedPei.inf
>
> diff --git a/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3AdvancedPei.c
> b/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3AdvancedPei.c
> new file mode 100644
> index 00000000..9ce4cc6a
> --- /dev/null
> +++ b/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3AdvancedPei.c
> @@ -0,0 +1,36 @@
> +/** @file
> + Source code file for S3 Advanced PEI module
> +
> +Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#include <Library/PeiServicesLib.h>
> +#include <Library/SmmAccessLib.h>
> +
> +/**
> + S3 Advanced PEI module entry point
> +
> + @param[in] FileHandle Not used.
> + @param[in] PeiServices General purpose services available to every PEIM.
> +
> + @retval EFI_SUCCESS The function completes successfully
> + @retval EFI_OUT_OF_RESOURCES Insufficient resources to create database
> +**/
> +EFI_STATUS
> +EFIAPI
> +S3AdvancedEntryPoint (
> + IN EFI_PEI_FILE_HANDLE FileHandle,
> + IN CONST EFI_PEI_SERVICES **PeiServices
> + )
> +{
> + EFI_STATUS Status;
> +
> + //
> + // Install EFI_PEI_MM_ACCESS_PPI for S3 resume case
> + //
> + Status = PeiInstallSmmAccessPpi ();
> +
> + return Status;
> +}
> diff --git a/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3AdvancedPei.inf
> b/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3AdvancedPei.inf
> new file mode 100644
> index 00000000..9b654bfa
> --- /dev/null
> +++ b/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3AdvancedPei.inf
> @@ -0,0 +1,31 @@
> +### @file
> +# Component information file for the S3 Advanced PEI module.
> +#
> +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +###
> +
> +[Defines]
> + INF_VERSION = 0x00010017
> + BASE_NAME = S3AdvancedPei
> + FILE_GUID = 8683EFB2-FDE1-4AFF-B2DB-E96449FDD4E9
> + VERSION_STRING = 1.0
> + MODULE_TYPE = PEIM
> + ENTRY_POINT = S3AdvancedEntryPoint
> +
> +[LibraryClasses]
> + PeimEntryPoint
> + PeiServicesLib
> + SmmAccessLib
> +
> +[Packages]
> + IntelSiliconPkg/IntelSiliconPkg.dec
> + MdePkg/MdePkg.dec
> +
> +[Sources]
> + S3AdvancedPei.c
> +
> +[Depex]
> + TRUE
> --
> 2.16.2.windows.1
>
>
>
prev parent reply other threads:[~2019-09-05 13:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 8:51 [edk2-platforms][PATCH] AdvancedFeaturePkg/S3Advanced Add S3 Advanced PEIM driver Marc W Chen
2019-09-05 13:08 ` Liming Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4F3325@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox