From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: liming.gao@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Thu, 05 Sep 2019 06:08:20 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2019 06:08:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,470,1559545200"; d="scan'208";a="184230609" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga007.fm.intel.com with ESMTP; 05 Sep 2019 06:08:19 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 5 Sep 2019 06:08:19 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 5 Sep 2019 06:08:18 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.89]) with mapi id 14.03.0439.000; Thu, 5 Sep 2019 21:08:16 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Chen, Marc W" CC: "Kubacki, Michael A" , "Chaganty, Rangasai V" Subject: Re: [edk2-devel] [edk2-platforms][PATCH] AdvancedFeaturePkg/S3Advanced Add S3 Advanced PEIM driver Thread-Topic: [edk2-devel] [edk2-platforms][PATCH] AdvancedFeaturePkg/S3Advanced Add S3 Advanced PEIM driver Thread-Index: AQHVY8cufBp+u0j76kiJJ0kXTTc+0KcdDiGA Date: Thu, 5 Sep 2019 13:08:15 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4F3325@SHSMSX104.ccr.corp.intel.com> References: <20190905085141.2672-1-marc.w.chen@intel.com> In-Reply-To: <20190905085141.2672-1-marc.w.chen@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDc2OTUxYzgtNzdjNy00MzIwLTg3Y2MtOTFmZGFlYTc1MGRjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUlNlbmJPT2piVzIzdUFNeGJXS25UaCtlbzNRTmZwb3lpMU8rSVQ4cFFWUmtLYnFDQmpHbzBzSkxCbm1BOXBhKyJ9 dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Marc: Please remove Change-Id: Ie5841047be350f411650ad30f16d210b98197dc4 in th= e commit message for the updated one.=20 Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ma= rc W Chen > Sent: Thursday, September 5, 2019 4:52 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chaganty, Rangasai= V ; Gao, Liming > ; Chen, Marc W > Subject: [edk2-devel] [edk2-platforms][PATCH] AdvancedFeaturePkg/S3Advan= ced Add S3 Advanced PEIM driver >=20 > Implement a S3 Advanced PEIM driver for supporting S3 feature. > So far this driver only install EFI_PEI_MM_ACCESS_PPI for S3 resume case= . >=20 > Change-Id: Ie5841047be350f411650ad30f16d210b98197dc4 > Cc: Michael Kubacki > Cc: Sai Chaganty > Cc: Liming Gao > Signed-off-by: Marc Chen > --- > .../S3Advanced/S3AdvancedPei/S3AdvancedPei.c | 36 +++++++++++++++= +++++++ > .../S3Advanced/S3AdvancedPei/S3AdvancedPei.inf | 31 +++++++++++++++= ++++ > 2 files changed, 67 insertions(+) > create mode 100644 Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3Advan= cedPei/S3AdvancedPei.c > create mode 100644 Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3Advan= cedPei/S3AdvancedPei.inf >=20 > diff --git a/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/= S3AdvancedPei.c > b/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3AdvancedP= ei.c > new file mode 100644 > index 00000000..9ce4cc6a > --- /dev/null > +++ b/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3Advan= cedPei.c > @@ -0,0 +1,36 @@ > +/** @file > + Source code file for S3 Advanced PEI module > + > +Copyright (c) 2019, Intel Corporation. All rights reserved.
> +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include > +#include > + > +/** > + S3 Advanced PEI module entry point > + > + @param[in] FileHandle Not used. > + @param[in] PeiServices General purpose services available t= o every PEIM. > + > + @retval EFI_SUCCESS The function completes successfully > + @retval EFI_OUT_OF_RESOURCES Insufficient resources to create dat= abase > +**/ > +EFI_STATUS > +EFIAPI > +S3AdvancedEntryPoint ( > + IN EFI_PEI_FILE_HANDLE FileHandle, > + IN CONST EFI_PEI_SERVICES **PeiServices > + ) > +{ > + EFI_STATUS Status; > + > + // > + // Install EFI_PEI_MM_ACCESS_PPI for S3 resume case > + // > + Status =3D PeiInstallSmmAccessPpi (); > + > + return Status; > +} > diff --git a/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/= S3AdvancedPei.inf > b/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3AdvancedP= ei.inf > new file mode 100644 > index 00000000..9b654bfa > --- /dev/null > +++ b/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3Advan= cedPei.inf > @@ -0,0 +1,31 @@ > +### @file > +# Component information file for the S3 Advanced PEI module. > +# > +# Copyright (c) 2019, Intel Corporation. All rights reserved.
> +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +### > + > +[Defines] > + INF_VERSION =3D 0x00010017 > + BASE_NAME =3D S3AdvancedPei > + FILE_GUID =3D 8683EFB2-FDE1-4AFF-B2DB-E96449FDD4= E9 > + VERSION_STRING =3D 1.0 > + MODULE_TYPE =3D PEIM > + ENTRY_POINT =3D S3AdvancedEntryPoint > + > +[LibraryClasses] > + PeimEntryPoint > + PeiServicesLib > + SmmAccessLib > + > +[Packages] > + IntelSiliconPkg/IntelSiliconPkg.dec > + MdePkg/MdePkg.dec > + > +[Sources] > + S3AdvancedPei.c > + > +[Depex] > + TRUE > -- > 2.16.2.windows.1 >=20 >=20 >=20