From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: liming.gao@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Mon, 09 Sep 2019 00:46:22 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Sep 2019 00:46:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,484,1559545200"; d="scan'208";a="191435877" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 09 Sep 2019 00:46:21 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 9 Sep 2019 00:46:21 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 9 Sep 2019 00:46:21 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.146]) with mapi id 14.03.0439.000; Mon, 9 Sep 2019 15:46:19 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Feng, Bob C" Subject: Re: [edk2-devel] [Patch 1/3] BaseTools: Fixed the build fail on Linux with --genfds-multi-thread Thread-Topic: [edk2-devel] [Patch 1/3] BaseTools: Fixed the build fail on Linux with --genfds-multi-thread Thread-Index: AQHVZLY8cX0waMyq9kq0sfF9g6VL7qci+7Pg Date: Mon, 9 Sep 2019 07:46:19 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4F4A0C@SHSMSX104.ccr.corp.intel.com> References: <20190906132259.29500-1-bob.c.feng@intel.com> <20190906132259.29500-2-bob.c.feng@intel.com> In-Reply-To: <20190906132259.29500-2-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Bob: What case will call GenSec without the exist file?=20 Thanks Liming >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Bob Feng >Sent: Friday, September 06, 2019 9:23 PM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >Subject: [edk2-devel] [Patch 1/3] BaseTools: Fixed the build fail on Linu= x with - >-genfds-multi-thread > >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1302 > >If GenSec input file not exist, the related command will fail and make >will stop on Linux. GenSec input file is allow to be non-existent. > >This patch is to let "make" continue if gensec input file not exist. > >Cc: Liming Gao >Signed-off-by: Bob Feng >--- > BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py >b/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py >index 037828ea1cca..0f691ae52420 100644 >--- a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py >+++ b/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py >@@ -487,11 +487,11 @@ class GenFdsGlobalVariable: > SaveFileOnChange(CommandFile, ' '.join(Cmd), False) > if IsMakefile: > if GlobalData.gGlobalDefines.get("FAMILY") =3D=3D "MSFT"= : > Cmd =3D ['if', 'exist', Input[0]] + Cmd > else: >- Cmd =3D ['test', '-e', Input[0], "&&"] + Cmd >+ Cmd =3D ['-test', '-e', Input[0], "&&"] + Cmd > if ' '.join(Cmd).strip() not in GenFdsGlobalVariable.Sec= CmdList: > GenFdsGlobalVariable.SecCmdList.append(' '.join(Cmd)= .strip()) > elif GenFdsGlobalVariable.NeedsUpdate(Output, list(Input) + >[CommandFile]): > GenFdsGlobalVariable.DebugLogger(EdkLogger.DEBUG_5, "%s = needs >update because of newer %s" % (Output, Input)) > GenFdsGlobalVariable.CallExternalTool(Cmd, "Failed to ge= nerate >section") >-- >2.20.1.windows.1 > > >