Re: [edk2-devel] [Patch 1/3] BaseTools: Fixed the build fail on Linux with --genfds-multi-thread

["Liming Gao" <liming.gao@intel.com>]

OK. I understand this case. 

> -----Original Message-----
> From: Feng, Bob C
> Sent: Monday, September 9, 2019 4:00 PM
> To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io
> Subject: RE: [edk2-devel] [Patch 1/3] BaseTools: Fixed the build fail on Linux with --genfds-multi-thread
> 
> For the case that the Non-Hii Driver does not generate .offset file for uni string offset.
> 
> -----Original Message-----
> From: Gao, Liming
> Sent: Monday, September 9, 2019 3:46 PM
> To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>
> Subject: RE: [edk2-devel] [Patch 1/3] BaseTools: Fixed the build fail on Linux with --genfds-multi-thread
> 
> Bob:
>   What case will call GenSec without the exist file?
> 
> Thanks
> Liming
> >-----Original Message-----
> >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> >Bob Feng
> >Sent: Friday, September 06, 2019 9:23 PM
> >To: devel@edk2.groups.io
> >Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C
> ><bob.c.feng@intel.com>
> >Subject: [edk2-devel] [Patch 1/3] BaseTools: Fixed the build fail on
> >Linux with - -genfds-multi-thread
> >
> >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1302
> >
> >If GenSec input file not exist, the related command will fail and make
> >will stop on Linux. GenSec input file is allow to be non-existent.
> >
> >This patch is to let "make" continue if gensec input file not exist.
> >
> >Cc: Liming Gao <liming.gao@intel.com>
> >Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> >---
> > BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
> >b/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
> >index 037828ea1cca..0f691ae52420 100644
> >--- a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
> >+++ b/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
> >@@ -487,11 +487,11 @@ class GenFdsGlobalVariable:
> >             SaveFileOnChange(CommandFile, ' '.join(Cmd), False)
> >             if IsMakefile:
> >                 if GlobalData.gGlobalDefines.get("FAMILY") == "MSFT":
> >                     Cmd = ['if', 'exist', Input[0]] + Cmd
> >                 else:
> >-                    Cmd = ['test', '-e', Input[0], "&&"] + Cmd
> >+                    Cmd = ['-test', '-e', Input[0], "&&"] + Cmd
> >                 if ' '.join(Cmd).strip() not in GenFdsGlobalVariable.SecCmdList:
> >                     GenFdsGlobalVariable.SecCmdList.append(' '.join(Cmd).strip())
> >             elif GenFdsGlobalVariable.NeedsUpdate(Output, list(Input)
> >+
> >[CommandFile]):
> >                 GenFdsGlobalVariable.DebugLogger(EdkLogger.DEBUG_5,
> >"%s needs update because of newer %s" % (Output, Input))
> >                 GenFdsGlobalVariable.CallExternalTool(Cmd, "Failed to
> >generate
> >section")
> >--
> >2.20.1.windows.1
> >
> >
> >