public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [Patch 1/1] BaseTools: Fixed a bug of IgnoreAutoGen
Date: Thu, 12 Sep 2019 05:51:33 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4F75F3@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190911101352.9528-1-bob.c.feng@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Feng, Bob C
>Sent: Wednesday, September 11, 2019 6:14 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
>Subject: [Patch 1/1] BaseTools: Fixed a bug of IgnoreAutoGen
>
>REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2080
>After checking that if the build can't
>ignore Autogen due to there is no compelet autogen files,
>the build tool need to do a completely Autogen.
>
>This patch is to fix a bug that if AutoGen
>can't be skiped, the SkipAutoGen flag
>need to set to False
>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>---
> BaseTools/Source/Python/build/build.py | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/BaseTools/Source/Python/build/build.py
>b/BaseTools/Source/Python/build/build.py
>index 13be6c33ecd5..a034664dc388 100755
>--- a/BaseTools/Source/Python/build/build.py
>+++ b/BaseTools/Source/Python/build/build.py
>@@ -2202,10 +2202,11 @@ class Build():
>                 ExitFlag = threading.Event()
>                 ExitFlag.clear()
>                 if self.SkipAutoGen:
>                     Wa = self.VerifyAutoGenFiles()
>                     if Wa is None:
>+                        self.SkipAutoGen = False
>                         Wa, self.BuildModules =
>self.PerformAutoGen(BuildTarget,ToolChain)
>                     else:
>                         GlobalData.gAutoGenPhase = True
>                         self.BuildModules = self.SetupMakeSetting(Wa)
>                 else:
>--
>2.20.1.windows.1


      reply	other threads:[~2019-09-12  5:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11 10:13 [Patch 1/1] BaseTools: Fixed a bug of IgnoreAutoGen Bob Feng
2019-09-12  5:51 ` Liming Gao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4F75F3@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox