From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: liming.gao@intel.com)
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by groups.io with SMTP; Wed, 11 Sep 2019 22:51:36 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
  by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2019 22:51:35 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,495,1559545200"; 
   d="scan'208";a="186033650"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
  by fmsmga007.fm.intel.com with ESMTP; 11 Sep 2019 22:51:35 -0700
Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 11 Sep 2019 22:51:35 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by
 SHSMSX153.ccr.corp.intel.com ([169.254.12.235]) with mapi id 14.03.0439.000;
 Thu, 12 Sep 2019 13:51:33 +0800
From: "Liming Gao" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
Subject: Re: [Patch 1/1] BaseTools: Fixed a bug of IgnoreAutoGen
Thread-Topic: [Patch 1/1] BaseTools: Fixed a bug of IgnoreAutoGen
Thread-Index: AQHVaImj62Tq1EH7L0iWBO4RaQjLf6cniysA
Date: Thu, 12 Sep 2019 05:51:33 +0000
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4F75F3@SHSMSX104.ccr.corp.intel.com>
References: <20190911101352.9528-1-bob.c.feng@intel.com>
In-Reply-To: <20190911101352.9528-1-bob.c.feng@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: liming.gao@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Feng, Bob C
>Sent: Wednesday, September 11, 2019 6:14 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
>Subject: [Patch 1/1] BaseTools: Fixed a bug of IgnoreAutoGen
>
>REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2080
>After checking that if the build can't
>ignore Autogen due to there is no compelet autogen files,
>the build tool need to do a completely Autogen.
>
>This patch is to fix a bug that if AutoGen
>can't be skiped, the SkipAutoGen flag
>need to set to False
>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>---
> BaseTools/Source/Python/build/build.py | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/BaseTools/Source/Python/build/build.py
>b/BaseTools/Source/Python/build/build.py
>index 13be6c33ecd5..a034664dc388 100755
>--- a/BaseTools/Source/Python/build/build.py
>+++ b/BaseTools/Source/Python/build/build.py
>@@ -2202,10 +2202,11 @@ class Build():
>                 ExitFlag =3D threading.Event()
>                 ExitFlag.clear()
>                 if self.SkipAutoGen:
>                     Wa =3D self.VerifyAutoGenFiles()
>                     if Wa is None:
>+                        self.SkipAutoGen =3D False
>                         Wa, self.BuildModules =3D
>self.PerformAutoGen(BuildTarget,ToolChain)
>                     else:
>                         GlobalData.gAutoGenPhase =3D True
>                         self.BuildModules =3D self.SetupMakeSetting(Wa)
>                 else:
>--
>2.20.1.windows.1