From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: liming.gao@intel.com)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by groups.io with SMTP; Sun, 15 Sep 2019 22:11:52 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
  by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Sep 2019 22:11:51 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,510,1559545200"; 
   d="scan'208";a="387085858"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
  by fmsmga006.fm.intel.com with ESMTP; 15 Sep 2019 22:11:50 -0700
Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Sun, 15 Sep 2019 22:11:50 -0700
Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by
 fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Sun, 15 Sep 2019 22:11:50 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by
 SHSMSX103.ccr.corp.intel.com ([169.254.4.140]) with mapi id 14.03.0439.000;
 Mon, 16 Sep 2019 13:11:48 +0800
From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Zhang, Shenglei"
	<shenglei.zhang@intel.com>
CC: "Kubacki, Michael A" <michael.a.kubacki@intel.com>, "Chaganty, Rangasai V"
	<rangasai.v.chaganty@intel.com>
Subject: Re: [edk2-devel] [PATCH] AdvancedFeaturePkg/BmcElog: Change arithmetic logic
Thread-Topic: [edk2-devel] [PATCH] AdvancedFeaturePkg/BmcElog: Change
 arithmetic logic
Thread-Index: AQHVYYazG/MYWS4qDEqe0s9cvFhqoKct12jA
Date: Mon, 16 Sep 2019 05:11:47 +0000
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4F8473@SHSMSX104.ccr.corp.intel.com>
References: <20190902120514.18028-1-shenglei.zhang@intel.com>
In-Reply-To: <20190902120514.18028-1-shenglei.zhang@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: liming.gao@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Zhang, Shenglei
>Sent: Monday, September 02, 2019 8:05 PM
>To: devel@edk2.groups.io
>Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chaganty, Rangasai =
V
><rangasai.v.chaganty@intel.com>; Gao, Liming <liming.gao@intel.com>
>Subject: [edk2-devel] [PATCH] AdvancedFeaturePkg/BmcElog: Change
>arithmetic logic
>
>Change the value from "sizeof(UINT8)" to 1 in the arithmetic expression.
>The original value added to (UINT8 *)&GetBmcGlobalEnables is
>(sizeof(UINT8)*sizeof(UINT8)) which equals to 1, so the functionality
>looks right. But the arithmetic logic is actually wrong.
>
>Cc: Michael Kubacki <michael.a.kubacki@intel.com>
>Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>---
> Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c
>b/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c
>index 421fbdec..beaa3fa0 100644
>--- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c
>+++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c
>@@ -131,7 +131,7 @@ Returns:
>         ElogStat =3D 1;
>       }
>
>-      CopyMem (&SetBmcGlobalEnables, (UINT8 *)&GetBmcGlobalEnables +
>sizeof(UINT8), sizeof(UINT8));
>+      CopyMem (&SetBmcGlobalEnables, (UINT8 *)&GetBmcGlobalEnables + 1,
>sizeof(UINT8));
>       SetBmcGlobalEnables.SetEnables.Bits.SystemEventLogging =3D ElogSta=
t;
>
>       Status =3D IpmiSetBmcGlobalEnables (&SetBmcGlobalEnables,
>&CompletionCode);
>--
>2.18.0.windows.1
>
>
>