public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "Wei, David Y" <david.y.wei@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>,
	"Sinha, Ankit" <ankit.sinha@intel.com>,
	"Agyeman, Prince" <prince.agyeman@intel.com>,
	"Kubacki, Michael A" <michael.a.kubacki@intel.com>,
	"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-platforms PATCH v2] SimicsOpenBoardPkg: Change Guid name to fix build error
Date: Tue, 17 Sep 2019 00:15:26 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4F8B65@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <c14d287b3a9fa9a541ebf331d74489ac134ead14.1568673182.git.david.y.wei@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Wei, David Y
>Sent: Tuesday, September 17, 2019 6:40 AM
>To: devel@edk2.groups.io
>Cc: Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming <liming.gao@intel.com>;
>Sinha, Ankit <ankit.sinha@intel.com>; Agyeman, Prince
><prince.agyeman@intel.com>; Kubacki, Michael A
><michael.a.kubacki@intel.com>; Desimone, Nathaniel L
><nathaniel.l.desimone@intel.com>; Kinney, Michael D
><michael.d.kinney@intel.com>
>Subject: [edk2-platforms PATCH v2] SimicsOpenBoardPkg: Change Guid name
>to fix build error
>
>MinPlatform PKG now use gEfiSmmSmramMemoryGuid instead of
>gEfiSmmPeiSmramMemoryReserveGuid to build memory HOB.
>SimicsOpenBoardPkg need to update for it accordingly.
>
>Cc: Hao Wu <hao.a.wu@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Ankit Sinha <ankit.sinha@intel.com>
>Cc: Agyeman Prince <prince.agyeman@intel.com>
>Cc: Kubacki Michael A <michael.a.kubacki@intel.com>
>Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>
>Signed-off-by: David Wei <david.y.wei@intel.com>
>---
> Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c   | 2 +-
> Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
>b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
>index 90e6d1d3cf..ee0eead5a8 100644
>--- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
>+++ b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
>@@ -449,7 +449,7 @@ QemuInitializeRam (
> 	  SmramRanges = 1;
>
>       Hob.Raw = BuildGuidHob(
>-          &gEfiSmmPeiSmramMemoryReserveGuid,
>+          &gEfiSmmSmramMemoryGuid,
>           BufferSize
>       );
>       ASSERT(Hob.Raw);
>diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf
>b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf
>index ccc7037d75..e466d57e4e 100644
>--- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf
>+++ b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf
>@@ -39,7 +39,7 @@
>
> [Guids]
>   gEfiMemoryTypeInformationGuid
>-  gEfiSmmPeiSmramMemoryReserveGuid              ## CONSUMES
>+  gEfiSmmSmramMemoryGuid              ## CONSUMES
>
> [LibraryClasses]
>   BaseLib
>--
>2.16.2.windows.1


  reply	other threads:[~2019-09-17  0:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-16 22:39 [edk2-platforms PATCH v2] SimicsOpenBoardPkg: Change Guid name to fix build error David Wei
2019-09-17  0:15 ` Liming Gao [this message]
2019-09-19  3:57 ` Kubacki, Michael A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4F8B65@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox