From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [edk2-devel] [Patch 0/3] Clean BaseTools code for build performance
Date: Tue, 17 Sep 2019 01:53:39 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4F8D22@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190910093705.34060-1-bob.c.feng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Bob Feng
>Sent: Tuesday, September 10, 2019 5:37 PM
>To: devel@edk2.groups.io
>Subject: [edk2-devel] [Patch 0/3] Clean BaseTools code for build performance
>
>REF:
>1 https://bugzilla.tianocore.org/show_bug.cgi?id=2102
>2 https://bugzilla.tianocore.org/show_bug.cgi?id=2101
>3 https://bugzilla.tianocore.org/show_bug.cgi?id=2183
>
>By profiling build Ovmf with cProfile:
>
>1. re.findall time reduced:
>after patch:
>0.017 {method 'findall' of '_sre.SRE_Pattern' objects}
>original:
>0.212 {method 'findall' of '_sre.SRE_Pattern' objects}
>
>2. times of call of os.stat is reduced
>after patch:
>33307 {built-in method nt.stat}
>orignial:
>33774 {built-in method nt.stat}
>
>3. rename call is removed.
>original:
>2.165 {built-in method nt.rename}
>
>Feng, Bob C (3):
> BaseTools: Improve GetDependencyList function
> BaseTools: remove unnecessary calls of os.exist
> BaseTools:Remove the unnecessary operation of renaming a file.
>
> .../Source/Python/AutoGen/AutoGenWorker.py | 7 +-
> BaseTools/Source/Python/AutoGen/GenC.py | 97 ++++++++++---------
> BaseTools/Source/Python/AutoGen/GenMake.py | 35 ++++---
> .../Source/Python/AutoGen/PlatformAutoGen.py | 8 +-
> .../Source/Python/AutoGen/UniClassObject.py | 5 +-
> BaseTools/Source/Python/Common/Misc.py | 23 +----
> 6 files changed, 82 insertions(+), 93 deletions(-)
>
>--
>2.20.1.windows.1
>
>
>
prev parent reply other threads:[~2019-09-17 1:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 9:37 [Patch 0/3] Clean BaseTools code for build performance Bob Feng
2019-09-17 1:53 ` Liming Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4F8D22@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox