* [Patch 0/3] Clean BaseTools code for build performance
@ 2019-09-10 9:37 Bob Feng
2019-09-17 1:53 ` [edk2-devel] " Liming Gao
0 siblings, 1 reply; 2+ messages in thread
From: Bob Feng @ 2019-09-10 9:37 UTC (permalink / raw)
To: devel
REF:
1 https://bugzilla.tianocore.org/show_bug.cgi?id=2102
2 https://bugzilla.tianocore.org/show_bug.cgi?id=2101
3 https://bugzilla.tianocore.org/show_bug.cgi?id=2183
By profiling build Ovmf with cProfile:
1. re.findall time reduced:
after patch:
0.017 {method 'findall' of '_sre.SRE_Pattern' objects}
original:
0.212 {method 'findall' of '_sre.SRE_Pattern' objects}
2. times of call of os.stat is reduced
after patch:
33307 {built-in method nt.stat}
orignial:
33774 {built-in method nt.stat}
3. rename call is removed.
original:
2.165 {built-in method nt.rename}
Feng, Bob C (3):
BaseTools: Improve GetDependencyList function
BaseTools: remove unnecessary calls of os.exist
BaseTools:Remove the unnecessary operation of renaming a file.
.../Source/Python/AutoGen/AutoGenWorker.py | 7 +-
BaseTools/Source/Python/AutoGen/GenC.py | 97 ++++++++++---------
BaseTools/Source/Python/AutoGen/GenMake.py | 35 ++++---
.../Source/Python/AutoGen/PlatformAutoGen.py | 8 +-
.../Source/Python/AutoGen/UniClassObject.py | 5 +-
BaseTools/Source/Python/Common/Misc.py | 23 +----
6 files changed, 82 insertions(+), 93 deletions(-)
--
2.20.1.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [edk2-devel] [Patch 0/3] Clean BaseTools code for build performance
2019-09-10 9:37 [Patch 0/3] Clean BaseTools code for build performance Bob Feng
@ 2019-09-17 1:53 ` Liming Gao
0 siblings, 0 replies; 2+ messages in thread
From: Liming Gao @ 2019-09-17 1:53 UTC (permalink / raw)
To: devel@edk2.groups.io, Feng, Bob C
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Bob Feng
>Sent: Tuesday, September 10, 2019 5:37 PM
>To: devel@edk2.groups.io
>Subject: [edk2-devel] [Patch 0/3] Clean BaseTools code for build performance
>
>REF:
>1 https://bugzilla.tianocore.org/show_bug.cgi?id=2102
>2 https://bugzilla.tianocore.org/show_bug.cgi?id=2101
>3 https://bugzilla.tianocore.org/show_bug.cgi?id=2183
>
>By profiling build Ovmf with cProfile:
>
>1. re.findall time reduced:
>after patch:
>0.017 {method 'findall' of '_sre.SRE_Pattern' objects}
>original:
>0.212 {method 'findall' of '_sre.SRE_Pattern' objects}
>
>2. times of call of os.stat is reduced
>after patch:
>33307 {built-in method nt.stat}
>orignial:
>33774 {built-in method nt.stat}
>
>3. rename call is removed.
>original:
>2.165 {built-in method nt.rename}
>
>Feng, Bob C (3):
> BaseTools: Improve GetDependencyList function
> BaseTools: remove unnecessary calls of os.exist
> BaseTools:Remove the unnecessary operation of renaming a file.
>
> .../Source/Python/AutoGen/AutoGenWorker.py | 7 +-
> BaseTools/Source/Python/AutoGen/GenC.py | 97 ++++++++++---------
> BaseTools/Source/Python/AutoGen/GenMake.py | 35 ++++---
> .../Source/Python/AutoGen/PlatformAutoGen.py | 8 +-
> .../Source/Python/AutoGen/UniClassObject.py | 5 +-
> BaseTools/Source/Python/Common/Misc.py | 23 +----
> 6 files changed, 82 insertions(+), 93 deletions(-)
>
>--
>2.20.1.windows.1
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-17 1:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-10 9:37 [Patch 0/3] Clean BaseTools code for build performance Bob Feng
2019-09-17 1:53 ` [edk2-devel] " Liming Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox