Re: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***

["Liming Gao" <liming.gao@intel.com>]

Ching:
  The change is good. With this change, have you verified VS2017 tool chain? 
  I want to make sure there is no impact on VS2017. 

Thanks
Liming
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Cheng, Ching JenX
> Sent: Tuesday, September 17, 2019 11:23 AM
> To: devel@edk2.groups.io; Cheng, Ching JenX <ching.jenx.cheng@intel.com>
> Subject: Re: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182
> 
> In order to support VS2019 on EDK2, the following patches was modified def and batch files 1. Add VS2019 x86/64 definitions on
> tools_def.template 2. Add VS2019 support on toolsetup batches, and add version check with command vswhere
>      Because VS2019 and VS2017 using the same vswhere to get the InstallationPath
> 
> v2: In 01/02, add ARM/AARCH64/EBC Definitions, Combine VS2017_HOST and VS2019_HOST to VS_HOST
> 
> Ching JenX Cheng (2):
>   Add VS2019 Toolchain def
>   Add VS2019 Support on ToolSetup Batches
> 
>  BaseTools/Conf/tools_def.template | 220
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------
>  BaseTools/get_vsvars.bat          |  37 ++++++++++++++++++++++++++++++-------
>  BaseTools/set_vsprefix_envs.bat   |  70 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----
>  BaseTools/toolsetup.bat           |  16 +++++++++++++---
>  edksetup.bat                      |   6 ++++--
>  5 files changed, 313 insertions(+), 36 deletions(-)
> 
> --
> 2.21.0.windows.1
> 
> 
> 
> 
> 
>