From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: liming.gao@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Tue, 17 Sep 2019 07:56:51 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2019 07:56:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,516,1559545200"; d="scan'208";a="387583268" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 17 Sep 2019 07:56:50 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Sep 2019 07:56:50 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 17 Sep 2019 07:56:49 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 17 Sep 2019 07:56:49 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.86]) with mapi id 14.03.0439.000; Tue, 17 Sep 2019 22:56:47 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Cheng, Ching JenX" Subject: Re: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support *** Thread-Topic: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support *** Thread-Index: AQHVbQZ9RNWIByT0v0+BQpKAAZ36KKcvM4rAgAC/j2A= Date: Tue, 17 Sep 2019 14:56:47 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FD83B@SHSMSX104.ccr.corp.intel.com> References: <15C51B795F616549.24469@groups.io> <41C441B9D06FFF49AD23ED447CFBE8B160A9CB@BGSMSX105.gar.corp.intel.com> In-Reply-To: <41C441B9D06FFF49AD23ED447CFBE8B160A9CB@BGSMSX105.gar.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2FlYWY5NDUtM2Q5NS00NTZhLThlMzMtODliYjNmZTVjN2E2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSEFCQXlFV1NCaGNYTWpiK3h4c1EzOTlSVFhxcFwvWjNjOUpjUzc4WGoxMGlrYk9hd0srOUFaTDlQaUFuR2lZc2oifQ== dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ching: The change is good. With this change, have you verified VS2017 tool chai= n?=20 I want to make sure there is no impact on VS2017.=20 Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ch= eng, Ching JenX > Sent: Tuesday, September 17, 2019 11:23 AM > To: devel@edk2.groups.io; Cheng, Ching JenX > Subject: Re: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support *** >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2182 >=20 > In order to support VS2019 on EDK2, the following patches was modified d= ef and batch files 1. Add VS2019 x86/64 definitions on > tools_def.template 2. Add VS2019 support on toolsetup batches, and add v= ersion check with command vswhere > Because VS2019 and VS2017 using the same vswhere to get the Install= ationPath >=20 > v2: In 01/02, add ARM/AARCH64/EBC Definitions, Combine VS2017_HOST and V= S2019_HOST to VS_HOST >=20 > Ching JenX Cheng (2): > Add VS2019 Toolchain def > Add VS2019 Support on ToolSetup Batches >=20 > BaseTools/Conf/tools_def.template | 220 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++------------------- > BaseTools/get_vsvars.bat | 37 ++++++++++++++++++++++++++++++-= ------ > BaseTools/set_vsprefix_envs.bat | 70 +++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++++++----- > BaseTools/toolsetup.bat | 16 +++++++++++++--- > edksetup.bat | 6 ++++-- > 5 files changed, 313 insertions(+), 36 deletions(-) >=20 > -- > 2.21.0.windows.1 >=20 >=20 >=20 >=20 >=20 >=20