From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: liming.gao@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Tue, 17 Sep 2019 21:47:53 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2019 21:47:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,519,1559545200"; d="scan'208";a="181010175" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga008.jf.intel.com with ESMTP; 17 Sep 2019 21:47:52 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Sep 2019 21:47:52 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Sep 2019 21:47:52 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by shsmsx102.ccr.corp.intel.com ([169.254.2.113]) with mapi id 14.03.0439.000; Wed, 18 Sep 2019 12:47:50 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "lersek@redhat.com" CC: "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH 17/35] MdePkg/DxeServicesLib: remove bogus cast Thread-Topic: [edk2-devel] [PATCH 17/35] MdePkg/DxeServicesLib: remove bogus cast Thread-Index: AQHVbZEollfnObm4h0SyROg3FYicyacw3U2A Date: Wed, 18 Sep 2019 04:47:49 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FDD26@SHSMSX104.ccr.corp.intel.com> References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-18-lersek@redhat.com> In-Reply-To: <20190917194935.24322-18-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Laszlo Ersek >Sent: Wednesday, September 18, 2019 3:49 AM >To: edk2-devel-groups-io >Cc: Gao, Liming ; Kinney, Michael D > >Subject: [edk2-devel] [PATCH 17/35] MdePkg/DxeServicesLib: remove bogus >cast > >The HandleProtocol() boot service takes an EFI_HANDLE, not an >(EFI_HANDLE*). Remove the bogus cast in the >InternalImageHandleToFvHandle() function. > >This is a semantic cleanup; there is no change in behavior. > >Cc: Liming Gao >Cc: Michael D Kinney >Signed-off-by: Laszlo Ersek >--- > >Notes: > lightly tested, most probably: it's practically impossible to build a > platform without consuming DxeServicesLib > > MdePkg/Library/DxeServicesLib/DxeServicesLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/MdePkg/Library/DxeServicesLib/DxeServicesLib.c >b/MdePkg/Library/DxeServicesLib/DxeServicesLib.c >index c416b2dd8c65..0735b2f80400 100644 >--- a/MdePkg/Library/DxeServicesLib/DxeServicesLib.c >+++ b/MdePkg/Library/DxeServicesLib/DxeServicesLib.c >@@ -49,7 +49,7 @@ InternalImageHandleToFvHandle ( > ASSERT (ImageHandle !=3D NULL); > > Status =3D gBS->HandleProtocol ( >- (EFI_HANDLE *) ImageHandle, >+ ImageHandle, > &gEfiLoadedImageProtocolGuid, > (VOID **) &LoadedImage > ); >-- >2.19.1.3.g30247aa5d201 > > > >-=3D-=3D-=3D-=3D-=3D-=3D >Groups.io Links: You receive all messages sent to this group. > >View/Reply Online (#47404): https://edk2.groups.io/g/devel/message/47404 >Mute This Topic: https://groups.io/mt/34180218/1759384 >Group Owner: devel+owner@edk2.groups.io >Unsubscribe: https://edk2.groups.io/g/devel/unsub [liming.gao@intel.com] >-=3D-=3D-=3D-=3D-=3D-=3D