From: "Liming Gao" <liming.gao@intel.com>
To: "Cheng, Ching JenX" <ching.jenx.cheng@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***
Date: Wed, 18 Sep 2019 08:13:17 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FDFE6@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <41C441B9D06FFF49AD23ED447CFBE8B160AD1D@BGSMSX105.gar.corp.intel.com>
That's good. I have no other comment. Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Cheng, Ching JenX
>Sent: Wednesday, September 18, 2019 9:51 AM
>To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io
>Subject: RE: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***
>
>Hi Liming,
>
>The VS2017 is still working fine with this changes,
>I have verified it with VS2019, VS2017 and VS2015 build,
>
>Thanks,
>Allen
>
>> -----Original Message-----
>> From: Gao, Liming
>> Sent: Tuesday, September 17, 2019 10:57 PM
>> To: devel@edk2.groups.io; Cheng, Ching JenX
>> <ching.jenx.cheng@intel.com>
>> Subject: RE: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***
>>
>> Ching:
>> The change is good. With this change, have you verified VS2017 tool chain?
>> I want to make sure there is no impact on VS2017.
>>
>> Thanks
>> Liming
>> > -----Original Message-----
>> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>> > Cheng, Ching JenX
>> > Sent: Tuesday, September 17, 2019 11:23 AM
>> > To: devel@edk2.groups.io; Cheng, Ching JenX
>> > <ching.jenx.cheng@intel.com>
>> > Subject: Re: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***
>> >
>> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182
>> >
>> > In order to support VS2019 on EDK2, the following patches was modified
>> > def and batch files 1. Add VS2019 x86/64 definitions on tools_def.template
>> 2. Add VS2019 support on toolsetup batches, and add version check with
>> command vswhere
>> > Because VS2019 and VS2017 using the same vswhere to get the
>> > InstallationPath
>> >
>> > v2: In 01/02, add ARM/AARCH64/EBC Definitions, Combine VS2017_HOST
>> and
>> > VS2019_HOST to VS_HOST
>> >
>> > Ching JenX Cheng (2):
>> > Add VS2019 Toolchain def
>> > Add VS2019 Support on ToolSetup Batches
>> >
>> > BaseTools/Conf/tools_def.template | 220
>> >
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> ++
>> >
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> +++++++++++++++++++++++++-------------------
>> > BaseTools/get_vsvars.bat | 37
>> ++++++++++++++++++++++++++++++-------
>> > BaseTools/set_vsprefix_envs.bat | 70
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> +++++++-----
>> > BaseTools/toolsetup.bat | 16 +++++++++++++---
>> > edksetup.bat | 6 ++++--
>> > 5 files changed, 313 insertions(+), 36 deletions(-)
>> >
>> > --
>> > 2.21.0.windows.1
>> >
>> >
>> >
>> >
>> >
>> >
prev parent reply other threads:[~2019-09-18 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <15C51B795F616549.24469@groups.io>
2019-09-17 3:22 ` [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support *** Cheng, Ching JenX
2019-09-17 14:56 ` Liming Gao
2019-09-18 1:51 ` Cheng, Ching JenX
2019-09-18 8:13 ` Liming Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4FDFE6@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox