From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: liming.gao@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Wed, 18 Sep 2019 01:13:22 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 01:13:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,520,1559545200"; d="scan'208";a="177649430" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga007.jf.intel.com with ESMTP; 18 Sep 2019 01:13:20 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Sep 2019 01:13:20 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Sep 2019 01:13:20 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by shsmsx102.ccr.corp.intel.com ([169.254.2.113]) with mapi id 14.03.0439.000; Wed, 18 Sep 2019 16:13:18 +0800 From: "Liming Gao" To: "Cheng, Ching JenX" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support *** Thread-Topic: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support *** Thread-Index: AQHVbQZ9RNWIByT0v0+BQpKAAZ36KKcvM4rAgAC/j2CAADPpAIAA8Low Date: Wed, 18 Sep 2019 08:13:17 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FDFE6@SHSMSX104.ccr.corp.intel.com> References: <15C51B795F616549.24469@groups.io> <41C441B9D06FFF49AD23ED447CFBE8B160A9CB@BGSMSX105.gar.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FD83B@SHSMSX104.ccr.corp.intel.com> <41C441B9D06FFF49AD23ED447CFBE8B160AD1D@BGSMSX105.gar.corp.intel.com> In-Reply-To: <41C441B9D06FFF49AD23ED447CFBE8B160AD1D@BGSMSX105.gar.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable That's good. I have no other comment. Reviewed-by: Liming Gao >-----Original Message----- >From: Cheng, Ching JenX >Sent: Wednesday, September 18, 2019 9:51 AM >To: Gao, Liming ; devel@edk2.groups.io >Subject: RE: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support *** > >Hi Liming, > >The VS2017 is still working fine with this changes, >I have verified it with VS2019, VS2017 and VS2015 build, > >Thanks, >Allen > >> -----Original Message----- >> From: Gao, Liming >> Sent: Tuesday, September 17, 2019 10:57 PM >> To: devel@edk2.groups.io; Cheng, Ching JenX >> >> Subject: RE: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support *** >> >> Ching: >> The change is good. With this change, have you verified VS2017 tool c= hain? >> I want to make sure there is no impact on VS2017. >> >> Thanks >> Liming >> > -----Original Message----- >> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> > Cheng, Ching JenX >> > Sent: Tuesday, September 17, 2019 11:23 AM >> > To: devel@edk2.groups.io; Cheng, Ching JenX >> > >> > Subject: Re: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support *** >> > >> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2182 >> > >> > In order to support VS2019 on EDK2, the following patches was modifie= d >> > def and batch files 1. Add VS2019 x86/64 definitions on tools_def.tem= plate >> 2. Add VS2019 support on toolsetup batches, and add version check with >> command vswhere >> > Because VS2019 and VS2017 using the same vswhere to get the >> > InstallationPath >> > >> > v2: In 01/02, add ARM/AARCH64/EBC Definitions, Combine VS2017_HOST >> and >> > VS2019_HOST to VS_HOST >> > >> > Ching JenX Cheng (2): >> > Add VS2019 Toolchain def >> > Add VS2019 Support on ToolSetup Batches >> > >> > BaseTools/Conf/tools_def.template | 220 >> > >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> ++ >> > >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> +++++++++++++++++++++++++------------------- >> > BaseTools/get_vsvars.bat | 37 >> ++++++++++++++++++++++++++++++------- >> > BaseTools/set_vsprefix_envs.bat | 70 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> +++++++----- >> > BaseTools/toolsetup.bat | 16 +++++++++++++--- >> > edksetup.bat | 6 ++++-- >> > 5 files changed, 313 insertions(+), 36 deletions(-) >> > >> > -- >> > 2.21.0.windows.1 >> > >> > >> > >> > >> > >> >=20