Re: [edk2-devel] [PATCH V3 1/3] MdeModulePkg: Extend the support keyboard type of Terminal console

["Liming Gao" <liming.gao@intel.com>]

Zhichao:
  If GUID MACRO is not required, you don't need to add header file. But for this case, GUID MACRO is required. 
  So, you have to add the header file. Then, I suggest to add extern GuidCName together in this header file to match GUID MACRO. 

Thanks
Liming
>-----Original Message-----
>From: Gao, Zhichao
>Sent: Thursday, September 19, 2019 12:28 PM
>To: Wu, Hao A <hao.a.wu@intel.com>; devel@edk2.groups.io
>Cc: Wang, Jian J <jian.j.wang@intel.com>; Ni, Ray <ray.ni@intel.com>; Ard
>Biesheuvel <ard.biesheuvel@linaro.org>; Laszlo Ersek <lersek@redhat.com>;
>Gao, Liming <liming.gao@intel.com>
>Subject: RE: [edk2-devel] [PATCH V3 1/3] MdeModulePkg: Extend the
>support keyboard type of Terminal console
>
>Hi Hao,
>
>I used to get comments from Mike not to add MARCO name and extern
>declaration of the GUIDs to the header file.
>See https://edk2.groups.io/g/devel/message/40054.
>The MARCO is used in the patch #3, so I kept it.
>
>Thanks,
>Zhichao
>
>> -----Original Message-----
>> From: Wu, Hao A
>> Sent: Thursday, September 19, 2019 9:55 AM
>> To: devel@edk2.groups.io; Gao, Zhichao <zhichao.gao@intel.com>
>> Cc: Wang, Jian J <jian.j.wang@intel.com>; Ni, Ray <ray.ni@intel.com>; Ard
>> Biesheuvel <ard.biesheuvel@linaro.org>; Laszlo Ersek
><lersek@redhat.com>;
>> Gao, Liming <liming.gao@intel.com>
>> Subject: RE: [edk2-devel] [PATCH V3 1/3] MdeModulePkg: Extend the
>> support keyboard type of Terminal console
>>
>> > -----Original Message-----
>> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>> > Gao, Zhichao
>> > Sent: Wednesday, September 18, 2019 1:34 PM
>> > To: devel@edk2.groups.io
>> > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Ard Biesheuvel; Laszlo Ersek;
>> > Gao, Liming
>> > Subject: [edk2-devel] [PATCH V3 1/3] MdeModulePkg: Extend the
>support
>> > keyboard type of Terminal console
>> >
>> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186
>> >
>> > A common terminal console software Putty support various types of
>> > keyboard type, such as normal mode, Linux mode, Xterm R6, Vt400,
>> > VT100+ and SCO. Refer to the link:
>> > https://www.ssh.com/ssh/putty/putty-
>> manuals/0.68/Chapter4.html#config-
>> > funkeys
>> >
>> > Cc: Jian J Wang <jian.j.wang@intel.com>
>> > Cc: Hao A Wu <hao.a.wu@intel.com>
>> > Cc: Ray Ni <ray.ni@intel.com>
>> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> > Cc: Laszlo Ersek <lersek@redhat.com>
>> > Cc: Liming Gao <liming.gao@intel.com>
>> > Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
>> > ---
>> >  MdeModulePkg/Include/Guid/TtyTerm.h | 13 +++++++++++++
>> >  MdeModulePkg/MdeModulePkg.dec       |  4 ++++
>> >  2 files changed, 17 insertions(+)
>> >
>> > diff --git a/MdeModulePkg/Include/Guid/TtyTerm.h
>> > b/MdeModulePkg/Include/Guid/TtyTerm.h
>> > index 8333344b9d..471a651d4d 100644
>> > --- a/MdeModulePkg/Include/Guid/TtyTerm.h
>> > +++ b/MdeModulePkg/Include/Guid/TtyTerm.h
>> > @@ -4,6 +4,7 @@ provide support for modern *nix terminals.
>> >
>> >
>> >  Copyright (c) 2015  Linaro Ltd.
>> > +Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
>> >  SPDX-License-Identifier: BSD-2-Clause-Patent
>> >
>> >  **/
>> > @@ -14,6 +15,18 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>> >  #define EFI_TTY_TERM_GUID    \
>> >      {0x7d916d80, 0x5bb1, 0x458c, {0xa4, 0x8f, 0xe2, 0x5f, 0xdd, 0x51,
>> > 0xef,
>> > 0x94 } }
>> >
>> > +#define EDKII_LINUX_TERM_GUID   \
>> > +    {0xe4364a7f, 0xf825, 0x430e, {0x9d, 0x3a, 0x9c, 0x9b, 0xe6, 0x81,
>> > +0x7c,
>> > 0xa5 } }
>> > +
>> > +#define EDKII_XTERM_R6_GUID     \
>> > +    {0xfbfca56b, 0xbb36, 0x4b78, {0xaa, 0xab, 0xbe, 0x1b, 0x97, 0xec,
>> > +0x7c,
>> > 0xcb } }
>> > +
>> > +#define EDKII_VT400_GUID        \
>> > +    {0x8e46dddd, 0x3d49, 0x4a9d, {0xb8, 0x75, 0x3c, 0x08, 0x6f, 0x6a,
>> > +0xa2,
>> > 0xbd } }
>> > +
>> > +#define EDKII_SCO_TERM_GUID     \
>> > +    {0xfc7dd6e0, 0x813c, 0x434d, {0xb4, 0xda, 0x3b, 0xd6, 0x49, 0xe9,
>> > +0xe1,
>> > 0x5a } }
>> > +
>> >  extern EFI_GUID gEfiTtyTermGuid;
>> >
>> >  #endif
>> > diff --git a/MdeModulePkg/MdeModulePkg.dec
>> > b/MdeModulePkg/MdeModulePkg.dec index 17beb45235..7f72c122fc
>> 100644
>> > --- a/MdeModulePkg/MdeModulePkg.dec
>> > +++ b/MdeModulePkg/MdeModulePkg.dec
>> > @@ -342,6 +342,10 @@
>> >
>> >    ## Include/Guid/TtyTerm.h
>> >    gEfiTtyTermGuid                = { 0x7d916d80, 0x5bb1, 0x458c, {0xa4, 0x8f,
>0xe2,
>> > 0x5f, 0xdd, 0x51, 0xef, 0x94 }}
>> > +  gEdkiiLinuxTermGuid            = { 0xe4364a7f, 0xf825, 0x430e, {0x9d, 0x3a,
>> > 0x9c, 0x9b, 0xe6, 0x81, 0x7c, 0xa5 }}
>> > +  gEdkiiXtermR6Guid              = { 0xfbfca56b, 0xbb36, 0x4b78, {0xaa, 0xab,
>> > 0xbe, 0x1b, 0x97, 0xec, 0x7c, 0xcb }}
>> > +  gEdkiiVT400Guid                = { 0x8e46dddd, 0x3d49, 0x4a9d, {0xb8, 0x75,
>> 0x3c,
>> > 0x08, 0x6f, 0x6a, 0xa2, 0xbd }}
>> > +  gEdkiiSCOTermGuid              = { 0xfc7dd6e0, 0x813c, 0x434d, {0xb4, 0xda,
>> > 0x3b, 0xd6, 0x49, 0xe9, 0xe1, 0x5a }}
>>
>>
>> Since these 4 new GUIDs are listed under comments for file 'TtyTerm.h', I
>> would suggest to add these variable declarations in TtyTerm.h:
>>
>> extern EFI_GUID gEdkiiLinuxTermGuid;
>> extern EFI_GUID gEdkiiXtermR6Guid;
>> extern EFI_GUID gEdkiiVT400Guid;
>> extern EFI_GUID gEdkiiSCOTermGuid;
>>
>> With this handled,
>> Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
>>
>> Best Regards,
>> Hao Wu
>>
>>
>> >
>> >    ## Include/Guid/HiiBootMaintenanceFormset.h
>> >    gEfiIfrBootMaintenanceGuid      = { 0xb2dedc91, 0xd59f, 0x48d2, { 0x89,
>> 0x8a,
>> > 0x12, 0x49, 0xc, 0x74, 0xa4, 0xe0 }}
>> > --
>> > 2.21.0.windows.1
>> >
>> >
>> >