From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: liming.gao@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Wed, 18 Sep 2019 23:19:45 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 23:19:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,522,1559545200"; d="scan'208";a="388181639" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 18 Sep 2019 23:19:45 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Sep 2019 23:19:44 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Sep 2019 23:19:44 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.92]) with mapi id 14.03.0439.000; Thu, 19 Sep 2019 14:19:42 +0800 From: "Liming Gao" To: Baptiste Gerondeau , "devel@edk2.groups.io" CC: "ard.biesheuvel@linaro.org" , "leif.lindholm@linaro.org" , "Kinney, Michael D" , "Zhang, Shenglei" Subject: Re: [PATCH 0/3] Arm builds on Visual Studio Thread-Topic: [PATCH 0/3] Arm builds on Visual Studio Thread-Index: AQHVbjr7UhfXccefyEGDcWqS/FkS4qcyg69g Date: Thu, 19 Sep 2019 06:19:42 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FE630@SHSMSX104.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I add my comments.=20 >-----Original Message----- >From: Baptiste Gerondeau [mailto:baptiste.gerondeau@linaro.org] >Sent: Thursday, September 19, 2019 12:05 AM >To: devel@edk2.groups.io >Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; Kinney, Michael D >; Gao, Liming ; Zhang, >Shenglei ; Baptiste Gerondeau > >Subject: [PATCH 0/3] Arm builds on Visual Studio > >EDIT: Resending the series since I mistakenly used the wrong email, >sorry ! > >We are currently making an effort to make ARM (and AARCH64 eventually) >builds using Microsoft's Visual Studio Compiler (aka MSVC/MSFT). > >These 3 patches correspond to an effort to make the assembler work with >MSFT, which entails : >- Feeding MSFT the RVCT .asm files, since they share syntax > requirements. Please separate the patch. Each patch is for each package, can't cross pack= ages.=20 If so, the package maintainer can easy review the change.=20 >- Fixing some instructions syntax in those .asm files, in order to make > them palatable for MSFT. >- Fixing some minor formatting issue in INF files, while we're at it. > >This set enables the assembler, meanwhile the C also require changes, >which will come in a set later. This set makes the RVCT toolchain family >and profiles obsolete, unblocking : >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1750 With this change, can we continue to work on BZ 1750? > >As mentioned in the above bug, dropping RVCT would entail orphanating >the .asm files that powered the RVCT build. Since Visual Studio uses the >same file syntax, those can be reused to power the VS build. > >These patches have been tested on VS2019 (v15.9.11) and VS2017 (v16.0.1) Do you mean you verify this change with new VS2019 tool chain?=20 Thanks Liming > >Baptiste GERONDEAU (3): > ArmPkg/MdePkg : Unify INF files format > ARM/Assembler: Correct syntax from RVCT for MSFT > ARM/Assembler: Reuse RVCT assembler for MSFT build > > ArmPkg/Drivers/ArmGic/ArmGicLib.inf | 2= +- > ArmPkg/Library/ArmExceptionLib/Arm/ExceptionSupport.asm | 30 >+++++++++++++++++------------- > ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.inf | 2= +- > ArmPkg/Library/ArmExceptionLib/ArmRelocateExceptionLib.inf | 2= +- > ArmPkg/Library/ArmHvcLib/ArmHvcLib.inf | 2= +- > ArmPkg/Library/ArmLib/Arm/ArmV7Support.asm | 6= ++++-- > ArmPkg/Library/ArmLib/ArmBaseLib.inf | 8= ++++---- > ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf | 4= ++-- > ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf | 2= +- > ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf >| 2 +- > ArmPkg/Library/ArmSvcLib/ArmSvcLib.inf | 2= +- > ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf | 2= +- > ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf | 2 >+- > ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 6= +++--- > ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 6= +++--- > ArmPlatformPkg/PrePi/PeiMPCore.inf | 2= +- > ArmPlatformPkg/PrePi/PeiUniCore.inf | 2= +- > MdePkg/Library/BaseIoLibIntrinsic/Arm/ArmVirtMmio.asm | 18 >+++++++++--------- > MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicArmVirt.inf | 2= +- > MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf | >20 ++++++++++---------- > MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf | 2= +- > 21 files changed, 65 insertions(+), 59 deletions(-) > >-- >2.23.0