From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: liming.gao@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Thu, 19 Sep 2019 07:53:50 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Sep 2019 07:53:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,523,1559545200"; d="scan'208";a="188112654" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 19 Sep 2019 07:53:49 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 19 Sep 2019 07:53:48 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.92]) with mapi id 14.03.0439.000; Thu, 19 Sep 2019 22:53:47 +0800 From: "Liming Gao" To: Leif Lindholm , "Laszlo Ersek (lersek@redhat.com)" , "afish@apple.com" CC: Baptiste Gerondeau , "devel@edk2.groups.io" , "ard.biesheuvel@linaro.org" , "Kinney, Michael D" , "Zhang, Shenglei" Subject: Re: [PATCH 0/3] Arm builds on Visual Studio Thread-Topic: [PATCH 0/3] Arm builds on Visual Studio Thread-Index: AQHVbs7lIJ7Wq5loa0OkbIs5T07ypaczD9vA Date: Thu, 19 Sep 2019 14:53:46 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FEA95@SHSMSX104.ccr.corp.intel.com> References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FE630@SHSMSX104.ccr.corp.intel.com> <20190919094450.GN28454@bivouac.eciton.net> In-Reply-To: <20190919094450.GN28454@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjNmMTUzYTktZWUxMy00OGRiLTg0MTktZDlhMzdmN2I4ZTU2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQU9wTlBkdytHMlREeTlIb1BcL3htVUF6cXRIVHR3Q0M2dGlCTHo0OTJDeElZTllmWEpURjNHSDJhazFIcHphZzcifQ== dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif: For this special case of the single patch to include the changes in cross= packages, I include Laszlo, Fish and Mike for the discussion.=20 Thanks Liming > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Thursday, September 19, 2019 5:45 PM > To: Gao, Liming > Cc: Baptiste Gerondeau ; devel@edk2.groups= .io; ard.biesheuvel@linaro.org; Kinney, Michael D > ; Zhang, Shenglei > Subject: Re: [PATCH 0/3] Arm builds on Visual Studio >=20 > Hi Liming, >=20 > On Thu, Sep 19, 2019 at 06:19:42AM +0000, Gao, Liming wrote: > > I add my comments. > > > > >-----Original Message----- > > >From: Baptiste Gerondeau [mailto:baptiste.gerondeau@linaro.org] > > >Sent: Thursday, September 19, 2019 12:05 AM > > >To: devel@edk2.groups.io > > >Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; Kinney, Micha= el D > > >; Gao, Liming ; Zhan= g, > > >Shenglei ; Baptiste Gerondeau > > > > > >Subject: [PATCH 0/3] Arm builds on Visual Studio > > > > > >EDIT: Resending the series since I mistakenly used the wrong email, > > >sorry ! > > > > > >We are currently making an effort to make ARM (and AARCH64 eventually) > > >builds using Microsoft's Visual Studio Compiler (aka MSVC/MSFT). > > > > > >These 3 patches correspond to an effort to make the assembler work wit= h > > >MSFT, which entails : > > >- Feeding MSFT the RVCT .asm files, since they share syntax > > > requirements. > > > > Please separate the patch. Each patch is for each package, can't cross = packages. > > If so, the package maintainer can easy review the change. >=20 > I agree with this as a general rule, but for this (hopefully never to > be repeated) operation, it makes sense to me to keep each change in > this set as one patch. >=20 > For the simple reason that the alternative leaves several unusable > commits in sequence in the repository. There is simply no way to > bisect through this change on a per-package basis. >=20 > This is after all a horrible horrible hack that lets us keep using the > .asm files provided for one toolchain family (RVCT) in a different > toolchain family (MSFT), without having to delete and re-add, losing > history in the process. >=20 > Would you be OK with an exception for this extremely unusual > situation? >=20 > > >- Fixing some instructions syntax in those .asm files, in order to mak= e > > > them palatable for MSFT. > > >- Fixing some minor formatting issue in INF files, while we're at it. > > > > > >This set enables the assembler, meanwhile the C also require changes, > > >which will come in a set later. This set makes the RVCT toolchain fami= ly > > >and profiles obsolete, unblocking : > > >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1750 > > > > With this change, can we continue to work on BZ 1750? >=20 > Yes. >=20 > / > Leif >=20 > > >As mentioned in the above bug, dropping RVCT would entail orphanating > > >the .asm files that powered the RVCT build. Since Visual Studio uses t= he > > >same file syntax, those can be reused to power the VS build. > > > > > >These patches have been tested on VS2019 (v15.9.11) and VS2017 (v16.0.= 1) > > > > Do you mean you verify this change with new VS2019 tool chain? > > > > Thanks > > Liming > > > > > >Baptiste GERONDEAU (3): > > > ArmPkg/MdePkg : Unify INF files format > > > ARM/Assembler: Correct syntax from RVCT for MSFT > > > ARM/Assembler: Reuse RVCT assembler for MSFT build > > > > > > ArmPkg/Drivers/ArmGic/ArmGicLib.inf = | 2 +- > > > ArmPkg/Library/ArmExceptionLib/Arm/ExceptionSupport.asm = | 30 > > >+++++++++++++++++------------- > > > ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.inf = | 2 +- > > > ArmPkg/Library/ArmExceptionLib/ArmRelocateExceptionLib.inf = | 2 +- > > > ArmPkg/Library/ArmHvcLib/ArmHvcLib.inf = | 2 +- > > > ArmPkg/Library/ArmLib/Arm/ArmV7Support.asm = | 6 ++++-- > > > ArmPkg/Library/ArmLib/ArmBaseLib.inf = | 8 ++++---- > > > ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf = | 4 ++-- > > > ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf = | 2 +- > > > ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf > > >| 2 +- > > > ArmPkg/Library/ArmSvcLib/ArmSvcLib.inf = | 2 +- > > > ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf = | 2 +- > > > ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf = | 2 > > >+- > > > ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf = | 6 +++--- > > > ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf = | 6 +++--- > > > ArmPlatformPkg/PrePi/PeiMPCore.inf = | 2 +- > > > ArmPlatformPkg/PrePi/PeiUniCore.inf = | 2 +- > > > MdePkg/Library/BaseIoLibIntrinsic/Arm/ArmVirtMmio.asm = | 18 > > >+++++++++--------- > > > MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicArmVirt.inf = | 2 +- > > > MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf = | > > >20 ++++++++++---------- > > > MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf = | 2 +- > > > 21 files changed, 65 insertions(+), 59 deletions(-) > > > > > >-- > > >2.23.0 > >