From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: liming.gao@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Thu, 19 Sep 2019 07:56:56 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Sep 2019 07:56:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,523,1559545200"; d="scan'208";a="181493108" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga008.jf.intel.com with ESMTP; 19 Sep 2019 07:56:55 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 19 Sep 2019 07:56:55 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 19 Sep 2019 07:56:54 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.92]) with mapi id 14.03.0439.000; Thu, 19 Sep 2019 22:56:52 +0800 From: "Liming Gao" To: Leif Lindholm CC: "Gao, Zhichao" , "devel@edk2.groups.io" , Andrew Fish , Laszlo Ersek , "Kinney, Michael D" , "Ni, Ray" , Ard Biesheuvel Subject: Re: [PATCH] Edk2: Add Zhichao as the maintainer for shellbin relase Thread-Topic: [PATCH] Edk2: Add Zhichao as the maintainer for shellbin relase Thread-Index: AQHVbq1+3TPbr3KI6k6xCMdHdg3wFqcygRGw//+xsoCAANezUP//ggoAgACKfQA= Date: Thu, 19 Sep 2019 14:56:51 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FEBEC@SHSMSX104.ccr.corp.intel.com> References: <20190919054531.8176-1-zhichao.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FE60A@SHSMSX104.ccr.corp.intel.com> <20190919091753.GM28454@bivouac.eciton.net> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FEA2C@SHSMSX104.ccr.corp.intel.com> <20190919143904.GY28454@bivouac.eciton.net> In-Reply-To: <20190919143904.GY28454@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2ZhNmJmNGMtZWVhZS00NTZiLWIwODAtYmU3YTc5ZmJhNTI5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWlJ3TEIwNHUzMDNhYzVOQitzM2lmUHBlV1lWM0xMc3duU0lOTDNKQnhSYlFTTVNBK2xhSTBpZzlzVGxUVU9LcSJ9 dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif: > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Thursday, September 19, 2019 10:39 PM > To: Gao, Liming > Cc: Gao, Zhichao ; devel@edk2.groups.io; Andrew Fi= sh ; Laszlo Ersek ; > Kinney, Michael D ; Ni, Ray ; Ard Biesheuvel > Subject: Re: [PATCH] Edk2: Add Zhichao as the maintainer for shellbin rel= ase >=20 > On Thu, Sep 19, 2019 at 02:16:44PM +0000, Gao, Liming wrote: > > Leif: > > > > > -----Original Message----- > > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > > Sent: Thursday, September 19, 2019 5:18 PM > > > To: Gao, Liming > > > Cc: Gao, Zhichao ; devel@edk2.groups.io; Andre= w Fish ; Laszlo Ersek > ; > > > Kinney, Michael D ; Ni, Ray ; Ard Biesheuvel > > > Subject: Re: [PATCH] Edk2: Add Zhichao as the maintainer for shellbin= relase > > > > > > I have no objection to this addition, but I do have two questions - a= nd > > > really I realise this is a follow-on for 81a8a52a6bb21 ("ShellBinPkg= : > > > Remove ShellBinPkg"): > > > > > > 1) Since ShellBinPkg no longer exists, what is the intent of listing > > > this in the Maintainers.txt file? Generally, this is so that peopl= e > > > know who to Cc: on patches - but there will not be any patches her= e. > > > > Here is the info who can be contacted to generate the binary files > > for the quarter stable tag. >=20 > I agree this is important to keep somewhere. But I am unsure if > Maintainers.txt is the location for that. Clearly it was when > ShellBinPkg existed, but I am not sure now. >=20 > And yes, this is something I should have realised when ShellBinPkg was > removed - but I didn't at that point. So there is no need to hold > back this patch. >=20 OK. This patch can be pushed first.=20 > But I think it would make possibly more sense to add this information > either into a ShellPkg/Readme.md or the wiki. If we keep the > information in Maintainers.txt, I would suggest creating a new > section below "EDK II Releases:" with a W: entry pointing somewhere. I will take your suggestion to move this info to EDK II Releases: section i= n Maintainers.txt. I will send another patch for this change.=20 Thanks Liming >=20 > Best Regards, >=20 > Leif >=20 > > > 2) If Zhichao is now responsible for this, should Jaben and Ray still > > > be listed? > > > > > I think Jaben and Ray can be removed. > > > > Thanks > > Liming > > > Best Regards, > > > > > > Leif > > > > > > On Thu, Sep 19, 2019 at 05:58:16AM +0000, Gao, Liming wrote: > > > > Reviewed-by: Liming Gao > > > > > > > > >-----Original Message----- > > > > >From: Gao, Zhichao > > > > >Sent: Thursday, September 19, 2019 1:46 PM > > > > >To: devel@edk2.groups.io > > > > >Cc: Andrew Fish ; Laszlo Ersek ; Leif > > > > >Lindholm ; Kinney, Michael D > > > > >; Ni, Ray ; Ard Bies= heuvel > > > > >; Gao, Liming > > > > >Subject: [PATCH] Edk2: Add Zhichao as the maintainer for shellbin = relase > > > > > > > > > >Zhichao is responsible for the IA32 and X64 ARCH shell binary gene= ration. > > > > > > > > > >Cc: Andrew Fish > > > > >Cc: Laszlo Ersek > > > > >Cc: Leif Lindholm > > > > >Cc: Michael D Kinney > > > > >Cc: Ray Ni > > > > >Cc: Ard Biesheuvel > > > > >Cc: Liming Gao > > > > >Signed-off-by: Zhichao Gao > > > > >--- > > > > > Maintainers.txt | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > >diff --git a/Maintainers.txt b/Maintainers.txt > > > > >index dcf81c737a..a0121123ec 100644 > > > > >--- a/Maintainers.txt > > > > >+++ b/Maintainers.txt > > > > >@@ -426,6 +426,7 @@ Maintainers for stable Shell binaries generati= on > > > > > when need to publish Shell binaries with edk2 release: > > > > > M: Jaben Carsey (Ia32/X64) > > > > > M: Ray Ni (Ia32/X64) > > > > >+M: Zhichao Gao (Ia32/X64) > > > > > M: Leif Lindholm (ARM/AArch64) > > > > > M: Ard Biesheuvel (ARM/AArch64) > > > > > > > > > >-- > > > > >2.21.0.windows.1 > > > >