From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: liming.gao@intel.com)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by groups.io with SMTP; Mon, 23 Sep 2019 17:44:49 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga006.jf.intel.com ([10.7.209.51])
  by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Sep 2019 17:44:48 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,542,1559545200"; 
   d="scan'208";a="193271685"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
  by orsmga006.jf.intel.com with ESMTP; 23 Sep 2019 17:44:48 -0700
Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 23 Sep 2019 17:44:48 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 23 Sep 2019 17:44:47 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.92]) with mapi id 14.03.0439.000;
 Tue, 24 Sep 2019 08:44:45 +0800
From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Cheng, Ching JenX"
	<ching.jenx.cheng@intel.com>
Subject: Re: [edk2-devel] [PATCH v3 0/2] *** Add VS2019 Support ***
Thread-Topic: [edk2-devel] [PATCH v3 0/2] *** Add VS2019 Support ***
Thread-Index: AQHVbseW0pnn9HaTJEmizH5BoKYV1acys9jg
Date: Tue, 24 Sep 2019 00:44:45 +0000
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E5004A4@SHSMSX104.ccr.corp.intel.com>
References: <20190919085226.15500-1-ching.jenx.cheng@intel.com>
In-Reply-To: <20190919085226.15500-1-ching.jenx.cheng@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: liming.gao@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Push 6b80310f34199d1f62e45e40fa902734735091fa..670c903a68f214463f12c0c9619c=
162a0f342518

You can update BZ 2182 and close it.=20

Thanks
Liming
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Cheng, Ching JenX
>Sent: Thursday, September 19, 2019 4:52 PM
>To: devel@edk2.groups.io
>Subject: [edk2-devel] [PATCH v3 0/2] *** Add VS2019 Support ***
>
>REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2182
>
>In order to support VS2019 on EDK2, the following patches was modified de=
f
>and batch files
>1. Add VS2019 x86/64 definitions on tools_def.template
>2. Add VS2019 support on toolsetup batches, and add version check with
>command vswhere
>     Because VS2019 and VS2017 using the same vswhere to get the
>InstallationPath
>
>v2: In 01/02, add ARM/AARCH64/EBC Definitions, Combine VS2017_HOST and
>VS2019_HOST to VS_HOST
>v3: In 02/02, In BaseTools\set_vsprefix_envs.bat,
>    move WINSDK10_PREFIX setting into VCToolsInstallDir check condition.
>
>Ching JenX Cheng (2):
>  Add VS2019 Toolchain def
>  Add VS2019 Support on ToolSetup Batches
>
> BaseTools/Conf/tools_def.template | 220
>+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>++++++++++++++++++++++++-------------------
> BaseTools/get_vsvars.bat          |  37 ++++++++++++++++++++++++++++++--=
-
>----
> BaseTools/set_vsprefix_envs.bat   |  86
>+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>++++++++++++++-------------
> BaseTools/toolsetup.bat           |  16 +++++++++++++---
> edksetup.bat                      |   6 ++++--
> 5 files changed, 321 insertions(+), 44 deletions(-)
>
>--
>2.21.0.windows.1
>
>
>