From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: liming.gao@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Tue, 24 Sep 2019 17:37:38 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2019 17:37:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,546,1559545200"; d="scan'208";a="203497833" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 24 Sep 2019 17:37:37 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Sep 2019 17:37:36 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Sep 2019 17:37:37 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.195]) with mapi id 14.03.0439.000; Wed, 25 Sep 2019 08:37:35 +0800 From: "Liming Gao" To: Leif Lindholm , "devel@edk2.groups.io" CC: "Kinney, Michael D" Subject: Re: [edk2-devel] [Patch] MdePkg Base.h: Define STATIC_ASSERT macro as empty for EBC arch Thread-Topic: [edk2-devel] [Patch] MdePkg Base.h: Define STATIC_ASSERT macro as empty for EBC arch Thread-Index: AQHVczaqjhDuJhg3jES386U0sF7sFKc7izYA Date: Wed, 25 Sep 2019 00:37:35 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E500FB4@SHSMSX104.ccr.corp.intel.com> References: <20190924150519.10304-1-liming.gao@intel.com> <20190925001750.GP28454@bivouac.eciton.net> In-Reply-To: <20190925001750.GP28454@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Lefi: Thanks for your comment. I will update the patch when submit it.=20 Thanks Liming >-----Original Message----- >From: Leif Lindholm [mailto:leif.lindholm@linaro.org] >Sent: Wednesday, September 25, 2019 8:18 AM >To: devel@edk2.groups.io; Gao, Liming >Cc: Kinney, Michael D >Subject: Re: [edk2-devel] [Patch] MdePkg Base.h: Define STATIC_ASSERT >macro as empty for EBC arch > >On Tue, Sep 24, 2019 at 11:05:19PM +0800, Liming Gao wrote: >> EBC compiler doesn't support C11 static_assert macro. >> So, define STATIC_ASSERT as empty to pass EBC arch build. >> STATIC_ASSERT macro is introduced >@204ae9da230ecbf0910c21acac7aa5d5e8cbb8d0 >> >> Cc: Michael D Kinney >> Signed-off-by: Liming Gao >> --- >> MdePkg/Include/Base.h | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h >> index ed85b98318..70e4d8daf1 100644 >> --- a/MdePkg/Include/Base.h >> +++ b/MdePkg/Include/Base.h >> @@ -799,12 +799,15 @@ typedef UINTN *BASE_LIST; >> @param Message Raised compiler diagnostic message when expressi= on >is false. >> >> **/ >> -#ifdef _MSC_EXTENSIONS >> +#ifdef MDE_CPU_EBC >> + #define STATIC_ASSERT(Expression, Message) >> +#elif _MSC_EXTENSIONS >> #define STATIC_ASSERT static_assert >> #else >> #define STATIC_ASSERT _Static_assert >> #endif >> >> + > >Please delete this spurious added blank line. >With that: >Reviewed-by: Leif Lindholm > >> // >> // Verify that ProcessorBind.h produced UEFI Data Types that are compl= iant >with >> // Section 2.3.1 of the UEFI 2.3 Specification. >> -- >> 2.13.0.windows.1 >> >> >>=20 >>