public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "Fan, ZhijuX" <zhijux.fan@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [PATCH] BaseTools:"--exclude" don't apply if parameter ends with separator
Date: Thu, 26 Sep 2019 15:28:15 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E502158@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <FAD0D7E0AE0FA54D987F6E72435CAFD50AFBDC08@SHSMSX101.ccr.corp.intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Fan, ZhijuX <zhijux.fan@intel.com>
> Sent: Thursday, September 19, 2019 3:45 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
> Subject: [PATCH] BaseTools:"--exclude" don't apply if parameter ends with separator
> 
> 
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1944
> 
> FormatDosFiles.py Intel\ServerSiliconPkg --exclude Library\SimRegisters\
> 
> Its parameter "Library\SimRegisters\" ends with '\'
> but I can't seem to get it to exclude the SimRegisters directory
> 
> This patch is going to fix this issue
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
> ---
>  BaseTools/Scripts/FormatDosFiles.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/BaseTools/Scripts/FormatDosFiles.py b/BaseTools/Scripts/FormatDosFiles.py
> index 3150bef3c2..e119334ded 100644
> --- a/BaseTools/Scripts/FormatDosFiles.py
> +++ b/BaseTools/Scripts/FormatDosFiles.py
> @@ -53,6 +53,7 @@ def FormatFilesInDir(DirPath, ExtList, Args):
>              FileNames[:] = [f for f in FileNames if f not in Args.Exclude]
>              Continue = False
>              for Path in Args.Exclude:
> +                Path = Path.strip('\\').strip('/')
>                  if not os.path.isdir(Path) and not os.path.isfile(Path):
>                      Path = os.path.join(ExcludeDir, Path)
>                  if os.path.isdir(Path) and Path.endswith(DirPath):
> --
> 2.14.1.windows.1


      reply	other threads:[~2019-09-26 15:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-19  7:45 [PATCH] BaseTools:"--exclude" don't apply if parameter ends with separator Fan, ZhijuX
2019-09-26 15:28 ` Liming Gao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E502158@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox