From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: liming.gao@intel.com)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by groups.io with SMTP; Fri, 27 Sep 2019 00:50:57 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
  by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2019 00:50:57 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,554,1559545200"; 
   d="scan'208";a="190240763"
Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204])
  by fmsmga007.fm.intel.com with ESMTP; 27 Sep 2019 00:50:56 -0700
Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by
 FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Fri, 27 Sep 2019 00:50:56 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by
 SHSMSX154.ccr.corp.intel.com ([169.254.7.195]) with mapi id 14.03.0439.000;
 Fri, 27 Sep 2019 15:50:54 +0800
From: "Liming Gao" <liming.gao@intel.com>
To: "Ni, Ray" <ray.ni@intel.com>, "Gao, Zhichao" <zhichao.gao@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
CC: "Wang, Jian J" <jian.j.wang@intel.com>, "Wu, Hao A" <hao.a.wu@intel.com>
Subject: Re: [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support
Thread-Topic: [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys
 support
Thread-Index: AQHVdNAbtpt3I+5FbEa1vRab9FvFsqc+MXQAgAD1dCA=
Date: Fri, 27 Sep 2019 07:50:53 +0000
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E50286D@SHSMSX104.ccr.corp.intel.com>
References: <20190927010831.25944-1-zhichao.gao@intel.com>
 <734D49CCEBEEF84792F5B80ED585239D5C2F3E9C@SHSMSX104.ccr.corp.intel.com>
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C2F3E9C@SHSMSX104.ccr.corp.intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: liming.gao@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Push @e86664d2b03d0a84b8b952f3d5111424b3e9c916

>-----Original Message-----
>From: Ni, Ray
>Sent: Friday, September 27, 2019 9:12 AM
>To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
>Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>;
>Gao, Liming <liming.gao@intel.com>
>Subject: RE: [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow
>keys support
>
>Reviewed-by: Ray Ni <ray.ni@intel.com>
>
>> -----Original Message-----
>> From: Gao, Zhichao <zhichao.gao@intel.com>
>> Sent: Thursday, September 26, 2019 6:09 PM
>> To: devel@edk2.groups.io
>> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
><hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao, Liming
>> <liming.gao@intel.com>
>> Subject: [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys
>support
>>
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2219
>>
>> First previous patch remove the VT100Plus's arrow keys' support.
>> Add it back.
>>
>> The arrow keys would send ESC [A through to ESC [D. Add this
>> support for the new introduced terminal type.
>>
>> Cc: Jian J Wang <jian.j.wang@intel.com>
>> Cc: Hao A Wu <hao.a.wu@intel.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
>> ---
>>  .../Universal/Console/TerminalDxe/TerminalConIn.c         | 8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git
>a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c
>> b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c
>> index ac31f27984..f8c71f95c1 100644
>> --- a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c
>> +++ b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c
>> @@ -1670,8 +1670,12 @@ UnicodeToEfiKey (
>>
>>        if (TerminalDevice->TerminalType =3D=3D TerminalTypePcAnsi    ||
>>            TerminalDevice->TerminalType =3D=3D TerminalTypeVt100     ||
>> -          TerminalDevice->TerminalType =3D=3D TerminalTypeVtUtf8 ||
>> -          TerminalDevice->TerminalType =3D=3D TerminalTypeTtyTerm ||
>> +          TerminalDevice->TerminalType =3D=3D TerminalTypeVt100Plus ||
>> +          TerminalDevice->TerminalType =3D=3D TerminalTypeVtUtf8    ||
>> +          TerminalDevice->TerminalType =3D=3D TerminalTypeTtyTerm   ||
>> +          TerminalDevice->TerminalType =3D=3D TerminalTypeLinux     ||
>> +          TerminalDevice->TerminalType =3D=3D TerminalTypeXtermR6   ||
>> +          TerminalDevice->TerminalType =3D=3D TerminalTypeVt400     ||
>>            TerminalDevice->TerminalType =3D=3D TerminalTypeSCO) {
>>          switch (UnicodeChar) {
>>          case 'A':
>> --
>> 2.21.0.windows.1