Re: [edk2-devel] [Patch 1/1] BaseTools: Fix the lib order in static_library_files.lst

["Liming Gao" <liming.gao@intel.com>]

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Bob Feng
>Sent: Friday, September 27, 2019 7:35 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; dann frazier
><dann.frazier@canonical.com>; Feng, Bob C <bob.c.feng@intel.com>
>Subject: [edk2-devel] [Patch 1/1] BaseTools: Fix the lib order in
>static_library_files.lst
>
>Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2216
>
>This patch is going to fix the lib order in static_library_files.lst.
>This issue is introduced by commit 673d09a2dd.
>Before 673d09a2dd, build tool apply build rule for the module's library
>firstly and then apply build rule for module itself. Now, build tool
>apply build rule for module self and then for its library. That behavior
>impact the lib order in static_library_files.lst.
>
>This patch is to call module's LibraryAutoGenList function
>explicitly, where the applying build rule action for
>library is triggered.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: dann frazier <dann.frazier@canonical.com>
>Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>---
> BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
>b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
>index fad5bab0f24d..f0812b6887be 100755
>--- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
>+++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
>@@ -1841,11 +1841,11 @@ class ModuleAutoGen(AutoGen):
>                 LibraryAutoGen.CreateCodeFile()
>
>         # CanSkip uses timestamps to determine build skipping
>         if self.CanSkip():
>             return
>-
>+        self.LibraryAutoGenList
>         AutoGenList = []
>         IgoredAutoGenList = []
>
>         for File in self.AutoGenFileList:
>             if GenC.Generate(File.Path, self.AutoGenFileList[File], File.IsBinary):
>--
>2.20.1.windows.1
>
>
>