From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: liming.gao@intel.com)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by groups.io with SMTP; Sat, 28 Sep 2019 20:33:55 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
  by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Sep 2019 20:33:55 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,561,1559545200"; 
   d="scan'208";a="180971829"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
  by orsmga007.jf.intel.com with ESMTP; 28 Sep 2019 20:33:54 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Sat, 28 Sep 2019 20:33:54 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.166]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.96]) with mapi id 14.03.0439.000;
 Sun, 29 Sep 2019 11:33:52 +0800
From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Feng, Bob C"
	<bob.c.feng@intel.com>
CC: dann frazier <dann.frazier@canonical.com>
Subject: Re: [edk2-devel] [Patch 1/1] BaseTools: Fix the lib order in static_library_files.lst
Thread-Topic: [edk2-devel] [Patch 1/1] BaseTools: Fix the lib order in
 static_library_files.lst
Thread-Index: AQHVdSetsgiyozaBrE6Veq7adKuwWadCAxYQ
Date: Sun, 29 Sep 2019 03:33:51 +0000
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E50CEFA@SHSMSX104.ccr.corp.intel.com>
References: <20190927113523.25424-1-bob.c.feng@intel.com>
In-Reply-To: <20190927113523.25424-1-bob.c.feng@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: liming.gao@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Bob Feng
>Sent: Friday, September 27, 2019 7:35 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; dann frazier
><dann.frazier@canonical.com>; Feng, Bob C <bob.c.feng@intel.com>
>Subject: [edk2-devel] [Patch 1/1] BaseTools: Fix the lib order in
>static_library_files.lst
>
>Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2216
>
>This patch is going to fix the lib order in static_library_files.lst.
>This issue is introduced by commit 673d09a2dd.
>Before 673d09a2dd, build tool apply build rule for the module's library
>firstly and then apply build rule for module itself. Now, build tool
>apply build rule for module self and then for its library. That behavior
>impact the lib order in static_library_files.lst.
>
>This patch is to call module's LibraryAutoGenList function
>explicitly, where the applying build rule action for
>library is triggered.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: dann frazier <dann.frazier@canonical.com>
>Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>---
> BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
>b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
>index fad5bab0f24d..f0812b6887be 100755
>--- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
>+++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
>@@ -1841,11 +1841,11 @@ class ModuleAutoGen(AutoGen):
>                 LibraryAutoGen.CreateCodeFile()
>
>         # CanSkip uses timestamps to determine build skipping
>         if self.CanSkip():
>             return
>-
>+        self.LibraryAutoGenList
>         AutoGenList =3D []
>         IgoredAutoGenList =3D []
>
>         for File in self.AutoGenFileList:
>             if GenC.Generate(File.Path, self.AutoGenFileList[File], File=
.IsBinary):
>--
>2.20.1.windows.1
>
>
>