From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: liming.gao@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Sun, 29 Sep 2019 00:45:50 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Sep 2019 00:45:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,562,1559545200"; d="scan'208";a="197194742" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 29 Sep 2019 00:45:50 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 29 Sep 2019 00:45:50 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 29 Sep 2019 00:45:49 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.166]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.119]) with mapi id 14.03.0439.000; Sun, 29 Sep 2019 15:45:47 +0800 From: "Liming Gao" To: "Wu, Hao A" , "devel@edk2.groups.io" , "Zurcher, Christopher J" CC: "Kinney, Michael D" , "Yao, Jiewen" , "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH v8 0/4] Add SCSI Support for Storage Security Command Protocol Thread-Topic: [edk2-devel] [PATCH v8 0/4] Add SCSI Support for Storage Security Command Protocol Thread-Index: AQHVdNoVuowsjip5v0q/YjQ6DkyoNKdBv9OAgACKCEA= Date: Sun, 29 Sep 2019 07:45:46 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E50E0BA@SHSMSX104.ccr.corp.intel.com> References: <20190927022000.36920-1-christopher.j.zurcher@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I have no other comments. Reviewed-by: Liming Gao >-----Original Message----- >From: Wu, Hao A >Sent: Sunday, September 29, 2019 3:31 PM >To: devel@edk2.groups.io; Zurcher, Christopher J >; Gao, Liming >Cc: Kinney, Michael D ; Yao, Jiewen >; Wang, Jian J >Subject: RE: [edk2-devel] [PATCH v8 0/4] Add SCSI Support for Storage >Security Command Protocol > >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Zurcher, Christopher J >> Sent: Friday, September 27, 2019 10:20 AM >> To: devel@edk2.groups.io >> Cc: Kinney, Michael D; Yao, Jiewen; Wang, Jian J; Gao, Liming; Wu, Hao = A >> Subject: [edk2-devel] [PATCH v8 0/4] Add SCSI Support for Storage Secur= ity >> Command Protocol >> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1546 >> >> V8 changes: >> Align Inc512 definition in UefiScsiLib.h with that in UefiScsiLib.c. >> >> V7 changes: >> Changed Inc512 behavior to always take DataLength as bytes, and divide >> by 512 only in the CDB. >> >> V6 changes: >> Restore EFI_SCSI_TYPE defines for ASC IT8 devices. Revert >EFI_SCSI_IO_TYPE >> changes in Protocol\ScsiIo.h. Add INC_512 parameter for SecurityProtoco= l >> In/Out commands in UefiScsiLib. Change UINT32 args to UINTN to match th= e >> definitions for Storage Security Command Protocol. >> >> V5 changes: >> Split MdeModulePkg changes into separate patches. Add ReinstallProtocol >> calls for StorageSecurityCommand Protocol. Restore original MediaPresen= t >> and ReadCapacity behavior, with new implementation for WLUN type media. >> Clear temporary aligned buffers before freeing them. >> >> V4 changes: >> Add SSC Protocol in addition to BlockIo instead of in place of BlockIo. >> Add error handling for (BlockSize =3D=3D 0) in Read and WriteBlocks com= mands >> to handle partitions that do not support ReadCapacity(). >> >> V3 changes: >> Initialize AlignedBuffer variable in ScsiDiskReceiveData and >> ScsiDiskSendData functions. Remove redundant input validation and debug >> message in ScsiDiskSendData. >> >> V2 changes: >> Split the patch into separate commits for separate packages. >> >> To support RPMB access on UFS devices, support must be added to >> the ScsiDiskDxe driver for the Storage Security Command Protocol. >> >> Cc: Michael D Kinney >> Cc: Jiewen Yao >> Cc: Jian J Wang >> Cc: Liming Gao >> Cc: Hao A Wu >> >> Christopher J Zurcher (4): >> MdePkg: Implement SCSI commands for Security Protocol In/Out > > >For patch 1, >Reviewed-by: Hao A Wu > >Hello Liming, >Do you have additional comment on the patch? > > >> MdeModulePkg/UfsPassThruDxe: Check for RPMB W-LUN (SecurityLun) >> MdeModulePkg/ScsiBusDxe: Clean up Peripheral Type check >> MdeModulePkg/ScsiDiskDxe: Support Storage Security Command Protocol > > >Since the MdeModulePkg part is the same with V6 series, thus: >Reviewed-by: Hao A Wu > >Best Regards, >Hao Wu > > >> >> MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf | 3 +- >> MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 171 +++++- >> MdePkg/Include/IndustryStandard/Scsi.h | 48 +- >> MdePkg/Include/Library/UefiScsiLib.h | 130 ++++- >> MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 5 +- >> MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 616 >> +++++++++++++++++++- >> MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 17 +- >> MdePkg/Library/UefiScsiLib/UefiScsiLib.c | 229 +++++++- >> 8 files changed, 1181 insertions(+), 38 deletions(-) >> >> -- >> 2.16.2.windows.1 >> >> >>=20