From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"lersek@redhat.com" <lersek@redhat.com>,
"Ni, Ray" <ray.ni@intel.com>, "pete@akeo.ie" <pete@akeo.ie>
Cc: "Gao, Zhichao" <zhichao.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0
Date: Tue, 8 Oct 2019 14:11:31 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E512458@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <ff56abeb-03da-e9a9-b477-3f7dae612838@redhat.com>
Push @2de1f611be06ded3a59726a4052a9039be7d459b
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek
> Sent: Tuesday, October 1, 2019 7:12 AM
> To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; pete@akeo.ie
> Cc: Gao, Zhichao <zhichao.gao@intel.com>
> Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0
>
> On 09/30/19 03:24, Ni, Ray wrote:
> > Existing close source platform BDS only updates UI in this function.
> > Reviewed-by: Ray Ni <ray.ni@intel.com>
>
> Thanks, Ray! Can you please push this patch for Pete?
>
> Thanks
> Laszlo
>
> >
> >> -----Original Message-----
> >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Pete Batard
> >> Sent: Wednesday, September 25, 2019 11:50 PM
> >> To: devel@edk2.groups.io
> >> Cc: Gao, Zhichao <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> >> Subject: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0
> >>
> >> The existing loop is set to call PlatformBootManagerWaitCallback every
> >> second except the last one. We believe this is a mistake as it prevents
> >> the called code from performing timeout expiration tasks such as, for
> >> instance, ensuring that the last segment of a progress bar is displayed
> >> before continuing (which is a current issue for the RPi3 platform).
> >>
> >> Signed-off-by: Pete Batard <pete@akeo.ie>
> >> ---
> >> MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
> >> index f3d5e5ac0615..7968a58f3454 100644
> >> --- a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
> >> +++ b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
> >> @@ -341,6 +341,7 @@ BdsWait (
> >> TimeoutRemain--;
> >> }
> >> }
> >> + PlatformBootManagerWaitCallback (0);
> >> DEBUG ((EFI_D_INFO, "[Bds]Exit the waiting!\n"));
> >> }
> >>
> >> --
> >> 2.21.0.windows.1
> >>
> >>
> >>
> >
> >
> >
> >
>
>
>
prev parent reply other threads:[~2019-10-08 14:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 15:50 [PATCH 1/1] MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0 Pete Batard
2019-09-26 19:30 ` [edk2-devel] " Laszlo Ersek
2019-09-29 7:39 ` Liming Gao
2019-09-30 1:24 ` Ni, Ray
2019-09-30 23:12 ` Laszlo Ersek
2019-10-08 14:11 ` Liming Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E512458@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox