From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.5708.1571404918579851446 for ; Fri, 18 Oct 2019 06:21:58 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Oct 2019 06:21:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,311,1566889200"; d="scan'208";a="397933792" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 18 Oct 2019 06:21:57 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 18 Oct 2019 06:21:57 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 18 Oct 2019 06:21:57 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.166]) by SHSMSX151.ccr.corp.intel.com ([10.239.6.50]) with mapi id 14.03.0439.000; Fri, 18 Oct 2019 21:21:55 +0800 From: "Liming Gao" To: 'Leif Lindholm' , "devel@edk2.groups.io" CC: "Yao, Jiewen" , "Shi, Steven" , "Justen, Jordan L" , Laszlo Ersek , Andrew Fish , "Ni, Ray" , Ard Biesheuvel , "Wang, Jian J" , "Wu, Hao A" , "Feng, Bob C" , "Kinney, Michael D" Subject: Re: [edk2-devel] [Patch v3 00/11] New Cross OS tool chain CLANG9 Thread-Topic: [edk2-devel] [Patch v3 00/11] New Cross OS tool chain CLANG9 Thread-Index: AQHVhQg9mV/kigbUVEWNzq3+In2tY6df+vng Date: Fri, 18 Oct 2019 13:21:55 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E51EC05@SHSMSX104.ccr.corp.intel.com> References: <1571295356-11608-1-git-send-email-liming.gao@intel.com> <20191017163051.GX25504@bivouac.eciton.net> In-Reply-To: <20191017163051.GX25504@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzc5ZGZjOWUtZmQ0NC00MGNiLThmMzYtMzAwZDgwOWU1ODNiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoia3hNRHZCOTUrUkk5SVlBcWpudjdhXC9BVEdibW85eGVIVGlPaEJoTVk2aDNnVTRDc0NTYVAyQlVFMjNcL0kxeGZwIn0= dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif: >-----Original Message----- >From: Leif Lindholm [mailto:leif.lindholm@linaro.org] >Sent: Friday, October 18, 2019 12:31 AM >To: devel@edk2.groups.io; Gao, Liming >Cc: Yao, Jiewen ; Shi, Steven >; Justen, Jordan L ; Las= zlo >Ersek ; Andrew Fish ; Ni, Ray >; Ard Biesheuvel ; Wang, Jia= n >J ; Wu, Hao A ; Feng, Bob C >; Kinney, Michael D >Subject: Re: [edk2-devel] [Patch v3 00/11] New Cross OS tool chain CLANG9 > >Hi Liming, > >I had missed that this set was out for review (I would appreciate a cc >on any future revisions). Yes.=20 > >On Thu, Oct 17, 2019 at 02:55:44PM +0800, Liming Gao wrote: >> In v3, add the detail commit message for patch 3. >> Update the fix in EmulatorPkg based on the comments. >> >> In v2, drop patch 12, and update commit message for 5 & 11. >> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1603 >> Code: https://github.com/lgao4/edk2/tree/CLANG9 > >This branch does not appear to have been updated since 5 September, so >it does not contain the version of the code sent out in this set. (And >I can find no other obvious branch in that repository that may hold >it.) Could you push an updated one please? > Done Code: https://github.com/lgao4/edk2/tree/CLANG9_v3 >One thing that strikes me as problematic with the version on the >branch is that the set imports bits from GCC48 *and* GCC5. That seems >like a maintenance hazard, but may no longer be the case for the >current version of the set? > CLANG9 tool chain refers to CLANG38 tool chain. So, it refers to GCC48 and= GCC5 flags. 1. CLANG9 CC flags reuses GCC48_ALL_CC_FLAGS. GCC48_ALL_CC_FLAGS is common= GCC flags=20 for GCC48, GCC49, GCC5 and CLANG38. So, I think it is fine to reuse it in = new CLANG9 tool chain.=20 2. CLANG9 ASM_FLAGS reuses GCC5_ASM_FLAGS. It is same to common GCC_ASM_FL= AGS. I=20 Can use GCC_ASM_FLAGS.=20 Thanks Liming >Best Regards, > >Leif > >> Wiki: https://github.com/lgao4/edk2/wiki/CLANG9-Tools-Chain >> >> CLANG9 tool chain is added to directly generate PE/COFF image (EFI imag= e). >> This tool chain uses LLVM clang C compiler and lld linker, generates PE= /COFF >> image and PDB compatible debug symbol format. Now, it supports IA32/X64 >Archs. >> It must use LLVM 9 or above release. LLVM 9 is ready on >> http://releases.llvm.org/download.html#9.0.0. >> >> CLANG9 is the cross OS tool chain. It can work on Windows/Linux/Mac hos= t >OS. >> For the same source code, with the same version LLVM tool chain, >> CLANG9 can generate the same binary image. So, the developer can >> choose the different development environment and work on the same >> code base. Besides, EDKII project build also requires third party >> tools: nasm and iasl. They both keep the same version. If so, the same >> binary image can be generated on the different host OS. >> >> LLVM tool chain provides the compiler and linker. To build EDK2 project= , >> some other tools are still required. On Windows OS, nmake and Visual >Studio >> are required to call Makefile and compile BaseTools C tools. >> On Linux/Mac, binutils and gcc are required to make and compile BaseToo= ls >> C tools. Because VS or GCC are mainly used to compile BaseTools and >provide >> nmake/make tool, they can keep on the stable version without update. >> >> To build source code, CLANG9 tool chain (-t CLANG9) can be specified >> on Windows OS, set CLANG_HOST_BIN=3Dn, set CLANG9_BIN=3DLLVM installed >directory >> CLANG_HOST_BIN is used CLANG_HOST_PREFIX. Prefix n is for nmake. >> For example: >> * set CLANG_HOST_BIN=3Dn >> * set CLANG9_BIN=3DC:\Program Files\LLVM\bin\ >> * set IASL_PREFIX=3DC:\Asl\ >> >> On Linux/Mac, export CLANG9_BIN=3DLLVM installed directory, >CLANG_HOST_BIN is >> not required, because there is no prefix for make. >> For example: >> * export CLANG9_BIN=3D/home/clang9/bin/ >> >> Now, CLANG9 tool chain has been verified in Edk2 packages and >Ovmf/Emulator >> with LLVM 9.0.0 on Windows and Linux OS. >> OVMF IA32/X64/IA32X64 all boots to Shell on Windows and Linux OS. >> Emulator can boot to Shell on Windows only with CLANG9. >> OVMF Ia32X64 RELEASE build generates the same BIOS images on Windows >and Linux OS. >> >> Cc: Jiewen Yao >> Cc: Steven Shi >> Cc: Jordan Justen >> Cc: Laszlo Ersek >> Cc: Andrew Fish >> Cc: Ray Ni >> Cc: Ard Biesheuvel >> Cc: Jian J Wang >> Cc: Hao A Wu >> Cc: Bob Feng >> Cc: Michael D Kinney >> >> Liming Gao (11): >> BaseTools tools_def.template: Remove unnecessary $(DEST_DIR_DEBUG) >> path >> BaseTools tools_def: Add CLANG9 tool chain to directly generate PE >> image >> BaseTools GenFw: Fix the issue to update the wrong size as SectionSiz= e >> MdePkg Base.h: Add definition for CLANG9 tool chain >> MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO >> functions >> MdeModulePkg LzmaCustomDecompressLib: Update macro to be same in >CLANG >> tool >> MdeModulePkg RegularExpressionDxe: Disable warning for CLANG9 tool >> chain >> CryptoPkg: Append options to make CLANG9 tool chain pass build >> CryptoPkg IntrinsicLib: Make _fltused always be used >> EmulatorPkg: Enable CLANG9 tool chain >> OvmfPkg: Enable CLANG9 tool chain >> >> BaseTools/Source/C/GenFw/GenFw.c | 8 +- >> CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c | 10 +- >> EmulatorPkg/Win/Host/WinHost.c | 6 +- >> MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c | 6 - >> BaseTools/Conf/build_rule.template | 26 +++-- >> BaseTools/Conf/tools_def.template | 124 >+++++++++++++++++++-- >> CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 1 + >> CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 + >> CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 1 + >> CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 1 + >> CryptoPkg/Library/OpensslLib/OpensslLib.inf | 1 + >> CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 1 + >> EmulatorPkg/EmulatorPkg.dsc | 7 +- >> EmulatorPkg/Win/Host/WinHost.inf | 6 + >> .../LzmaCustomDecompressLib/Sdk/C/7zTypes.h | 2 +- >> .../RegularExpressionDxe/RegularExpressionDxe.inf | 3 + >> MdePkg/Include/Base.h | 6 +- >> MdePkg/Include/Ia32/ProcessorBind.h | 4 +- >> MdePkg/Include/X64/ProcessorBind.h | 2 +- >> OvmfPkg/OvmfPkgIa32.dsc | 4 +- >> OvmfPkg/OvmfPkgIa32X64.dsc | 4 +- >> OvmfPkg/OvmfPkgX64.dsc | 4 +- >> 22 files changed, 183 insertions(+), 45 deletions(-) >> >> -- >> 2.13.0.windows.1 >> >> >>=20 >>