From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web09.10540.1572833313139024239 for ; Sun, 03 Nov 2019 18:08:33 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Nov 2019 18:08:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,265,1569308400"; d="scan'208";a="231904502" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 03 Nov 2019 18:08:32 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 3 Nov 2019 18:08:31 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 3 Nov 2019 18:08:31 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.225]) with mapi id 14.03.0439.000; Mon, 4 Nov 2019 10:08:28 +0800 From: "Liming Gao" To: Sami Mujawar , "devel@edk2.groups.io" , Pierre Gondois CC: "Kinney, Michael D" , nd Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML OpCode definition for ExternalOp Thread-Topic: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML OpCode definition for ExternalOp Thread-Index: AQHVjyzPsjpI9BAkSEypbATHgwpcr6dyxQ4AgAeGBGA= Date: Mon, 4 Nov 2019 02:08:28 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E536934@SHSMSX104.ccr.corp.intel.com> References: <20191030141729.124444-1-pierre.gondois@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Push @ b10ef8a4e75899cfad421dc60d0bbf93c53d37f4 >-----Original Message----- >From: Sami Mujawar [mailto:Sami.Mujawar@arm.com] >Sent: Wednesday, October 30, 2019 11:15 PM >To: devel@edk2.groups.io; Pierre Gondois >Cc: Kinney, Michael D ; Gao, Liming >; Sami Mujawar ; nd > >Subject: RE: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML OpCode >definition for ExternalOp > >Reviewed-by: Sami Mujawar > >Regards, > >Sami Mujawar > >-----Original Message----- >From: devel@edk2.groups.io On Behalf Of >PierreGondois via Groups.Io >Sent: 30 October 2019 02:17 PM >To: devel@edk2.groups.io >Cc: Pierre Gondois ; >michael.d.kinney@intel.comliming.gao@intel.comSami.Mujawar@arm.com; >nd >Subject: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML OpCode definition >for ExternalOp > >From: Pierre Gondois > >The ACPI specification, version 6.3, January 2019, defines the Named Obje= ct >Encoding for ExternalOp in section '20.2.5.2 Named Objects Encoding'. > >This patch adds the definition for ExternalOp to the list of Primary Opco= de >definitions. > >Signed-off-by: Pierre Gondois >--- > >The changes can be seen at >https://github.com/PierreARM/edk2/commits/677_Add_ExternalOp_definiti >on_v1 > >Notes: > v1: > - Add the ExternalOp AML OpCode [Pierre] > > MdePkg/Include/IndustryStandard/AcpiAml.h | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/MdePkg/Include/IndustryStandard/AcpiAml.h >b/MdePkg/Include/IndustryStandard/AcpiAml.h >index >6919622af212c58dd92fc4d2bbd3b9447961d20a..3dd5408b359f9192e2fa9cedd0 >260a0f6bb5603a 100644 >--- a/MdePkg/Include/IndustryStandard/AcpiAml.h >+++ b/MdePkg/Include/IndustryStandard/AcpiAml.h >@@ -2,6 +2,7 @@ > This file contains AML code definition in the latest ACPI spec. > > Copyright (c) 2011, Intel Corporation. All rights reserved.
>+ Copyright (c) 2019, ARM Limited. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ >@@ -30,6 +31,7 @@ > #define AML_PACKAGE_OP 0x12 > #define AML_VAR_PACKAGE_OP 0x13 > #define AML_METHOD_OP 0x14 >+#define AML_EXTERNAL_OP 0x15 > #define AML_DUAL_NAME_PREFIX 0x2e > #define AML_MULTI_NAME_PREFIX 0x2f > #define AML_NAME_CHAR_A 0x41 >-- >'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > >