From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.142.1572838008235403801 for ; Sun, 03 Nov 2019 19:26:48 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Nov 2019 19:26:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,265,1569308400"; d="scan'208";a="231918401" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 03 Nov 2019 19:26:47 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 3 Nov 2019 19:26:47 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 3 Nov 2019 19:26:47 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by shsmsx102.ccr.corp.intel.com ([169.254.2.108]) with mapi id 14.03.0439.000; Mon, 4 Nov 2019 11:26:43 +0800 From: "Liming Gao" To: "Gao, Zhichao" , Sudipto Paul , Sami Mujawar , Krzysztof Koch , "devel@edk2.groups.io" CC: "Carsey, Jaben" , "Ni, Ray" , "Kinney, Michael D" , Matteo Carlini , nd , Deepak Pandey Subject: Re: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3 Thread-Topic: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3 Thread-Index: AQHVIUlaDfykclA/a02DwdL8+j1WCadmD9kwgBEmCACAA2wbAIAAmp1w Date: Mon, 4 Nov 2019 03:26:42 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E536BE4@SHSMSX104.ccr.corp.intel.com> References: <20190612141021.40640-1-krzysztof.koch@arm.com> <3CE959C139B4C44DBEA1810E3AA6F9000B86C284@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B86C284@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I see the change in MdePkg has been pushed. So, the remaining discussion is= about the change in ShellPkg, right? Thanks Liming >-----Original Message----- >From: Gao, Zhichao >Sent: Monday, November 04, 2019 10:13 AM >To: Sudipto Paul ; Sami Mujawar >; Krzysztof Koch ; >devel@edk2.groups.io >Cc: Carsey, Jaben ; Ni, Ray ; >Kinney, Michael D ; Gao, Liming >; Matteo Carlini ; nd >; Deepak Pandey >Subject: RE: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3 > >Thanks for the T-B. >But the patch has conflict now, can you help to address it? As I know the >previous change aims to remove the declaration of the internal used functi= on. >So I suggest to remove the declaration of the new added function and move >the definition to the location of the declaration. > >Thanks, >Zhichao > >> -----Original Message----- >> From: Sudipto Paul >> Sent: Friday, November 1, 2019 9:59 PM >> To: Sami Mujawar ; Krzysztof Koch >> ; devel@edk2.groups.io >> Cc: Carsey, Jaben ; Ni, Ray ; >Gao, >> Zhichao ; Kinney, Michael D >> ; Gao, Liming ; >Matteo >> Carlini ; nd ; Deepak Pandey >> >> Subject: RE: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3 >> >> Tested-by: Sudipto Paul > >> This patch has been tested on N1SDP. This is a public Neoverse branded >cores >> System Development Platform. >> https://community.arm.com/developer/tools-software/oss- >> platforms/w/docs/440/neoverse-n1-sdp >> >> >> -Sudipto >> >> -----Original Message----- >> From: Sami Mujawar >> Sent: 21 October 2019 17:06 >> To: Krzysztof Koch ; devel@edk2.groups.io >> Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; >> michael.d.kinney@intel.com; liming.gao@intel.com; Matteo Carlini >> ; nd ; Deepak Pandey >> ; Sudipto Paul >> Subject: RE: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3 >> >> Reviewed-by: Sami Mujawar >> >> Regards, >> >> Sami Mujawar >> >> -----Original Message----- >> From: Krzysztof Koch >> Sent: 12 June 2019 03:10 PM >> To: devel@edk2.groups.io >> Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; >> michael.d.kinney@intel.com; liming.gao@intel.com; Sami Mujawar >> ; Matteo Carlini ; >> Stephanie Hughes-Fitt ; nd > >> Subject: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3 >> >> This patch adds a number of definitions to the ACPI 6.3 header file for = the >> purpose of parsing Revision 3 of the System Resource Affinity Table >> (SRAT) in the Acpiview UEFI shell tool. >> >> By defining the Generic Initiator Affinity Structure's Type ID and the a= llowed >> Device Handle Types for the structure, it is possible to dump and valida= te >the >> contents of the latest version of the SRAT table in acpiview. >> >> References: >> - ACPI 6.3 January 2019, Section 5.2.16.6 >> >> Changes can be seen at: >> https://github.com/KrzysztofKoch1/edk2/tree/582_acpiview_6_3_srat_v1 >> >> Krzysztof Koch (2): >> MdePkg: Add Generic Initiator Affinity Structure definitions to SRAT >> ShellPkg: acpiview: Update SRAT parser to ACPI 6.3 >> >> MdePkg/Include/IndustryStandard/Acpi63.h = | 11 +- >> ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c = | 35 >++- >> ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h = | 16 >++ >> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c >| >> 256 +++++++++++++++++++- >> 4 files changed, 309 insertions(+), 9 deletions(-) >> >> -- >> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >> >> >> >> IMPORTANT NOTICE: The contents of this email and any attachments are >> confidential and may also be privileged. If you are not the intended rec= ipient, >> please notify the sender immediately and do not disclose the contents to >any >> other person, use it for any purpose, or store or copy the information i= n any >> medium. Thank you.