public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"afish@apple.com" <afish@apple.com>
Cc: "tigerliu@zhaoxin.com" <tigerliu@zhaoxin.com>
Subject: Re: [edk2-devel] [edk2] NOOPT and PcdOptimizeCompilerEnable
Date: Mon, 4 Nov 2019 03:40:49 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E536C4A@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <DC97E006-3A8D-41D9-BCDF-78F927809DCC@apple.com>

[-- Attachment #1: Type: text/plain, Size: 3779 bytes --]

Andrew:
  I did some investigation. Seemly, there is no way to disable VS command line warning.

Thanks
Liming
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Andrew Fish via Groups.Io
Sent: Thursday, October 31, 2019 10:07 AM
To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>
Cc: tigerliu@zhaoxin.com
Subject: Re: [edk2-devel] [edk2] NOOPT and PcdOptimizeCompilerEnable

Liming,

For gcc/clang if you repeat an argument the last argument wins. This is the default behavior and it does not warn, as it is designed to work with features like PcdOptimizeCompilerEnable.

If VC++ warns for this behavior should we disable D9025 for VC++ so all the toolchains have the same behavior?

Thanks,

Andrew Fish


On Oct 30, 2019, at 6:46 PM, Liming Gao <liming.gao@intel.com<mailto:liming.gao@intel.com>> wrote:

Yes. This is the expect behavior. Compiler optimization is disabled, then Od option will be used for VS tool chain.

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> [mailto:devel@edk2.groups.io] On Behalf Of Tiger Liu(BJ-RD)
Sent: Thursday, October 31, 2019 9:40 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>
Subject: Re: [edk2-devel] [edk2] NOOPT and PcdOptimizeCompilerEnable

Hi, Liming:
Thanks for your explanation.

If setting PcdOptimizeCompilerEnable as disable, then will cause D9025 compiling warning.
Such as:
cl : Command line warning D9025 : overriding '/O1' with '/Od'

So, is it ok?

Thanks
发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 Liming Gao
发送时间: 2019年10月30日 23:00
收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Tiger Liu(BJ-RD) <TigerLiu@zhaoxin.com<mailto:TigerLiu@zhaoxin.com>>
主题: Re: [edk2-devel] [edk2] NOOPT and PcdOptimizeCompilerEnable

NOOPT is build target. It includes the compiler option to disable optimization. If the platform supports NOOPT target, it can be built with -b NOOPT.

PcdOptimizeCompilerEnable is one feature PCD defined in edk2-platforms. It can be used to control the compiler option in [BuildOptions] section. It can also be used for DEBUG or RELEASE target.

Thanks
Liming
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Tiger Liu(BJ-RD)
Sent: Tuesday, October 29, 2019 7:01 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: [edk2-devel] [edk2] NOOPT and PcdOptimizeCompilerEnable

Hi, All:
I have a question about NOOPT and PcdOptimizeCompilerEnable.

If Target = NOOPT, then will disable all optimizations.
And PcdOptimizeCompilerEnable has the same function.

So, What’s the relationship between PcdOptimizeCompilerEnable and NOOPT?

Thanks

Best wishes,

保密声明:
本邮件含有保密或专有信息,仅供指定收件人使用。严禁对本邮件或其内容做任何未经授权的查阅、使用、复制或转发。
CONFIDENTIAL NOTE:
This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited.

保密声明:
本邮件含有保密或专有信息,仅供指定收件人使用。严禁对本邮件或其内容做任何未经授权的查阅、使用、复制或转发。
CONFIDENTIAL NOTE:
This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited.



[-- Attachment #2: Type: text/html, Size: 19952 bytes --]

  reply	other threads:[~2019-11-04  3:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-31  1:39 [edk2-devel] [edk2] NOOPT and PcdOptimizeCompilerEnable Tiger Liu(BJ-RD)
2019-10-31  1:46 ` Liming Gao
2019-10-31  2:06   ` Andrew Fish
2019-11-04  3:40     ` Liming Gao [this message]
2019-11-05  2:55       ` Andrew Fish
  -- strict thread matches above, loose matches on Subject: below --
2019-10-29 11:00 Tiger Liu(BJ-RD)
2019-10-30 14:59 ` Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E536C4A@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox