From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.9388.1573051098624838782 for ; Wed, 06 Nov 2019 06:38:18 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 06:38:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,275,1569308400"; d="scan'208";a="403748039" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 06 Nov 2019 06:38:17 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 06:38:17 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 06:38:17 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by shsmsx102.ccr.corp.intel.com ([169.254.2.108]) with mapi id 14.03.0439.000; Wed, 6 Nov 2019 22:38:15 +0800 From: "Liming Gao" To: "Yao, Jiewen" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Lou, Yun" Subject: Re: [PATCH V2 1/4] MdePkg/Include: Add DMTF SPDM definition. Thread-Topic: [PATCH V2 1/4] MdePkg/Include: Add DMTF SPDM definition. Thread-Index: AQHVj+b9J/lkzKPqpkKe2Vvlg+RrUad+P11A Date: Wed, 6 Nov 2019 14:38:14 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E5389A0@SHSMSX104.ccr.corp.intel.com> References: <20191031123012.16020-1-jiewen.yao@intel.com> <20191031123012.16020-2-jiewen.yao@intel.com> In-Reply-To: <20191031123012.16020-2-jiewen.yao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWJjMDM4NzgtZTlmNS00ZWI3LTkzZjUtYTRiNWNkOWUyZGE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidmJ0VThocklqZzFVa0k5RHBISytldno0MUlIV3laYkNxeTBlelJWVzZSQXZ0SytKWXF5cTZhK2dGdlNLTmo4KyJ9 dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jiewen: I have one minor comment. Can you specify the spec version in file header= ?=20 With this update, Reviewed-by: Liming Gao Thanks Liming > -----Original Message----- > From: Yao, Jiewen > Sent: Thursday, October 31, 2019 8:30 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming ; Lou, Yun > Subject: [PATCH V2 1/4] MdePkg/Include: Add DMTF SPDM definition. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2303 >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Yun Lou > Signed-off-by: Jiewen Yao > --- > MdePkg/Include/IndustryStandard/Spdm.h | 203 ++++++++++++++++++++ > 1 file changed, 203 insertions(+) >=20 > diff --git a/MdePkg/Include/IndustryStandard/Spdm.h b/MdePkg/Include/Indu= stryStandard/Spdm.h > new file mode 100644 > index 0000000000..d62b24e9ef > --- /dev/null > +++ b/MdePkg/Include/IndustryStandard/Spdm.h > @@ -0,0 +1,203 @@ > +/** @file > + Definitions of Security Protocol & Data Model Specification (SPDM) > + in Distributed Management Task Force (DMTF). > + > +Copyright (c) 2019, Intel Corporation. All rights reserved.
> +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > + > +#ifndef __SPDM_H__ > +#define __SPDM_H__ > + > +#pragma pack(1) > + > +#define SPDM_DIGESTS 0x01 > +#define SPDM_CERTIFICATE 0x02 > +#define SPDM_CHALLENGE_AUTH 0x03 > +#define SPDM_MEASUREMENTS 0x60 > +#define SPDM_CAPABILITIES 0x61 > +#define SPDM_SET_CERT_RESPONSE 0x62 > +#define SPDM_ALGORITHMS 0x63 > +#define SPDM_ERROR 0x7F > +#define SPDM_GET_DIGESTS 0x81 > +#define SPDM_GET_CERTIFICATE 0x82 > +#define SPDM_CHALLENGE 0x83 > +#define SPDM_GET_MEASUREMENTS 0xE0 > +#define SPDM_GET_CAPABILITIES 0xE1 > +#define SPDM_SET_CERTIFICATE 0xE2 > +#define SPDM_NEGOTIATE_ALGORITHMS 0xE3 > +#define SPDM_RESPOND_IF_READY 0xFF > + > +typedef struct { > + UINT8 SPDMVersion; > + UINT8 RequestResponseCode; > + UINT8 Param1; > + UINT8 Param2; > +} SPDM_MESSAGE_HEADER; > + > +#define SPDM_VERSION 0x10 > + > +typedef struct { > + SPDM_MESSAGE_HEADER Header; > +} SPDM_GET_CAPABILITIES_REQUEST; > + > +typedef struct { > + SPDM_MESSAGE_HEADER Header; > + UINT8 DetailedVersion; > + UINT8 CryptographicTimeout; > + UINT16 Reserved; > + UINT32 Flags; > + UINT16 SPDMMajorVersions; > + UINT16 Reserved2; > +} SPDM_CAPABILITIES_RESPONSE; > + > +#define SPDM_GET_CAPABILITIES_RESPONSE_FLAGS_AUTH_CAP BIT1 > +#define SPDM_GET_CAPABILITIES_RESPONSE_FLAGS_MEAS_CAP BIT3 > +#define SPDM_GET_CAPABILITIES_RESPONSE_FLAGS_MEAS_FRESH_CAP BIT4 > + > +typedef struct { > + SPDM_MESSAGE_HEADER Header; > + UINT16 Length; > + UINT8 MeasurementSpecification; > + UINT8 Reserved; > + UINT32 BaseAsymAlgo; > + UINT32 BaseHashAlgo; > + UINT64 Reserved2; > + UINT8 ExtAsymCount; > + UINT8 ExtHashCount; > + UINT16 Reserved3; > +//UINT32 ExtAsym[ExtAsymCount]; > +//UINT32 ExtHash[ExtHashCount]; > +} SPDM_NEGOTIATE_ALGORITHMS_REQUEST; > + > +#define SPDM_ALGORITHMS_BASE_ASYM_ALGO_TPM_ALG_RSASSA_2048 BIT= 0 > +#define SPDM_ALGORITHMS_BASE_ASYM_ALGO_TPM_ALG_RSASSA_3072 BIT= 1 > +#define SPDM_ALGORITHMS_BASE_ASYM_ALGO_TPM_ALG_ECDSA_ECC_NIST_P256 BIT= 2 > +#define SPDM_ALGORITHMS_BASE_ASYM_ALGO_TPM_ALG_RSASSA_4096 BIT= 3 > +#define SPDM_ALGORITHMS_BASE_ASYM_ALGO_TPM_ALG_ECDSA_ECC_NIST_P384 BIT= 4 > +#define SPDM_ALGORITHMS_BASE_ASYM_ALGO_TPM_ALG_ECDSA_ECC_NIST_P521 BIT= 5 > + > +#define SPDM_ALGORITHMS_BASE_HASH_ALGO_TPM_ALG_SHA2_256 BIT= 0 > +#define SPDM_ALGORITHMS_BASE_HASH_ALGO_TPM_ALG_SHA3_256 BIT= 1 > +#define SPDM_ALGORITHMS_BASE_HASH_ALGO_TPM_ALG_SHA2_384 BIT= 2 > +#define SPDM_ALGORITHMS_BASE_HASH_ALGO_TPM_ALG_SHA3_384 BIT= 3 > +#define SPDM_ALGORITHMS_BASE_HASH_ALGO_TPM_ALG_SHA2_512 BIT= 4 > +#define SPDM_ALGORITHMS_BASE_HASH_ALGO_TPM_ALG_SHA3_512 BIT= 5 > + > +typedef struct { > + SPDM_MESSAGE_HEADER Header; > + UINT16 Length; > + UINT8 MeasurementSpecification; > + UINT8 MeasurementHashAlgo; > + UINT32 BaseAsymSel; > + UINT32 BaseHashSel; > + UINT64 Reserved; > + UINT8 ExtAsymSelCount; > + UINT8 ExtHashSelCount; > + UINT16 Reserved2; > +//UINT32 ExtAsymSel[ExtAsymSelCount]; > +//UINT32 ExtHashSel[ExtHashSelCount]; > +} SPDM_ALGORITHMS_RESPONSE; > + > +typedef struct { > + SPDM_MESSAGE_HEADER Header; > +} SPDM_GET_DIGESTS_REQUEST; > + > +typedef struct { > + SPDM_MESSAGE_HEADER Header; > +//UINT8 Digest[DigestSize]; > +} SPDM_DIGESTS_RESPONSE; > + > +typedef struct { > + SPDM_MESSAGE_HEADER Header; > + UINT16 Offset; > + UINT16 Length; > +} SPDM_GET_CERTIFICATE_REQUEST; > + > +typedef struct { > + SPDM_MESSAGE_HEADER Header; > +//UINT8 CertChain[CertChainSize]; > +} SPDM_CERTIFICATE_RESPONSE; > + > +typedef struct { > + SPDM_MESSAGE_HEADER Header; > +//UINT8 Nonce[DigestSize]; > +} SPDM_CHALLENGE_REQUEST; > + > +typedef struct { > + SPDM_MESSAGE_HEADER Header; > + UINT8 MinSPDMVersion; > + UINT8 MaxSPDMVersion; > + UINT8 Capabilities; > + UINT8 Reserved; > +//UINT8 CertChainHash[DigestSize]; > +//UINT8 Salt[DigestSize]; > +//UINT8 ContextHash[DigestSize]; > + // > + // M1 =3D Concatenate( > + // GET_CAPABILITIES_REQUEST1, CAPABILITIES_RESPONSE1, > + // NEGOTIATE_ALGORITHMS_REQUEST1, ALGORITHMS_RESPONSE1, CHALLEN= GE_REQUEST1, > + // CHALLENGE_AUTH_RESPONSE_WITHOUT_SIGNATURE1) > + // Signature =3D Sign(SK, Hash1(M1)) > + // > +//UINT8 Signature[KeySize]; > +} SPDM_CHALLENGE_AUTH_RESPONSE; > + > +typedef struct { > + SPDM_MESSAGE_HEADER Header; > + // Param1 =3D=3D Request Type > + // Param2 =3D=3D Measurement Index (0xFF =3D=3D all) > +//UINT8 Nonce[DigestSize]; > +} SPDM_GET_MEASUREMENTS_REQUEST; > + > +typedef struct { > + UINT8 Index; > + UINT8 MeasurementType; > + UINT8 MeasurementSpecification; > + UINT8 Reserved; > +} SPDM_MEASUREMENT_BLOCK_HEADER; > + > +#define SPDM_MEASUREMENT_BLOCK_MEASUREMENT_TYPE_IMMUTABLE_ROM = 1 > +#define SPDM_MEASUREMENT_BLOCK_MEASUREMENT_TYPE_MUTABLE_FIRMWARE = 2 > +#define SPDM_MEASUREMENT_BLOCK_MEASUREMENT_TYPE_HARDWARE_CONFIGURATION = 3 > +#define SPDM_MEASUREMENT_BLOCK_MEASUREMENT_TYPE_FIRMWARE_CONFIGURATION = 4 > + > +typedef struct { > + SPDM_MESSAGE_HEADER Header; > + UINT8 NumberOfBlocks; > +//SPDM_MEASUREMENT_BLOCK_STRUCT MeasurementRecord[NumberOfBlocks]; > +//UINT8 Salt[DigestSize]; > +//UINT8 ContextHash[DigestSize]; > + // > + // L1 =3D Concatenate( > + // GET_MEASUREMENTS_REQUEST1, MEASUREMENTS_RESPONSE_WITHOUT_SIG= NATURE1) > + // Signature =3D Sign(SK, Hash1(L1)) > + // > +//UINT8 Signature[KeySize]; > +} SPDM_MEASUREMENTS_RESPONSE; > + > +typedef struct { > + SPDM_MESSAGE_HEADER Header; > + // Param1 =3D=3D Error Code > + // Param2 =3D=3D Error Data > +//UINT8 ExtendedErrorData[]; > +} SPDM_ERROR_RESPONSE; > + > +#define SPDM_ERROR_CODE_INVALID_REQUEST 0x01 > +#define SPDM_ERROR_CODE_BUSY 0x03 > +#define SPDM_ERROR_CODE_UNEXPECTED_REQUEST 0x04 > +#define SPDM_ERROR_CODE_UNINITIALIZED 0x05 > +#define SPDM_ERROR_CODE_REQUESTED_INFO_TOO_LONG 0x40 > +#define SPDM_ERROR_CODE_MAJOR_VERSION_MISMATCH 0x41 > +#define SPDM_ERROR_CODE_RESPONSE_NOT_READY 0x42 > + > +typedef struct { > + SPDM_MESSAGE_HEADER Header; > +} SPDM_RESPONSE_IF_READY_REQUEST; > + > +#pragma pack() > + > +#endif > + > -- > 2.19.2.windows.1