Re: [edk2-devel] [PATCH V2 4/8] MdePkg/Smbios.h: SMBIOS 3.3.0 Update Intel Persistent Memory string

["Liming Gao" <liming.gao@intel.com>]

Zhichao:
  I add my comments.

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gao, Zhichao
> Sent: Monday, November 4, 2019 6:13 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>
> Subject: [edk2-devel] [PATCH V2 4/8] MdePkg/Smbios.h: SMBIOS 3.3.0 Update Intel Persistent Memory string
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305
> 
> Memory Device (Type 17):
> – SMBIOSCR00179: update the string for Intel persistent memory
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/SmBios.h | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
> index 9aa8cf3e72..104c3f5f50 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -1747,13 +1747,13 @@ typedef struct {
>  /// Memory Device - Memory Technology
>  ///
>  typedef enum {
> -  MemoryTechnologyOther                     = 0x01,
> -  MemoryTechnologyUnknown                   = 0x02,
> -  MemoryTechnologyDram                      = 0x03,
> -  MemoryTechnologyNvdimmN                   = 0x04,
> -  MemoryTechnologyNvdimmF                   = 0x05,
> -  MemoryTechnologyNvdimmP                   = 0x06,
> -  MemoryTechnologyIntelPersistentMemory     = 0x07
> +  MemoryTechnologyOther                             = 0x01,
> +  MemoryTechnologyUnknown                           = 0x02,
> +  MemoryTechnologyDram                              = 0x03,
> +  MemoryTechnologyNvdimmN                           = 0x04,
> +  MemoryTechnologyNvdimmF                           = 0x05,
> +  MemoryTechnologyNvdimmP                           = 0x06,
> +  MemoryTechnologyIntelOptaneDCPersistentMemory     = 0x07
Please keep this type name to avoid the incompatible change. 
You can add comments to describe its meaning. 

Thanks
Liming
>  } MEMORY_DEVICE_TECHNOLOGY;
> 
>  ///
> --
> 2.21.0.windows.1
> 
> 
>