EDK II CI Phase 1 Unit Test Cases

EDK II CI Phase 1 Unit Test Cases

[Michael D Kinney]

Hello,

The following link performs a query on the pull requests in
edk2-staging/edk2-ci branch that shows the unit tests cases
that have been run.  

https://github.com/tianocore/edk2-staging/pulls?utf8=%E2%9C%93&q=is%3Apr+0005h+in%3Atitle+OR+0005+in%3Atitle

It includes unit tests from maintainers and non-maintainers
for patch series that pass and fail the enabled checks and
include the use of the 'push' label by maintainers.

Please review these unit test cases and provide feedback
if there are unit test cases that should be added or if
any of these do not have the expected results.

These unit tests were run against the same sources that are
under review in the V4 patch series here:

https://github.com/tianocore/edk2-staging/tree/edk2-ci_V4

https://edk2.groups.io/g/devel/message/50126

Thanks,

Mike

Re: EDK II CI Phase 1 Unit Test Cases

[Liming Gao]

Mike:
  Is there the case to add new file or remove the existing file or rename the file name?

  And, is there the case to update BaseTools C or Python code?

Thanks
Liming
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael D Kinney
> Sent: Thursday, November 7, 2019 10:07 AM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-devel] EDK II CI Phase 1 Unit Test Cases
> 
> Hello,
> 
> The following link performs a query on the pull requests in
> edk2-staging/edk2-ci branch that shows the unit tests cases
> that have been run.
> 
> https://github.com/tianocore/edk2-staging/pulls?utf8=%E2%9C%93&q=is%3Apr+0005h+in%3Atitle+OR+0005+in%3Atitle
> 
> It includes unit tests from maintainers and non-maintainers
> for patch series that pass and fail the enabled checks and
> include the use of the 'push' label by maintainers.
> 
> Please review these unit test cases and provide feedback
> if there are unit test cases that should be added or if
> any of these do not have the expected results.
> 
> These unit tests were run against the same sources that are
> under review in the V4 patch series here:
> 
> https://github.com/tianocore/edk2-staging/tree/edk2-ci_V4
> 
> https://edk2.groups.io/g/devel/message/50126
> 
> Thanks,
> 
> Mike
> 
> 
> 
> 

Re: EDK II CI Phase 1 Unit Test Cases

[Michael D Kinney]

Hi Liming,

I have not done those cases.  I have cases that
modify existing files.  I want to make sure that these
test case are testing the Azure Pipelines, GitHub, and 
Mergify features.

Some of your suggestions are more about testing git
which seems out of scope.

I have submitted other PRs to edk2-ci that do 
add/remove/rename files without any issues.

However, a change to BaseTools is interesting, because
we would want to know that the modified version of
BaseTools is used to run the CI tests. I can add that
one.  Perhaps a change that generates extra log messages
so the extra log message can be found in the CI logs.

Mike

> -----Original Message-----
> From: Gao, Liming <liming.gao@intel.com>
> Sent: Thursday, November 7, 2019 7:15 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: RE: EDK II CI Phase 1 Unit Test Cases
> 
> Mike:
>   Is there the case to add new file or remove the
> existing file or rename the file name?
> 
>   And, is there the case to update BaseTools C or Python
> code?
> 
> Thanks
> Liming
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Michael
> > D Kinney
> > Sent: Thursday, November 7, 2019 10:07 AM
> > To: devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: [edk2-devel] EDK II CI Phase 1 Unit Test
> Cases
> >
> > Hello,
> >
> > The following link performs a query on the pull
> requests in
> > edk2-staging/edk2-ci branch that shows the unit tests
> cases that have
> > been run.
> >
> > https://github.com/tianocore/edk2-
> staging/pulls?utf8=%E2%9C%93&q=is%3A
> > pr+0005h+in%3Atitle+OR+0005+in%3Atitle
> >
> > It includes unit tests from maintainers and non-
> maintainers for patch
> > series that pass and fail the enabled checks and
> include the use of
> > the 'push' label by maintainers.
> >
> > Please review these unit test cases and provide
> feedback if there are
> > unit test cases that should be added or if any of
> these do not have
> > the expected results.
> >
> > These unit tests were run against the same sources
> that are under
> > review in the V4 patch series here:
> >
> > https://github.com/tianocore/edk2-staging/tree/edk2-
> ci_V4
> >
> > https://edk2.groups.io/g/devel/message/50126
> >
> > Thanks,
> >
> > Mike
> >
> >
> >
> >