public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"lersek@redhat.com" <lersek@redhat.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] EDK II Maintainers please test the pull request commit gate
Date: Thu, 7 Nov 2019 15:18:24 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E539659@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <ad30a0d7-213c-65ad-4d3a-fb68bcb8db97@redhat.com>

I do my test on https://github.com/tianocore/edk2-staging/pull/60. But, I have not tested hub utility. 

Thanks
Liming
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek
> Sent: Thursday, November 7, 2019 7:01 PM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] EDK II Maintainers please test the pull request commit gate
> 
> On 11/07/19 03:24, Michael D Kinney wrote:
> > EDK II Maintainers,
> >
> > Please take a few minutes to test the GitHub pull
> > request commit gate feature under review in the
> > edk2-staging/edk2-ci branch.  This will be the only
> > method to push patches to the edk2 repo in the near
> > future, and we want all current EDK II Maintainers to
> > make sure they know how to use this new process on
> > the edk2-staging repo before it is activated on the
> > edk2 repo.
> >
> > Please perform the following steps:
> > * Create a personal fork of the edk2-staging repo.
> 
> Slight but relevant clarification: please create a personal fork of the
> edk2-staging repo *on GitHub.com*.
> 
> > * Check out the edk2-ci branch from your personal
> >   fork of the edk2-staging repo
> > * Create a new branch based on the edk2-ci branch
> > * Edit the file SampleFile.txt in the root of this
> >   branch and add an Acked-by: <your email> tag to
> >   the end of this file.
> > * Submit a pull request against the Tianocore
> >   edk2-staging/edk2-ci.  Set the 'push' label so
> >   the change to SampleFile.txt will be committed
> >   if all checks pass.
> >
> >   NOTE: Make sure you select the 'edk2-ci' branch.
> >   The default branch for the edk2-staging repo is
> >   the 'about' branch and the pull request will not
> >   work against the 'about' branch.
> >
> > * Verify that all checks pass and your change to
> >   SampleFile.txt was merged into the
> >   edk2-staging/edk2-ci branch.
> >
> > For those that prefer command line tools over a WebUI,
> > the command line utility called 'hub' can be used to
> > submit a pull request and check the status of a pull
> > request.
> >
> > * https://github.com/github/hub
> > * https://github.com/github/hub/releases
> > * https://hub.github.com/hub.1.html
> 
> I've gone through the above (except the personal Acked-by tag) earlier,
> successfully:
> 
> https://github.com/tianocore/edk2-staging/pull/99
> 
> Thanks!
> Laszlo
> 
> 
> 


  reply	other threads:[~2019-11-07 15:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07  2:24 EDK II Maintainers please test the pull request commit gate Michael D Kinney
2019-11-07 11:00 ` [edk2-devel] " Laszlo Ersek
2019-11-07 15:18   ` Liming Gao [this message]
2019-11-07 19:33     ` Michael D Kinney
2019-11-07 19:26   ` Michael D Kinney
2019-11-08 17:12     ` Laszlo Ersek
2019-11-08 17:21       ` Michael D Kinney
2019-11-08 14:49 ` Philippe Mathieu-Daudé
2019-11-08 17:10   ` Michael D Kinney
2019-11-08 17:43     ` rebecca
2019-11-11  5:42 ` Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E539659@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox