From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.5749.1573140956815745234 for ; Thu, 07 Nov 2019 07:35:57 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2019 07:35:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,278,1569308400"; d="scan'208";a="230564398" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 07 Nov 2019 07:35:55 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 Nov 2019 07:35:55 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 7 Nov 2019 07:35:55 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 7 Nov 2019 07:35:54 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.225]) with mapi id 14.03.0439.000; Thu, 7 Nov 2019 23:35:53 +0800 From: "Liming Gao" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: Sean Brogan , Bret Barkelew , "Feng, Bob C" , "Andrew Fish" , Laszlo Ersek , Leif Lindholm , "Wang, Jian J" , "Lu, XiaoyuX" , "Ni, Ray" , "Wu, Hao A" , "Wu, Jiaxin" , "Fu, Siyuan" , "Yao, Jiewen" , "Zhang, Chao B" , "Gao, Zhichao" , "Dong, Eric" Subject: Re: [Patch v4 00/22] Enable Phase 1 of EDK II CI Thread-Topic: [Patch v4 00/22] Enable Phase 1 of EDK II CI Thread-Index: AQHVlQigIavVnT+WrUKhnb5NpOsLMqd/1oGQ Date: Thu, 7 Nov 2019 15:35:53 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E539692@SHSMSX104.ccr.corp.intel.com> References: <20191107011349.16524-1-michael.d.kinney@intel.com> In-Reply-To: <20191107011349.16524-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2IxZmMxMjQtNDA4OC00YWI2LThmZGYtMmU3NGY2NzM4MGFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicnFVRnRSU01acEpVcU9tOGs1Y2dleCtmWGlcL2FVZ040Z3dNXC9pM2Z0SzRLaDBMNmdqMDhrR0VjRlAybmZtcjhuIn0= dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Mike: Thanks for your update. I only have one minor comment in Patch7. The full= patch set is OK to me. Reviewed-by: Liming Gao . Thanks Liming > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, November 7, 2019 9:13 AM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Bret Barkelew ; Gao, Liming ; > Feng, Bob C ; Andrew Fish ; Laszlo= Ersek ; Leif Lindholm > ; Wang, Jian J ; Lu, Xia= oyuX ; Ni, Ray ; Wu, > Hao A ; Wu, Jiaxin ; Fu, Siyuan = ; Yao, Jiewen > ; Zhang, Chao B ; Gao, Zhic= hao ; Dong, Eric > > Subject: [Patch v4 00/22] Enable Phase 1 of EDK II CI >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2315 >=20 > RFC Proposals: > * https://edk2.groups.io/g/rfc/message/93 > * https://edk2.groups.io/g/devel/message/46607 >=20 > Wiki Page: > * https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Continuous= -Integration >=20 > Branch for review: > * https://github.com/tianocore/edk2-staging/tree/edk2-ci_V4 >=20 > Changes in V4 > * Only copy BaseTools build logs if BaseTools are built > * Add FINISHED and FAILED jobs to prevent multiple email notifications fr= om > Mergify for PR close and PR comment actions > * Reformat .pytools/Readme.md to 80 columns > * Set WINSDK_PATH_FOR_RC_EXE in BaseTools/set_vsprefix_env.bat for VS2017= /VS2019 > * Update .gitignore to alphabetic ordering > * Update Maintainers.txt to alphabetic ordering > * Add file header comment block to requirements.txt > * Remove license badge and formatting changes from Readme.md >=20 > Previous versions of branches for reference: > * https://github.com/tianocore/edk2-staging/tree/edk2-ci_V3 > * https://github.com/tianocore/edk2-staging/tree/edk2-ci_V2 > * https://github.com/tianocore/edk2-staging/tree/edk2-ci_V1 >=20 > Active branch for testing/evaluation: > * https://github.com/tianocore/edk2-staging/tree/edk2-ci > * To test, fork edk2-staging repo, create a branch with a change, and sub= mit > a pull request targeting edk2-staging/edk2-ci. NOTE: the default branc= h for > the edk2-staging is 'about'. You must select the 'edk2-ci' branch when > a pull request is opened. Set the 'push' label to require commit if al= l > checks pass. >=20 > Pull request history on active branch for testing/evaluation: > * https://github.com/tianocore/edk2-staging/pulls?q=3Dis%3Apr+is%3Aclosed >=20 > This patch series enables pre-commit and post-commit checks on edk2/maste= r The > goal is to improve quality of code submissions by requiring all pre-commi= t > checks to pass before any change is committed to edk2/master. In order to > minimize the impact to the developer process, when an EDK II Maintainer i= s ready > to commit changes to edk2/master, the EDK II Maintainer pushes a branch t= o their > personal fork of the edk2 repository and opens a pull request targeting > edk2/master and sets the 'push' label. If all checks pass, then the pull > request is automatically committed. >=20 > A developer that wants to know if a patch series passes all checks can ei= ther > run the checks locally or open a pull request without setting the 'push' = label. >=20 > The post-commit checks build all packages and provide status badges and l= inks to > reports in the Readme.md file at the root of edk2/master. >=20 > A combination of GitHub, Azure Pipelines, Mergify, and edk2-pytool featur= es are > used to implement this feature. GitHub and Azure Pipelines configuration= steps > are required to activate this feature on edk2/master. >=20 > Once this feature is active and shown to be stable for 1-2 weeks, write a= ccess > to the edk2 repository will be removed for all EDK II Maintainers. Only = admins > will retain write access, and admins should avoid use of direct push to r= esolve > an issue unless there is no method to resolve the issue using the pull re= quest > method. >=20 > The following checks are made available by this patch series. Not all ch= ecks > are enabled for all packages. Enabling all checks on all packages can be= done > incrementally as well as adding more checks over time. > * PatchCheck > * CharEncodingCheck > * CompilerPlugin > * DependencyCheck > * DscCompleteCheck > * GuidCheck > * LibraryClassCheck > * SpellCheck >=20 > Cc: Sean Brogan > Cc: Bret Barkelew > Cc: Liming Gao > Cc: Bob Feng > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Ray Ni > Cc: Hao A Wu > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Jiewen Yao > Cc: Chao Zhang > Cc: Zhichao Gao > Cc: Eric Dong > Signed-off-by: Michael D Kinney >=20 > Michael D Kinney (14): > Maintainers.txt: Add continuous integration(CI) directories > CryptoPkg: Add YAML file for CI builds > FatPkg: Add YAML file for CI builds > FmpDevicePkg: Add YAML file for CI builds > MdeModulePkg: Add YAML file for CI builds > MdePkg: Add YAML file for CI builds > NetworkPkg: Add YAML file for CI builds > PcAtChipsetPkg: Add YAML files for CI builds > SecurityPkg: Add YAML files for CI builds > ShellPkg: Add YAML file for CI builds > UefiCpuPkg: Add YAML file for CI builds > SignedCapsulePkg: Use BaseCryptLibNull to reduce package CI time > .mergify: Add Mergify YML pull request rules configuration file > Readme.md: Add CI build status badges >=20 > Sean Brogan (8): > .gitignore: Ignore python compiled files, extdeps, and vscode > requirements.txt: Add python pip requirements file > BaseTools: Add RC_PATH define for VS2017/2019 > BaseTools: Add YAML files with path env and tool extdeps > BaseTools: Add BaseTools plugins to support CI > .pytool/Plugin: Add CI plugins > .pytool: Add CISettings.py and Readme.md > .azurepipelines: Add Azure Pipelines YML configuration files >=20 > .azurepipelines/Ubuntu-GCC5.yml | 18 ++ > .azurepipelines/Ubuntu-PatchCheck.yml | 32 +++ > .azurepipelines/Windows-VS2019.yml | 18 ++ > .../templates/basetools-build-steps.yml | 36 +++ > .../templates/pr-gate-build-job.yml | 79 ++++++ > .azurepipelines/templates/pr-gate-steps.yml | 129 +++++++++ > .../templates/spell-check-prereq-steps.yml | 21 ++ > .gitignore | 6 +- > .mergify/config.yml | 97 +++++++ > .pytool/CISettings.py | 173 ++++++++++++ > .../CharEncodingCheck/CharEncodingCheck.py | 118 ++++++++ > .../CharEncodingCheck_plug_in.yaml | 11 + > .pytool/Plugin/CharEncodingCheck/Readme.md | 13 + > .../Plugin/CompilerPlugin/CompilerPlugin.py | 102 +++++++ > .../CompilerPlugin/Compiler_plug_in.yaml | 11 + > .../Plugin/DependencyCheck/DependencyCheck.py | 120 +++++++++ > .../DependencyCheck_plug_in.yaml | 13 + > .../DscCompleteCheck/DscCompleteCheck.py | 118 ++++++++ > .../DscCompleteCheck_plug_in.yaml | 12 + > .pytool/Plugin/DscCompleteCheck/readme.md | 22 ++ > .pytool/Plugin/GuidCheck/GuidCheck.py | 251 ++++++++++++++++++ > .../Plugin/GuidCheck/GuidCheck_plug_in.yaml | 11 + > .pytool/Plugin/GuidCheck/Readme.md | 60 +++++ > .../LibraryClassCheck/LibraryClassCheck.py | 153 +++++++++++ > .../LibraryClassCheck_plug_in.yaml | 11 + > .pytool/Plugin/LibraryClassCheck/readme.md | 22 ++ > .pytool/Plugin/SpellCheck/Readme.md | 100 +++++++ > .pytool/Plugin/SpellCheck/SpellCheck.py | 216 +++++++++++++++ > .../Plugin/SpellCheck/SpellCheck_plug_in.yaml | 11 + > .pytool/Plugin/SpellCheck/cspell.base.yaml | 165 ++++++++++++ > .pytool/Readme.md | 191 +++++++++++++ > BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 21 ++ > BaseTools/Bin/gcc_arm_linux_ext_dep.yaml | 21 ++ > BaseTools/Bin/iasl_ext_dep.yaml | 21 ++ > BaseTools/Bin/nasm_ext_dep.yaml | 18 ++ > .../BinWrappers/PosixLike/posix_path_env.yaml | 10 + > .../WindowsLike/win_build_tools_path_env.yaml | 10 + > BaseTools/Conf/tools_def.template | 18 +- > BaseTools/Edk2ToolsBuild.py | 163 ++++++++++++ > .../BuildToolsReportGenerator.py | 69 +++++ > .../BuildToolsReportGenerator_plug_in.yaml | 12 + > .../BuildToolsReport_Template.html | 126 +++++++++ > .../LinuxGcc5ToolChain/LinuxGcc5ToolChain.py | 85 ++++++ > .../LinuxGcc5ToolChain_plug_in.yaml | 12 + > .../WindowsResourceCompiler/WinRcPath.py | 29 ++ > .../WinRcPath_plug_in.yaml | 13 + > .../WindowsVsToolChain/WindowsVsToolChain.py | 126 +++++++++ > .../WindowsVsToolChain_plug_in.yaml | 11 + > .../basetool_tiano_python_path_env.yaml | 11 + > BaseTools/basetools_calling_path_env.yaml | 11 + > BaseTools/basetools_path_env.yaml | 11 + > BaseTools/set_vsprefix_envs.bat | 10 + > CryptoPkg/CryptoPkg.ci.yaml | 48 ++++ > FatPkg/FatPkg.ci.yaml | 50 ++++ > FmpDevicePkg/FmpDevicePkg.ci.yaml | 43 +++ > FmpDevicePkg/FmpDevicePkg.dsc | 6 +- > Maintainers.txt | 23 ++ > MdeModulePkg/MdeModulePkg.ci.yaml | 81 ++++++ > MdePkg/MdePkg.ci.yaml | 90 +++++++ > NetworkPkg/NetworkPkg.ci.yaml | 62 +++++ > NetworkPkg/NetworkPkg.dsc | 5 + > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 46 ++++ > Readme.md | 11 + > SecurityPkg/SecurityPkg.ci.yaml | 80 ++++++ > SecurityPkg/SecurityPkg.dsc | 32 ++- > ShellPkg/ShellPkg.ci.yaml | 55 ++++ > SignedCapsulePkg/SignedCapsulePkg.dsc | 38 ++- > UefiCpuPkg/UefiCpuPkg.ci.yaml | 51 ++++ > requirements.txt | 17 ++ > 69 files changed, 3878 insertions(+), 8 deletions(-) > create mode 100644 .azurepipelines/Ubuntu-GCC5.yml > create mode 100644 .azurepipelines/Ubuntu-PatchCheck.yml > create mode 100644 .azurepipelines/Windows-VS2019.yml > create mode 100644 .azurepipelines/templates/basetools-build-steps.yml > create mode 100644 .azurepipelines/templates/pr-gate-build-job.yml > create mode 100644 .azurepipelines/templates/pr-gate-steps.yml > create mode 100644 .azurepipelines/templates/spell-check-prereq-steps.ym= l > create mode 100644 .mergify/config.yml > create mode 100644 .pytool/CISettings.py > create mode 100644 .pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py > create mode 100644 .pytool/Plugin/CharEncodingCheck/CharEncodingCheck_pl= ug_in.yaml > create mode 100644 .pytool/Plugin/CharEncodingCheck/Readme.md > create mode 100644 .pytool/Plugin/CompilerPlugin/CompilerPlugin.py > create mode 100644 .pytool/Plugin/CompilerPlugin/Compiler_plug_in.yaml > create mode 100644 .pytool/Plugin/DependencyCheck/DependencyCheck.py > create mode 100644 .pytool/Plugin/DependencyCheck/DependencyCheck_plug_i= n.yaml > create mode 100644 .pytool/Plugin/DscCompleteCheck/DscCompleteCheck.py > create mode 100644 .pytool/Plugin/DscCompleteCheck/DscCompleteCheck_plug= _in.yaml > create mode 100644 .pytool/Plugin/DscCompleteCheck/readme.md > create mode 100644 .pytool/Plugin/GuidCheck/GuidCheck.py > create mode 100644 .pytool/Plugin/GuidCheck/GuidCheck_plug_in.yaml > create mode 100644 .pytool/Plugin/GuidCheck/Readme.md > create mode 100644 .pytool/Plugin/LibraryClassCheck/LibraryClassCheck.py > create mode 100644 .pytool/Plugin/LibraryClassCheck/LibraryClassCheck_pl= ug_in.yaml > create mode 100644 .pytool/Plugin/LibraryClassCheck/readme.md > create mode 100644 .pytool/Plugin/SpellCheck/Readme.md > create mode 100644 .pytool/Plugin/SpellCheck/SpellCheck.py > create mode 100644 .pytool/Plugin/SpellCheck/SpellCheck_plug_in.yaml > create mode 100644 .pytool/Plugin/SpellCheck/cspell.base.yaml > create mode 100644 .pytool/Readme.md > create mode 100644 BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml > create mode 100644 BaseTools/Bin/gcc_arm_linux_ext_dep.yaml > create mode 100644 BaseTools/Bin/iasl_ext_dep.yaml > create mode 100644 BaseTools/Bin/nasm_ext_dep.yaml > create mode 100644 BaseTools/BinWrappers/PosixLike/posix_path_env.yaml > create mode 100644 BaseTools/BinWrappers/WindowsLike/win_build_tools_pat= h_env.yaml > create mode 100644 BaseTools/Edk2ToolsBuild.py > create mode 100644 BaseTools/Plugin/BuildToolsReport/BuildToolsReportGen= erator.py > create mode 100644 BaseTools/Plugin/BuildToolsReport/BuildToolsReportGen= erator_plug_in.yaml > create mode 100644 BaseTools/Plugin/BuildToolsReport/BuildToolsReport_Te= mplate.html > create mode 100644 BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChai= n.py > create mode 100644 BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChai= n_plug_in.yaml > create mode 100644 BaseTools/Plugin/WindowsResourceCompiler/WinRcPath.py > create mode 100644 BaseTools/Plugin/WindowsResourceCompiler/WinRcPath_pl= ug_in.yaml > create mode 100644 BaseTools/Plugin/WindowsVsToolChain/WindowsVsToolChai= n.py > create mode 100644 BaseTools/Plugin/WindowsVsToolChain/WindowsVsToolChai= n_plug_in.yaml > create mode 100644 BaseTools/Source/Python/basetool_tiano_python_path_en= v.yaml > create mode 100644 BaseTools/basetools_calling_path_env.yaml > create mode 100644 BaseTools/basetools_path_env.yaml > create mode 100644 CryptoPkg/CryptoPkg.ci.yaml > create mode 100644 FatPkg/FatPkg.ci.yaml > create mode 100644 FmpDevicePkg/FmpDevicePkg.ci.yaml > create mode 100644 MdeModulePkg/MdeModulePkg.ci.yaml > create mode 100644 MdePkg/MdePkg.ci.yaml > create mode 100644 NetworkPkg/NetworkPkg.ci.yaml > create mode 100644 PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml > create mode 100644 SecurityPkg/SecurityPkg.ci.yaml > create mode 100644 ShellPkg/ShellPkg.ci.yaml > create mode 100644 UefiCpuPkg/UefiCpuPkg.ci.yaml > create mode 100644 requirements.txt >=20 > -- > 2.21.0.windows.1