From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.3854.1573517870814511246 for ; Mon, 11 Nov 2019 16:17:50 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Nov 2019 16:17:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,294,1569308400"; d="scan'208";a="202487059" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga007.fm.intel.com with ESMTP; 11 Nov 2019 16:17:50 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 Nov 2019 16:17:50 -0800 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 Nov 2019 16:17:49 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.63]) with mapi id 14.03.0439.000; Tue, 12 Nov 2019 08:17:48 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Feng, Bob C" Subject: Re: [edk2-devel] [Patch 0/4] Enhance Incremental Build Thread-Topic: [edk2-devel] [Patch 0/4] Enhance Incremental Build Thread-Index: AQHVmHQC44hGXkMVQkCAfkbA3AoGhKeGq+dQ Date: Tue, 12 Nov 2019 00:17:47 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E53CC50@SHSMSX104.ccr.corp.intel.com> References: <20191111093956.17032-1-bob.c.feng@intel.com> In-Reply-To: <20191111093956.17032-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Bob: This is a fundamental change. It needs more review and test.=20 But now, 201911 stable tag softfreeze will be coming on 11-15. So, I don= 't think this change will catch 201911 stable tag. Right?=20 Thanks Liming >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Bob Feng >Sent: Monday, November 11, 2019 5:40 PM >To: devel@edk2.groups.io >Subject: [edk2-devel] [Patch 0/4] Enhance Incremental Build > >Incremental build reduces the build time by only building >the module that need to update. Edk2 Build system is a Makefile >based build system. The incrememtal build ability is provided by >the Make program. But Edk2 build tool need to generate correct makefile >to have Make program do incremental build correctly. > >The current solution in build tool to support incremental build is that b= uild >tool find out the include file list for each source file of a module, and= in >module's >makefile, build tool add the include file list as the source file's depen= dency. >In this way Make program can decide if it need to rebuild a source code b= y >checking >its dependency. This solution has 2 shortcommings, one is the process of >finding >include list is slow, the other is this method can't handle case that >a MACRO in #include statement so the related source file is always built. > >This patch provides another method to support incremental build. That is = to >use >c preprocessor and trim tool to generate dependency files for the source = file. >This method will save much time in AutoGen phase and handle MACRO in >#include correctly. > >For C files: > 1. MSVS. > cl.exe has a build option /showIncludes to display include files = on stdout. >Build tool captures > that messages and generate dependency files, .deps files. > 2. CLANG and GCC > -MMD -MF build option are used to generate dependency files by >preprocessor. Build tool updates the > .deps files. >For ASL files: > 1. Trim find out all the included files, which are asl specific inclu= de format, >and generate .trim.deps file. > 2. ASL PP use c preprocessor to find out all included files with #inc= lude >format and generate a .deps file > 3. build tool updates the .deps file >For ASM files (.asm, .s or .nasm): > 1. Trim find out all the included files, which are asm specific inclu= de format, >and generate .trim.deps file. > 2. ASM PP use c preprocessor to find out all included files with #inc= lude >format and generate a deps file > 3. build tool updates the .deps file > >Build tool add "include" instruction for those deps files in the Makefile= . > >This patch does not support RVCT tool chain for the BZ >https://bugzilla.tianocore.org/show_bug.cgi?id=3D1750 > >Feng, Bob C (4): > BaseTools: Add build option for dependency file generation > BaseTools: Generate dependent files for ASL and ASM files > BaseTools: Update build_rule.txt to generate dependent files. > BaseTools: Enhance Basetool for incremental build > > BaseTools/Conf/build_rule.template | 94 ++++--- > BaseTools/Conf/tools_def.template | 173 ++++++------ > BaseTools/Source/Python/AutoGen/GenMake.py | 83 ++---- > .../Source/Python/AutoGen/IncludesAutoGen.py | 255 >++++++++++++++++++ > .../Source/Python/AutoGen/ModuleAutoGen.py | 23 ++ > BaseTools/Source/Python/Trim/Trim.py | 115 ++++++-- > BaseTools/Source/Python/build/build.py | 63 ++++- > 7 files changed, 588 insertions(+), 218 deletions(-) > create mode 100644 >BaseTools/Source/Python/AutoGen/IncludesAutoGen.py > >-- >2.20.1.windows.1 > > >