From: "Liming Gao" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [Patch 1/1] BaseTools: Enable MACRO for DSC Components section tag
Date: Tue, 12 Nov 2019 03:10:45 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E53CFC0@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20191112020350.22644-1-bob.c.feng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Feng, Bob C
>Sent: Tuesday, November 12, 2019 10:04 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
>Subject: [Patch 1/1] BaseTools: Enable MACRO for DSC Components section
>tag
>
>BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2308
>
>This patch is to enable MACRO for Components section architecture
>modifier.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>---
> BaseTools/Source/Python/Workspace/MetaFileParser.py | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/BaseTools/Source/Python/Workspace/MetaFileParser.py
>b/BaseTools/Source/Python/Workspace/MetaFileParser.py
>index 806fc322c56c..0a131fc76981 100644
>--- a/BaseTools/Source/Python/Workspace/MetaFileParser.py
>+++ b/BaseTools/Source/Python/Workspace/MetaFileParser.py
>@@ -326,10 +326,11 @@ class MetaFileParser(object):
> # S1 is always Arch
> if len(ItemList) > 1:
> S1 = ItemList[1].upper()
> else:
> S1 = TAB_ARCH_COMMON
>+ S1 = ReplaceMacro(S1, self._Macros)
> ArchList.add(S1)
>
> # S2 may be Platform or ModuleType
> if len(ItemList) > 2:
> if self._SectionName.upper() in SECTIONS_HAVE_ITEM_PCD_SET:
>--
>2.20.1.windows.1
prev parent reply other threads:[~2019-11-12 3:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 2:03 [Patch 1/1] BaseTools: Enable MACRO for DSC Components section tag Bob Feng
2019-11-12 3:10 ` Liming Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E53CFC0@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox